Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [BUG] scsi: lpfc: possible ABBA deadlock
To:     Jia-Ju Bai <baijiaju1990@gmail.com>, james.smart@broadcom.com,
        dick.kennedy@broadcom.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <652256c8-6fce-a506-76a9-e1502a5ff82e@gmail.com>
From:   James Smart <jsmart2021@gmail.com>
Message-ID: <5496b03b-49aa-88e3-e058-1d97c91b1b0b@gmail.com>
Date:   Sat, 24 Jul 2021 13:18:27 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <652256c8-6fce-a506-76a9-e1502a5ff82e@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 7/15/2021 3:37 AM, Jia-Ju Bai wrote:
> Hello,
> 
> I find there is a possible ABBA deadlock in the lpfc driver in Linux 5.10:
> 
> In lpfc_nvmet_unsol_fcp_issue_abort():
> 3502:     spin_lock_irqsave(&ctxp->ctxlock, flags);
> 3504: spin_lock(&phba->sli4_hba.abts_nvmet_buf_list_lock);
> 
> In lpfc_sli4_nvmet_xri_aborted():
> 1787: spin_lock(&phba->sli4_hba.abts_nvmet_buf_list_lock);
> 1794:     spin_lock(&ctxp->ctxlock);
> 
> When lpfc_nvmet_unsol_fcp_issue_abort() and 
> lpfc_sli4_nvmet_xri_aborted() are concurrently executed, the deadlock 
> can occur.
> 
> I am not quite sure whether this possible deadlock is real and how to 
> fix it if it is real.
> Any feedback would be appreciated, thanks :)
> 
> 
> Best wishes,
> Jia-Ju Bai

Jia-Ju,

It's a valid issue, but rather difficult to actually occur. We've put 
together a fix and am testing it. Will post when ready.

-- james