Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 25 Jul 2021 09:44:01 +0200
Message-ID: <s5hwnpehm7y.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Geraldo Nascimento <geraldogabriel@gmail.com>
Cc:     chihhao.chen@mediatek.com, alsa-devel@alsa-project.org,
        wsd_upstream@mediatek.com, damien@zamaudio.com, tiwai@suse.com,
        linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
        matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting
In-Reply-To: <CAEsQvcs3P+TqQFzQetPfRycpo66eJFwnzwhk2JyCXFaCLFHmFg@mail.gmail.com>
References: <1627100621-19225-1-git-send-email-chihhao.chen@mediatek.com>
        <s5h7dhgi1e2.wl-tiwai@suse.de>
        <CAEsQvcs3P+TqQFzQetPfRycpo66eJFwnzwhk2JyCXFaCLFHmFg@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sat, 24 Jul 2021 17:04:13 +0200,
Geraldo Nascimento wrote:
> 
> On Sat, Jul 24, 2021 at 8:05 AM Takashi Iwai <tiwai@suse.de> wrote:
> >
> > This looks like a regression introduced by the recent commit
> > d2e8f641257d ("ALSA: usb-audio: Explicitly set up the clock
> > selector"), which is a fix for certain devices.  Too bad that the
> > behavior really depends on the device...
> 
> Dr. Iwai, perhaps we could restrict the generalized fix for the
> Behringer UFX1604 / UFX1204 with some simple logic to devices that
> only have *one* clock source.
> 
> In that case the clock selector must be set to the only clock source.
> 
> This way we keep the generalization without breaking devices with more
> than one clock source.
> 
> Just an idea.

I don't think it's easy to generalize.  All those bugs are more or
less BIOS bugs, and a logic doesn't apply always, just because it's a
bug :)  For example, setting the clock selector itself should be a
valid operation from the specification POV, while this leads to
breakage on some devices.  So, even if we add a more generic
workaround, we need to see which side effect is more commonly seen at
first.


Takashi