Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp2672132pxv; Sun, 25 Jul 2021 01:39:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzEK+NG2HEV/PA0i9clrGMKsc3QEcORPnWKSTbC/4vorRPZHSzG9kBmc6aVpqb8gSDEQiMs X-Received: by 2002:a17:907:7296:: with SMTP id dt22mr12382462ejc.86.1627202380827; Sun, 25 Jul 2021 01:39:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627202380; cv=none; d=google.com; s=arc-20160816; b=Zon+BJhGWn3+Mcqp8tgXZri+3zOHboGjOfmWiC6aUV/ULmcvYYgojsoetEgZ6hwtYw wDQWHMUCxlrVLba4hzaZkWLi6IWyLEvtvoJJGTfvq9cd0b8teGF6cjPgRIFrf+Aiv+Xc PdenjUCk2jzqFMFJ4MJDP7+VT5lpSubQ84m9i8PW0lxhTQBZytcp0ElYiFqpgkTYhn+O d7gvDkL+BUUgne/jFApFDhKl5A2/b2tyuIC1xtw+Ep1JqnGh/piAVSx/wcznYvcRbuEG bVrUhUwXJ/guV2xXAl+y65ygF9GQKRJLW6RpHABnMp28aB3MWYAL8tJzbLjNLPxafISM cz7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:date:message-id:from:references:cc:to :dkim-signature:subject; bh=XMDPb1pPl3PoQQ83a9gmENv6+Js5xeBQrgRul+VOSA8=; b=05ua1cR+UtumDnmbKWXc+rWB3JZwpWdaJRn2fypeJA+ql0PaWlQuf56Zmgfuj4UHi6 jtnRx/W34NeIoG7GD5JduMnXPs4f17pZM9UmElHaBfdzG2juJmOR2ixNsyYnlJTo/6xH UBZKC6A84mNEL/qGmxs6ZfR/4yDahVOy0mLEb/Ax5/KcJuqSR1m/c3Rr13+TkeNEh1hw vP4246rDZJPMKqeX/nQz6YCOzZK0pGMhu4njZxbRmqqnZzUHfmktK5mzAzCiNZLOUObP ltin4HSCeNUw0l/mgRvP90gkz/8uGwhiEgxf0aG8/1XS3bUA/6N6tp28vZSlc99oPMNu rPgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=NMob4IOx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jp3si37198556ejb.706.2021.07.25.01.39.17; Sun, 25 Jul 2021 01:39:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=NMob4IOx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230285AbhGYH5P (ORCPT + 99 others); Sun, 25 Jul 2021 03:57:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229853AbhGYH5P (ORCPT ); Sun, 25 Jul 2021 03:57:15 -0400 Received: from out2.migadu.com (out2.migadu.com [IPv6:2001:41d0:2:aacc::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF625C061757; Sun, 25 Jul 2021 01:37:45 -0700 (PDT) Subject: Re: [PATCH] mlx4: Fix missing error code in mlx4_load_one() DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1627202261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XMDPb1pPl3PoQQ83a9gmENv6+Js5xeBQrgRul+VOSA8=; b=NMob4IOxzOJIflzmWNgdGZpMurTIcvdCJcDmG3YjcOCWkVGU1V/BiETNFBlfO8qsMvKgUg gruh7+sVDdprhByWJ4snzZeHR0jd7pPKSVjzWxQQh1nNwB+ex1hidp65gcP800GQUe8nyo 1G6THX5FnUllnpgbBpIFT4XDg6SsNOs= To: Jiapeng Chong , tariqt@nvidia.com Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org References: <1627036569-71880-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Gal Pressman Message-ID: <9a9cfded-cbce-b36d-77f1-020caeaf6052@linux.dev> Date: Sun, 25 Jul 2021 11:37:38 +0300 MIME-Version: 1.0 In-Reply-To: <1627036569-71880-1-git-send-email-jiapeng.chong@linux.alibaba.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: gal.pressman@linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/07/2021 13:36, Jiapeng Chong wrote: > The error code is missing in this code scenario, add the error code > '-EINVAL' to the return value 'err'. > > Eliminate the follow smatch warning: > > drivers/net/ethernet/mellanox/mlx4/main.c:3538 mlx4_load_one() warn: > missing error code 'err'. > > Reported-by: Abaci Robot > Fixes: 7ae0e400cd93 ("net/mlx4_core: Flexible (asymmetric) allocation of > EQs and MSI-X vectors for PF/VFs") Fixes line shouldn't be wrapped. > Signed-off-by: Jiapeng Chong > --- > drivers/net/ethernet/mellanox/mlx4/main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c > index 00c8465..28ac469 100644 > --- a/drivers/net/ethernet/mellanox/mlx4/main.c > +++ b/drivers/net/ethernet/mellanox/mlx4/main.c > @@ -3535,6 +3535,7 @@ static int mlx4_load_one(struct pci_dev *pdev, int pci_dev_data, > > if (!SRIOV_VALID_STATE(dev->flags)) { > mlx4_err(dev, "Invalid SRIOV state\n"); > + err = -EINVAL; > goto err_close; > } > } > I think this patch is missing a few occurrences: https://elixir.bootlin.com/linux/v5.14-rc2/source/drivers/net/ethernet/mellanox/mlx4/main.c#L3455 https://elixir.bootlin.com/linux/v5.14-rc2/source/drivers/net/ethernet/mellanox/mlx4/main.c#L3468 https://elixir.bootlin.com/linux/v5.14-rc2/source/drivers/net/ethernet/mellanox/mlx4/main.c#L3490