Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 25 Jul 2021 16:02:04 +0200
From:   Len Baker <len.baker@gmx.com>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Len Baker <len.baker@gmx.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Phil Reid <preid@electromag.com.au>,
        DRI Development <dri-devel@lists.freedesktop.org>,
        Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
        linux-staging@lists.linux.dev,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] staging/fbtft: Fix braces coding style
Message-ID: <20210725140204.GB1953@titan>
References: <20210724151411.9531-1-len.baker@gmx.com>
 <20210724151411.9531-4-len.baker@gmx.com>
 <CAMuHMdX6PUr0irndogg=Aa+AFDdiDJMeMWM74mLBkuLrW+zWng@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMuHMdX6PUr0irndogg=Aa+AFDdiDJMeMWM74mLBkuLrW+zWng@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Sat, Jul 24, 2021 at 08:01:53PM +0200, Geert Uytterhoeven wrote:
> Hi Len,
>
> On Sat, Jul 24, 2021 at 7:44 PM Len Baker <len.baker@gmx.com> wrote:
> > Add braces to the "for" loop and remove braces from the "if" statement=
.
> > This way the kernel coding style is followed.
> >
> > Signed-off-by: Len Baker <len.baker@gmx.com>
>
> Thanks for your patch!
>
> > --- a/drivers/staging/fbtft/fbtft-core.c
> > +++ b/drivers/staging/fbtft/fbtft-core.c
>
> > @@ -1016,10 +1018,9 @@ int fbtft_init_display(struct fbtft_par *par)
> >
> >         i =3D 0;
> >         while (i < FBTFT_MAX_INIT_SEQUENCE) {
> > -               if (par->init_sequence[i] =3D=3D -3) {
> > -                       /* done */
> > -                       return 0;
> > -               }
>
> These braces should not be removed, due to the presence of
> the comment.

Ok, I leave it as is.

Thanks,
Len