Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp2893392pxv; Sun, 25 Jul 2021 09:03:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzfD/DlNNoqQS9TWpZxzrYKuZ6mRqF/S44DbIQgLlw1pZgnuH68J4sJ8Z35I75XtmAY2z42 X-Received: by 2002:a17:906:aaca:: with SMTP id kt10mr13484548ejb.127.1627228989493; Sun, 25 Jul 2021 09:03:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627228989; cv=none; d=google.com; s=arc-20160816; b=dGsP9NAwAAyodrMqmUssH0oO/VZvUeXEuvQ9HezwkMvWZEa7GY33jDhjtUyKFUKpZg dY2csTmUePCG9l3o2ddxYr6y5ZPeSFg1KIsCkGxjzl2oSSqQtAcdiVuA3367WPPXWD6/ 2gdNHEXZw4Pbs/2oorOrm+Vi9NdwYm/RAtoyOPSEC/Aq79lL3hj1VSi6V8DfycbeStXP +xE680MW0TG9Dh1Gc5FvhVE62hQhDVzNWNofRG7GHol8QWpXSaTVIOQqyOxVwpk/Xv0A wMfu4CZ5WGK4qzEi97MYJMBHoIZGdCaVxavW+nsy9i/Rc1bBbkNu+UHkECaWF9QLfX9t Wcyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=a/TQws9fBMSZvwvkix9qWTV0iF552elb9vV5rrq/lLY=; b=PYw6LD1u23m5/xdJnj9HWBdfZdvc+ClhSyIocmDf5FeKgRiJlhfGYYnmB1TCpG7nBW S4vaqxe6iVrsDApUjVimk4q7aZHpKag0vZru9i7wbPYjJX0U+wy8Os0QdmDjtWT2faAK 1SO4LY61GzLnnXjsMjUuF4/fBGGC30OmlL8nlYt64L5vwlhYAPllMcEQ4kkOa0G2JAFx ZVgrCZHYZuXRDqnsRM3MAGBMzHMgZIgZQn9P7pUZYr/F2OmwtYx4yaxlvgzd3/Qx84v+ tDqCq1ZGeZ5f5XeM4bfhFo6QgmK5MDCax/4zwVcb3Y4xOVV2/yWxkUyeHBtL4aMSiAf4 qH3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z5si30432335edc.357.2021.07.25.09.02.17; Sun, 25 Jul 2021 09:03:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231463AbhGYPTY (ORCPT + 99 others); Sun, 25 Jul 2021 11:19:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231358AbhGYPS5 (ORCPT ); Sun, 25 Jul 2021 11:18:57 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C0EAC061760; Sun, 25 Jul 2021 08:59:28 -0700 (PDT) Received: from dslb-188-096-139-014.188.096.pools.vodafone-ip.de ([188.96.139.14] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1m7gXF-0000SM-Ko; Sun, 25 Jul 2021 17:59:25 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 03/18] staging: rtl8188eu: remove HW_VAR_TXPAUSE Date: Sun, 25 Jul 2021 17:58:47 +0200 Message-Id: <20210725155902.32433-3-martin@kaiser.cx> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210725155902.32433-1-martin@kaiser.cx> References: <20210725155902.32433-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The "HAL layer variable" HW_VAR_TXPAUSE is not used in this driver. Remove its define and the code for setting and for reading a value. Signed-off-by: Martin Kaiser --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 6 ------ drivers/staging/rtl8188eu/include/hal_intf.h | 1 - 2 files changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 633feae0fca5..79e86ed8798e 100644 --- a/drivers/staging/rtl8188eu/hal/usb_halinit.c +++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c @@ -1178,9 +1178,6 @@ void rtw_hal_set_hwreg(struct adapter *Adapter, u8 variable, u8 *val) usb_write8(Adapter, REG_INIRTS_RATE_SEL, RateIndex); } break; - case HW_VAR_TXPAUSE: - usb_write8(Adapter, REG_TXPAUSE, *((u8 *)val)); - break; case HW_VAR_BCN_FUNC: hw_var_set_bcn_func(Adapter, variable, val); break; @@ -1613,9 +1610,6 @@ void rtw_hal_get_hwreg(struct adapter *Adapter, u8 variable, u8 *val) case HW_VAR_BASIC_RATE: *((u16 *)(val)) = Adapter->HalData->BasicRateSet; fallthrough; - case HW_VAR_TXPAUSE: - val[0] = usb_read8(Adapter, REG_TXPAUSE); - break; case HW_VAR_BCN_VALID: /* BCN_VALID, BIT16 of REG_TDECTRL = BIT0 of REG_TDECTRL+2 */ val[0] = (BIT(0) & usb_read8(Adapter, REG_TDECTRL + 2)) ? true : false; diff --git a/drivers/staging/rtl8188eu/include/hal_intf.h b/drivers/staging/rtl8188eu/include/hal_intf.h index e2ce71db3fa1..ad0a6bd5f510 100644 --- a/drivers/staging/rtl8188eu/include/hal_intf.h +++ b/drivers/staging/rtl8188eu/include/hal_intf.h @@ -18,7 +18,6 @@ enum hw_variables { HW_VAR_BSSID, HW_VAR_INIT_RTS_RATE, HW_VAR_BASIC_RATE, - HW_VAR_TXPAUSE, HW_VAR_BCN_FUNC, HW_VAR_CORRECT_TSF, HW_VAR_CHECK_BSSID, -- 2.20.1