Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp2895277pxv; Sun, 25 Jul 2021 09:06:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrPnS34ulm+WPqNEpB0arEMuZ4SQVHUfrindU/DxKiaeXWzciFFmPVlZbXFL/Yd/uJNL8d X-Received: by 2002:a17:906:d8a7:: with SMTP id qc7mr6886454ejb.372.1627229164194; Sun, 25 Jul 2021 09:06:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627229164; cv=none; d=google.com; s=arc-20160816; b=I3ajg5p5NvL/SDEaY583sTMUd5CWq+Xq56Ujbo2j/PWEmAHG7nMdA1mcHPz9ORBxdv R8J07hhsKinXwD17wDJK19EIi5dN5FVlzyCqvzJEwKpK0qT5j+7wJQbnT5atu9MQ5LtC xskGEQr3ZR2STYr1PWL0uV5703Hnd/Sv1LuKk4GjTQoPXXOHsCOhlNujQZZP7ZoNGo5Y Oh1U+sM0ZptF0eJ4DZGhrKoCMx9L36Wsq9Tk/JQC6utPnIaMelDqu6v2BWBDX8U84NVG /ZcZSrcrVoHJn5KyU5z5J7QMKRwUFN+Z2snxvZnczMjovdePjAsHvSArPskwZt6362kB GW3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=EP8zcvB1Q3JpQwNG5/+YCr+ZjIINjE06lT/tcaBSGBY=; b=sbnryVzQ1+UMH6KJNQFjVfQYqFBgVj91YkyRlfkeJrlKqNxgreNK3Agoy6jOYywp41 jU9m28kYyPfNKDO3hpDWb9EGpvsiwTddwRtFbWzTaohLQbLXaCS7xhTmzIpy6cZm52m6 uFtimb2l1R/YsDtyEx/yACRjzlwHdjD32u5nw354qzOdc0NA3tjuaHynMLylsWs+bw4q 8hB9Y7B05k7YwR1nSMCJ+Lk2N0VnrGLgnp+Ix1lZnIg8Ha8rGeAaLWKRp6F+4aFLV2jt M7Pqa/Lu71+YyCd4cHiG8smQ/y8QDwhWH7vNoI8xlZHYO/IOyT//kYYhBeUpWJlhgGha VMmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si11215869edm.47.2021.07.25.09.05.25; Sun, 25 Jul 2021 09:06:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231808AbhGYPTr (ORCPT + 99 others); Sun, 25 Jul 2021 11:19:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231380AbhGYPTF (ORCPT ); Sun, 25 Jul 2021 11:19:05 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C4F1C061757; Sun, 25 Jul 2021 08:59:35 -0700 (PDT) Received: from dslb-188-096-139-014.188.096.pools.vodafone-ip.de ([188.96.139.14] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1m7gXN-0000SM-56; Sun, 25 Jul 2021 17:59:33 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 11/18] staging: rtl8188eu: remove two write-only hal components Date: Sun, 25 Jul 2021 17:58:55 +0200 Message-Id: <20210725155902.32433-11-martin@kaiser.cx> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210725155902.32433-1-martin@kaiser.cx> References: <20210725155902.32433-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org RegTxPause and RegBcnCtrlVal from struct hal_data_8188e are set but never read. Remove them. Signed-off-by: Martin Kaiser --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 -- drivers/staging/rtl8188eu/include/rtl8188e_hal.h | 3 --- 2 files changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 6af411e0c28e..62013999c569 100644 --- a/drivers/staging/rtl8188eu/hal/usb_halinit.c +++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c @@ -563,8 +563,6 @@ static void _InitBeaconParameters(struct adapter *Adapter) /* beacause test chip does not contension before sending beacon. by tynli. 2009.11.03 */ usb_write16(Adapter, REG_BCNTCFG, 0x660F); - haldata->RegBcnCtrlVal = usb_read8(Adapter, REG_BCN_CTRL); - haldata->RegTxPause = usb_read8(Adapter, REG_TXPAUSE); haldata->RegFwHwTxQCtrl = usb_read8(Adapter, REG_FWHW_TXQ_CTRL + 2); haldata->RegReg542 = usb_read8(Adapter, REG_TBTT_PROHIBIT + 2); haldata->RegCR_1 = usb_read8(Adapter, REG_CR + 1); diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_hal.h b/drivers/staging/rtl8188eu/include/rtl8188e_hal.h index e508b4b9ef7f..9aba67233c24 100644 --- a/drivers/staging/rtl8188eu/include/rtl8188e_hal.h +++ b/drivers/staging/rtl8188eu/include/rtl8188e_hal.h @@ -230,9 +230,6 @@ struct hal_data_8188e { /* for host message to fw */ u8 LastHMEBoxNum; - u8 RegTxPause; - /* Beacon function related global variable. */ - u32 RegBcnCtrlVal; u8 RegFwHwTxQCtrl; u8 RegReg542; u8 RegCR_1; -- 2.20.1