Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 25 Jul 2021 18:30:39 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Yasushi SHOJI <yasushi.shoji@gmail.com>
Cc:     Pavel Skripkin <paskripkin@gmail.com>, wg@grandegger.com,
        linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, Yasushi SHOJI <yashi@spacecubics.com>
Subject: Re: [PATCH] net: can: add missing urb->transfer_dma initialization
Message-ID: <20210725163039.kyugkdmyn5p3o5r2@pengutronix.de>
References: <20210725094246.pkdpvl5aaaftur3a@pengutronix.de>
 <20210725103630.23864-1-paskripkin@gmail.com>
 <CAELBRWKfyOBanMBteO=LpL9R1QMp97zTYtKY689jeR2gDOa_Gw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="6c5tzy4pflvjriu6"
Content-Disposition: inline
In-Reply-To: <CAELBRWKfyOBanMBteO=LpL9R1QMp97zTYtKY689jeR2gDOa_Gw@mail.gmail.com>
Precedence: bulk


--6c5tzy4pflvjriu6
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 25.07.2021 22:27:37, Yasushi SHOJI wrote:
> Hi Pavel,
>=20
> I've tested this patch on top of v5.14-rc2.  All good.
>=20
> Tested-by: Yasushi SHOJI <yashi@spacecubics.com>
>=20
> Some nitpicks.
>=20
> On Sun, Jul 25, 2021 at 7:36 PM Pavel Skripkin <paskripkin@gmail.com> wro=
te:
> >
> > Yasushi reported, that his Microchip CAN Analyzer stopped working since
> > commit 91c02557174b ("can: mcba_usb: fix memory leak in mcba_usb").
> > The problem was in missing urb->transfer_dma initialization.
> >
> > In my previous patch to this driver I refactored mcba_usb_start() code =
to
> > avoid leaking usb coherent buffers. To achive it, I passed local stack
>=20
> achieve
>=20
> > variable to usb_alloc_coherent() and then saved it to private array to
> > correctly free all coherent buffers on ->close() call. But I forgot to
> > inialize urb->transfer_dma with variable passed to usb_alloc_coherent().
>=20
> initialize

Fixed while applying.

Thanks,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--6c5tzy4pflvjriu6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmD9ka0ACgkQqclaivrt
76k0owf8D7/UgJq6FTxUfwa8X6GgsUGtuxduh6myuhV82vfV/Bq9YiGDoyIHp6ho
asnWUi34JmPh3Qxfbmrb3If4GJmCjfENMbxdQCKXYpgPr/ED0b77VBKr/X+FkJN6
VEVpfu/lndw+xtrZE+o7uBM/F1TzAlcyOd8j8zsHrND8aUhnSXc7apxGeFdyYiev
3AjuwNZPn8LyArQVPptlB2uZPhQXzpajEYdxdmEwU5tKbg5td3RbR1iUECgQ8mg7
VbFOTDa2ivDuVyl/zcqg87McltmxfzxsCTxC4oqeatFTjKVPYNWFc6X5adWwQ1+d
noIrZtR34OORwPkE9HUeR5/s6RTpsA==
=tmG8
-----END PGP SIGNATURE-----

--6c5tzy4pflvjriu6--