Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755847AbWKWELe (ORCPT ); Wed, 22 Nov 2006 23:11:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755865AbWKWELd (ORCPT ); Wed, 22 Nov 2006 23:11:33 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:39552 "EHLO sunset.davemloft.net") by vger.kernel.org with ESMTP id S1755796AbWKWELd (ORCPT ); Wed, 22 Nov 2006 23:11:33 -0500 Date: Wed, 22 Nov 2006 20:11:36 -0800 (PST) Message-Id: <20061122.201136.129449260.davem@davemloft.net> To: okir@suse.de Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Make udp_encap_rcv use pskb_may_pull From: David Miller In-Reply-To: <20061123000144.GB7452@suse.de> References: <20061123000144.GB7452@suse.de> X-Mailer: Mew version 4.2 on Emacs 21.4 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 911 Lines: 22 From: Olaf Kirch Date: Thu, 23 Nov 2006 01:01:44 +0100 > > Make udp_encap_rcv use pskb_may_pull > > IPsec with NAT-T breaks on some notebooks using the latest e1000 chipset, > when header split is enabled. When receiving sufficiently large packets, the > driver puts everything up to and including the UDP header into the header > portion of the skb, and the rest goes into the paged part. udp_encap_rcv > forgets to use pskb_may_pull, and fails to decapsulate it. Instead, it > passes it up it to the IKE daemon. > > Signed-off-by: Olaf Kirch > Signed-off-by: Jean Delvare Excellent catch, applied, thanks Olaf. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/