Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210726071404.14529-1-aardelean@deviqon.com> <20210726071404.14529-4-aardelean@deviqon.com>
In-Reply-To: <20210726071404.14529-4-aardelean@deviqon.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 26 Jul 2021 10:20:07 +0300
Message-ID: <CAHp75Vem3Q5vRknvWrZSsX4_+2j7fGtU6RcLzCHEr2AA67eZfA@mail.gmail.com>
Subject: Re: [PATCH 3/4] iio: st_sensors: remove all driver remove functions
To:     Alexandru Ardelean <aardelean@deviqon.com>
Cc:     linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Denis Ciocca <denis.ciocca@st.com>,
        Jonathan Cameron <jic23@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jul 26, 2021 at 10:14 AM Alexandru Ardelean
<aardelean@deviqon.com> wrote:
>
> At this point all ST driver remove functions do iio_device_unregister().
> This change removes them from them and replaces all iio_device_register()
> with devm_iio_device_register().
>
> This can be done in a single change relatively easy, since all these remove

easily

> functions are define in st_sensors.h.

defined

>  drivers/iio/imu/st_lsm9ds0/st_lsm9ds0.h      |  1 -
>  drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c | 15 +--------------
>  drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c  |  6 ------
>  drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c  |  6 ------

I will check these later on, but the rule of thumb about devm_*() is
that there shouldn't be gaps (non-devm) before any devm call.

-- 
With Best Regards,
Andy Shevchenko