Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3319071pxv; Mon, 26 Jul 2021 01:03:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwaPNa+bCeWBa7B8JYr07wLiq8WhKaOzTDCHxsrSQifueHrlWDojbPanCVvpeTAsI5S+Mq+ X-Received: by 2002:a02:c906:: with SMTP id t6mr15532124jao.117.1627286611191; Mon, 26 Jul 2021 01:03:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627286611; cv=none; d=google.com; s=arc-20160816; b=HBtkcdjM/Vsm05LUYCBzCg/JCe+pkFL0UdXAEDj7RYEJf12Bl3zEXgohEJBeMANLjJ dy9RHnfWoUNjB8m/peECA9Mv52re4wZXrhR5gzvifjLcq50ZUWC0xojgKJq/oNpstJ24 DfnzB/QYTMD5Y17g67InszNpaWAsOYiYyReJ7DV47M4QvI2kABqa1T4YR6fwfZMmAM08 yh8nePxcZ+1PDjmzZnwd/wP641oEqnAUxlaycmeA9MFljE8rUvXJoO6EOXj272F49iHV SVVhgdG7zQnTJy/XpJGciPGayWD9fGVUEAhKIKRCdkxt/nC+ki5fNjOglFDGEXlu3k5F ZoZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=nBC+AAdhNSp6Y9PCeNESZDrAjbJvLVNma/9NfsdXY8Q=; b=EBRKSPdy88LbTggCVsU+Og1zQwDsSTb0trQAI/CfWRXlrBgDWzAgpT5yH3HTQ9kE/h Jsebq+iS4peB/ZC7LvoSbB4JHn8cle/dy9jh9ZEzsAerCQ4//9dphDB8sGOpVznxUtv4 v7fTRYqhUUuVsb5phGJb6JOkbyN8No4FJs73nelspTKqmiQupqnN33ft/sbyN1rCi4F7 7hF2NzbNcHIhim8Kv+UoaIy1xZ1vhab6tt/EH5UXN7LJ3uMXP3HyN4/NjqV4MGzArokO 4pbe63mX+7KqJxOgZA7mPaDcQEo4oUDNF/isHQ7KWd9ExmDCeVyOAtWLORun6w/CFQgN pgRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=AXP8voMc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u5si49213071jad.124.2021.07.26.01.03.20; Mon, 26 Jul 2021 01:03:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=AXP8voMc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232779AbhGZHWL (ORCPT + 99 others); Mon, 26 Jul 2021 03:22:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232435AbhGZHWK (ORCPT ); Mon, 26 Jul 2021 03:22:10 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 738A8C061760 for ; Mon, 26 Jul 2021 01:02:23 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id b21so10238305ljo.13 for ; Mon, 26 Jul 2021 01:02:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nBC+AAdhNSp6Y9PCeNESZDrAjbJvLVNma/9NfsdXY8Q=; b=AXP8voMcitYr0FtY19uK6rPp9WgozJUcA/Z+cX/hXU4xDU77JzIPu0wMKOeI15djiG HisdjAnSIvZLpxqpCQaCCCkN6xPnuESllQ4+5pvuNQqMPqi2xMzBefZqP5qYLW143+bl J4xthycSsZ19yOHBcO/Gq9BD/nTkSzXWhnXMc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nBC+AAdhNSp6Y9PCeNESZDrAjbJvLVNma/9NfsdXY8Q=; b=B1Sx8zr3ql2LyYMF6iCCmQNzPGenIj5ld7QayfGdqIDDf9wRbLFxJUI9Ne83aGuZwx dQqYP3AKVCmNtYwuPAK4bU+2C05zzMTqhSnoe9HkmAVukL7VO6QnrmB/dm4VhckFFXjg N9UBe7oUIO8fAt9qZ4BfjPCitYqZ3XyMdzZX95ScvD9R00ATFidC9g9cCI6i4/4EKbuf +FOyvpqry2WFcm0+65gTmFzV/CMC48dIEfUFI//UaQQ2S5LNBkp4u1Bu3Rp5re2wqIFG GK/EagYox40pOIHQ6OrPldJRufjf+h874pY6UMKQ8TjM0o2nRAGIumf00AEwsPiZvpac 5ljg== X-Gm-Message-State: AOAM532yOdXAOsuXNCVA4HkcbchrDZ48fImVim/5aVoOtMA1vi19DtYz cycUhGYKatoRqlxQOR643Gi2pQCsOJ1Cbvv02lZFC1I4W5sulCNX X-Received: by 2002:a2e:760d:: with SMTP id r13mr11728695ljc.437.1627286540610; Mon, 26 Jul 2021 01:02:20 -0700 (PDT) MIME-Version: 1.0 References: <20210710081722.1828-1-zhiyong.tao@mediatek.com> <20210710081722.1828-2-zhiyong.tao@mediatek.com> <1626940470.29611.9.camel@mhfsdcap03> In-Reply-To: <1626940470.29611.9.camel@mhfsdcap03> From: Chen-Yu Tsai Date: Mon, 26 Jul 2021 16:02:09 +0800 Message-ID: Subject: Re: [PATCH v10 1/2] dt-bindings: pinctrl: mt8195: add rsel define To: zhiyong tao Cc: Rob Herring , Linus Walleij , mark.rutland@arm.com, Matthias Brugger , Sean Wang , srv_heupstream , hui.liu@mediatek.com, Eddie Huang , light.hsieh@mediatek.com, biao.huang@mediatek.com, hongzhou.yang@mediatek.com, sean.wang@mediatek.com, seiya.wang@mediatek.com, devicetree@vger.kernel.org, LKML , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 22, 2021 at 3:54 PM zhiyong tao wrote: > > On Tue, 2021-07-13 at 15:17 +0800, Chen-Yu Tsai wrote: > > Hi, > > > > On Sat, Jul 10, 2021 at 4:17 PM Zhiyong Tao wrote: > > > > > > This patch adds rsel define for mt8195. > > > > > > Signed-off-by: Zhiyong Tao > > > --- > > > include/dt-bindings/pinctrl/mt65xx.h | 9 +++++++++ > > > 1 file changed, 9 insertions(+) > > > > > > diff --git a/include/dt-bindings/pinctrl/mt65xx.h b/include/dt-bindings/pinctrl/mt65xx.h > > > index 7e16e58fe1f7..f5934abcd1bd 100644 > > > --- a/include/dt-bindings/pinctrl/mt65xx.h > > > +++ b/include/dt-bindings/pinctrl/mt65xx.h > > > @@ -16,6 +16,15 @@ > > > #define MTK_PUPD_SET_R1R0_10 102 > > > #define MTK_PUPD_SET_R1R0_11 103 > > > > > > +#define MTK_PULL_SET_RSEL_000 200 > > > +#define MTK_PULL_SET_RSEL_001 201 > > > +#define MTK_PULL_SET_RSEL_010 202 > > > +#define MTK_PULL_SET_RSEL_011 203 > > > +#define MTK_PULL_SET_RSEL_100 204 > > > +#define MTK_PULL_SET_RSEL_101 205 > > > +#define MTK_PULL_SET_RSEL_110 206 > > > +#define MTK_PULL_SET_RSEL_111 207 > > > + > > > > Instead of all the obscure macros and the new custom "rsel" property, > > which BTW is not in the bindings, can't we just list the actual bias > > resistance of each setting? We could also migrate away from R1R0. > > > ==>Hi Chenyu, > The rsel actual bias resistance of each setting: > > MTK_PULL_SET_RSEL_000:75K in PU, 75k in PD; > MTK_PULL_SET_RSEL_001:10k in PU, 5k in PD; > MTK_PULL_SET_RSEL_010:5k in PU, 75k in PD; > MTK_PULL_SET_RSEL_011:4k in PU, 5K in PD; > MTK_PULL_SET_RSEL_100:3k in PU, 75k in PD; > MTK_PULL_SET_RSEL_101:2k in PU, 5K in PD; > MTK_PULL_SET_RSEL_110:1.5k in PU, 75k in PD; > MTK_PULL_SET_RSEL_111:1k in PU, 5k in PD. > > The rsel actual bias resistance is different between PU and PD. Thanks. Somehow I missed this when looking through the datasheet. This encoding is interesting. Since it doesn't make sense to have both pull-up and pull-down, even though the hardware seems capable of doing so, I suppose the intent is to support 75k or 5k for pull-down, and (75k, 10k, 5k, 4k, 3k, 2k, 1.5k, 1k) for pull-up? We could add these values to the binding so we could check for misuse. The range of values seems to also cover those supported by the alternative R0/R1 settings. The values for kprow[01] and kpcol[01] seem to be different though. We should get rid of the MTK_PUPD_SET_R1R0_* macros at the same time. They seem to be some magic values used with bias-pull-*, which is not how the properties should be used. At the same time, they overlap with mediatek,pull-* properties. It would be great if we could standardize on the generic pinconf properties, and also use real values that fit the requirements of the properties, i.e. using real resistance values. I'm not sure if it would make sense to enumerate which pins support which configurations though. Thanks ChenYu > > Then we can specify the setting with the standard bias-pull-up/down > > properties [1]. > > > > Also, please ask internally if Mediatek could relicense all the header > > files that Mediatek has contributed under include/dt-bindings/pinctrl/ [2] > > to GPL-2.0 and BSD dual license. These files are part of the DT bindings > > and we really want them to be dual licensed as well, and not just the > > YAML files. > > > > ==> We will confirm it internally and reply it later. > > Thanks. > > > > Regards > > ChenYu > > > > > > [1] https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml#L37 > > [2] Note that a few files were contributed by other people > > > > > #define MTK_DRIVE_2mA 2 > > > #define MTK_DRIVE_4mA 4 > > > #define MTK_DRIVE_6mA 6 > > > -- > > > 2.18.0 > > > _______________________________________________ > > > Linux-mediatek mailing list > > > Linux-mediatek@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/linux-mediatek >