Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 26 Jul 2021 11:11:48 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Len Baker <len.baker@gmx.com>
Cc:     David Laight <David.Laight@ACULAB.COM>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Pavel Skripkin <paskripkin@gmail.com>,
        "linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging/rtl8712: Remove all strcpy() uses in favor of
 strscpy()
Message-ID: <20210726081148.GF1931@kadam>
References: <20210717155145.15041-1-len.baker@gmx.com>
 <20210719053747.GN1931@kadam>
 <de94438319a84e0985b3ba0f5c00807b@AcuMS.aculab.com>
 <20210721080624.GV1931@kadam>
 <20210723151510.GB2612@titan>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210723151510.GB2612@titan>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kadam (102.222.70.252) by JN2P275CA0022.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:3::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.24 via Frontend Transport; Mon, 26 Jul 2021 08:12:02 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 52cb9f3d-9e3a-4dc8-c8dc-08d9500d0f92
X-MS-TrafficTypeDiagnostic: MWHPR10MB1295:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MWHPR10MB1295BF0344205050568551278EE89@MWHPR10MB1295.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: FmXeMhaciWYwU+p6Jeakhe6rlFKr39Q7BOEaNO70qNnG2kMnti71RvP8Y7KzxyYvTMGP2PAR6yswgdDPMyYMOZ85mK/y/7JxbHkrtEBm2PbA44kl/010OGxopHkcB8pZHWTmTUAnH4vJQ3FTAZD+82rP/c7vu7iED9fq8o3Zk8rro7F13cn2ucE92gl71Oyp+WL27Fvxv/h+BpwJSU7MP1pahaWtSc8eDRTRoSQQo8EOl3q+aTuaXk0eHTl/xUrIPcpODqmV2OQminqT3QMe2yj/P5+GVZdOdl1iEdNl5ou902wwUny6GxzycJNHLQ+xba+ewSmFhTUTmDDpU+QpGsO2d3mITq4A9MHLWQRgH72Mql8oOTBVotOIZj/DVsfEazq2bA4A9UN/+BvgUTRDzN9sSpI37JTzt0JN7HlzfUo0Zkz8GZubgkBeQDoVzfXt2iFkHhJCd1tKmCyTDnI5NFOpet7gWGALadO+UmpcLKB/lwv1+ExQSVvsGe7eIhlhFtXMwhwZvWfY/yFF3FgoLzfrAsoF1rMQPi1XB273T1xazYqkStg574QXFMPItg/JIYN1FOWr+IbtSV3EYTWXx1C1zz168Yxkvnw3IHQlaKInnqw9WCq/406+5gzQAhd6BAc+QkDLwNBdojeUsBIKS8YBP1Iy22jbj4nihNVv03syflYX3+U6UtMkxA7ZPCpkSb1bQivbhLHuFcX8cfuIJg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(33716001)(5660300002)(9576002)(66946007)(86362001)(33656002)(66476007)(26005)(55016002)(8936002)(186003)(8676002)(9686003)(316002)(6496006)(54906003)(6666004)(52116002)(508600001)(38100700002)(83380400001)(4326008)(1076003)(44832011)(6916009)(66556008)(2906002)(38350700002)(956004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qyeqO0IXIBTFjRBBUXTmqaX0Uew1Y/ARcZBrvSkLikxtWSsO9gIPyJgq2K2l?=
 =?us-ascii?Q?76Aju5hX3Cy4tnaUtPJiz3xNqypBz8AMSt/QgoC0mKV4y7mb/mshmWHebtlt?=
 =?us-ascii?Q?GQOSu3GJLeKJ7l967hoa7wREmu8hOo+CgA5m0czve9vStdVlcgK88muYCak6?=
 =?us-ascii?Q?UYOTqB+PzPguIkOITLWJZv7FsklcsLl3t9qp1YaBkWiCXdAnbTk86bChcG9H?=
 =?us-ascii?Q?Qxbwvj1J4cHeX+m3uSrg8vDN2LUODehBTwRA7PJH57tU6v06otps5EMHrjBX?=
 =?us-ascii?Q?R2ZHGX6Cx4IV7jH2y+D1K1U1bexnhl39G8L+fNEDVq4XheakhZckQPV+2R4C?=
 =?us-ascii?Q?HVMQTm1bmS8m25y7Bu60bfe1eX5tGKzJoh4LNkryCk3HgkUHljtCocsvjGWZ?=
 =?us-ascii?Q?JYHHJYngaR8XnDDYkeDmjrtKzlqfV6VW6yot+NdauN45yXe1C7a0BrY0bwcZ?=
 =?us-ascii?Q?dENocWP39ph9+fxkiDXE6l3TGjh6BnLyBCScz1g6F+LlOVVZHrwuRGjL3G+z?=
 =?us-ascii?Q?1Zd+WR6rf59VB140bPMcMQELcBFN3vC5+Ki4KxA6kC9HpCq+f7lPPvZYFC9g?=
 =?us-ascii?Q?UClPtmO+eINl8cidH6+cmCufWO/3Ne5z4l5ZeOyu9bExCFrwH6EVuDgXFHwH?=
 =?us-ascii?Q?sc31zYovz2zMYFL1S4/JJRd8ya6kikF8h4qZP9y50mqVmXRi524xIZBcyWwZ?=
 =?us-ascii?Q?y195ecyKH7MQz02cRs3sawfqTABEEeRvAQV5Mzbn0sLLB28VQdARsJ9BnfbX?=
 =?us-ascii?Q?vNBOWI3o6bOk0PW7h2VC2kJXP8HVzzxtEnnN1fzPkPf88svjGgcXKs+QQSoJ?=
 =?us-ascii?Q?2AdeyDkSHnMNA9pGqjDH9DmLdNZGbxYMToC7/ODRGVxSokyeis76jZwZHlPJ?=
 =?us-ascii?Q?jsuZtXZgec+QFjIQjN6SMHnQqB6cxs+F6rpIcPSivmlXYNZvjPkhtbvukwMy?=
 =?us-ascii?Q?C7E0+TAZUvdcMhuZjrjTdOGN/I9lb+o9sk2e9QMkOpgWo82CAh9gRqnxmaJ/?=
 =?us-ascii?Q?6JvxS8KTx8NlPyEFUXd/UOIdPBGxYGigg3fdLQR/Cq2ZM3Mq3UoxdbnrOGzU?=
 =?us-ascii?Q?2JfpOxY89P3OLK7ylncmIBpbL9q5/Qi6f2hLtxQqz+gvFuv29nkxeI7pCFSf?=
 =?us-ascii?Q?fMGVrLwiWWqFjPIM3vJG3fZ2HcurP6gjOux4d6kkWeEvwBGIOxONu8baWdG+?=
 =?us-ascii?Q?2SnlR9nYQtXIXC7CAOnlAOa1WDZiM4ksVumxdstl2cyG4spzisbYdgu4t66F?=
 =?us-ascii?Q?8egJUgojJQp7TRHsQ3CQP/ds4lkAyJv4soS7ssUMWLpN1bRXy0QJlaJ9b/40?=
 =?us-ascii?Q?pRZ8wErQ4j0sbu2Sq80qCh6s?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52cb9f3d-9e3a-4dc8-c8dc-08d9500d0f92
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2021 08:12:08.0407
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AawfJ+axNDlrAXHbxgF6S+LpkjVcfSC/3un5nsP1JYz3l2eJl39+wutg0ubo7dEG1SHhd+2cd9uSCoguOlk9JmUfTHI3igp0/XD7Hwd4VJs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1295
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10056 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 bulkscore=0
 malwarescore=0 adultscore=0 phishscore=0 mlxscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2107260048
X-Proofpoint-GUID: D5fkhmWAS1ULxRe2F_RrVXxHXlMXhflP
X-Proofpoint-ORIG-GUID: D5fkhmWAS1ULxRe2F_RrVXxHXlMXhflP
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 23, 2021 at 05:15:10PM +0200, Len Baker wrote:
> Hi,
> 
> On Wed, Jul 21, 2021 at 11:06:24AM +0300, Dan Carpenter wrote:
> > On Mon, Jul 19, 2021 at 03:24:38PM +0000, David Laight wrote:
> > > From: Dan Carpenter
> > > > Sent: 19 July 2021 06:38
> > > ...
> > > > Not related to your patch but this code is bad.  What it does is the
> > > > "ifname" can be set as a module parameter.  So instead of testing if it
> > > > has been set, it uses the checking inside dev_alloc_name() to see if we
> > > > can allocate what the user requested.  If not then set it to "wlan%d".
> > > > If we cannot allocate what the user wants then we should return an
> > > > error.
> > > >
> > > > It should do:
> > > >
> > > > 	if (ifname[0] == '\0')
> > > > 		strscpy(ifname, "wlan%d", sizeof(ifname));
> > > >
> > > > 	ret = dev_alloc_name(pnetdev, ifname);
> > > > 	if (ret < 0) {
> > > > 		dev_err(pnetdev, "allocating device name failed.\n");
> > > > 		return NULL;
> > > > 	}
> > >
> > > I know only root can set module parameters, but having one
> > > that contains a string used as a printf format seems
> > > dangerous at best.
> > >
> > > Isn't it best to let userspace rename the interfaces later on?
> >
> > Yeah.  I think you're right.
> 
> Sorry, but I don't understand if the code needs to be improved or not.
> Is the code shown by Dan not correct?

We should remove the ifname[] array and the module option completely.

regards,
dan carpenter