Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3327344pxv;
        Mon, 26 Jul 2021 01:18:59 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJyZtnZ5tCVkqeCCoj4kWphIB68U/QOKEAaVK4TRV6EOHn7/paPFyaYdWhnsY4S/SqHkvC1v
X-Received: by 2002:a02:c8d0:: with SMTP id q16mr15481055jao.110.1627287539104;
        Mon, 26 Jul 2021 01:18:59 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1627287539; cv=none;
        d=google.com; s=arc-20160816;
        b=zRXFGVR/WfeYjkjNrHohGj/Q2UPfRt4hFC1SsGHcnONWXiySARhboMR0zU//zfakdG
         IuAOw0AMxxHcCA2I89BeRCVvZfPiTvarixhB9KHIZvKBDhgpUewitAYG+BdEyqYg4j5z
         2ogjeTIlPk8DbYR140BMWtZIEiSzoyBztGbgScYKLctJ4OAyKDAf0q+nhee5CkEAuLag
         rW/kQ6VpCU2I6LyWzzx1Pf6oTMlPN0D4KPwjqQj4FGW9HWOimgEblVEO5cyb0+RGnaWl
         4jvq2KJ6VwkgOoHARtN+8fTVt513pefhLZ+NZICi5b00cCDofWvi7XaP+LHPJLGvQVKK
         WuCA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-transfer-encoding
         :content-disposition:mime-version:references:mail-followup-to
         :message-id:subject:cc:to:from:date;
        bh=eFFQOz2VP00pjZwEY9WHRwdJVB2dyoJPwNMAmGtjZN0=;
        b=QboGxg486Vbz1Byk8ux6NdlMzHIEPlGArXmsO33zMSt9HTFtaNEPQESurGJOpL26+o
         TXvn4QBwxdph9VRsH0H8Gpke1fV23WtbGpTB6uHYbi2SR16cTp7ppeeW7zz06IoddNpm
         UnzoCB1ewwUkdfcQGLL9Z2aw8h+Cdj51R9RKlczq7iaAzC7knhjxBnas8pwTuBHIKK79
         CeE5MG8ECdcUw1wfDdyeelPYSjvZKcvE47EM3js2rTAe9WbHbEcNqzw/unVVXKrS0rI/
         fgH3hyxmJAuoxY62WE26exBoKanI7o4upTgdVFyRd4BqS+GOyX7ds9lGWYvIlPl4bQqJ
         6mpA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id p13si42602074jak.113.2021.07.26.01.18.47;
        Mon, 26 Jul 2021 01:18:59 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232207AbhGZHhF (ORCPT <rfc822;linux.sihyeon@gmail.com>
        + 99 others); Mon, 26 Jul 2021 03:37:05 -0400
Received: from out4436.biz.mail.alibaba.com ([47.88.44.36]:19119 "EHLO
        out4436.biz.mail.alibaba.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S231707AbhGZHhE (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 26 Jul 2021 03:37:04 -0400
X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=alimailimapcm10staff010182156082;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0Uh-wICr_1627287439;
Received: from B-P7TQMD6M-0146.local(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0Uh-wICr_1627287439)
          by smtp.aliyun-inc.com(127.0.0.1);
          Mon, 26 Jul 2021 16:17:21 +0800
Date:   Mon, 26 Jul 2021 16:17:19 +0800
From:   Gao Xiang <hsiangkao@linux.alibaba.com>
To:     Andreas =?utf-8?Q?Gr=C3=BCnbacher?= 
        <andreas.gruenbacher@gmail.com>
Cc:     Andreas Gruenbacher <agruenba@redhat.com>,
        Christoph Hellwig <hch@lst.de>,
        "Darrick J . Wong" <djwong@kernel.org>,
        Matthew Wilcox <willy@infradead.org>,
        Huang Jianan <huangjianan@oppo.com>,
        linux-erofs@lists.ozlabs.org,
        Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7] iomap: make inline data support more flexible
Message-ID: <YP5vj0c56iMLoDfS@B-P7TQMD6M-0146.local>
Mail-Followup-To: Andreas =?utf-8?Q?Gr=C3=BCnbacher?= <andreas.gruenbacher@gmail.com>,
        Andreas Gruenbacher <agruenba@redhat.com>,
        Christoph Hellwig <hch@lst.de>,
        "Darrick J . Wong" <djwong@kernel.org>,
        Matthew Wilcox <willy@infradead.org>,
        Huang Jianan <huangjianan@oppo.com>, linux-erofs@lists.ozlabs.org,
        Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <CAHpGcMJBhWcwteLDSBU3hgwq1tk_+LqogM1ZM=Fv8U0VtY5hMg@mail.gmail.com>
 <20210723174131.180813-1-hsiangkao@linux.alibaba.com>
 <20210725221639.426565-1-agruenba@redhat.com>
 <YP4zUvnBCAb86Mny@B-P7TQMD6M-0146.local>
 <CAHpGcMKZP8b3TbRv3D-pcrE_iDU5TKUFHst9emuQmRPntFSArA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAHpGcMKZP8b3TbRv3D-pcrE_iDU5TKUFHst9emuQmRPntFSArA@mail.gmail.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 26, 2021 at 10:08:06AM +0200, Andreas Grünbacher wrote:
> Am Mo., 26. Juli 2021 um 06:00 Uhr schrieb Gao Xiang

...

> >
> > iomap_inline_buf() was suggested by Darrick. From my point of view,
> > I think it's better since it's a part of iomap->inline_data due to
> > pos involved.
> 
> I find iomap_inline_buf a bit more confusing because it's not
> immediately obvious that "buf" == "data".
> 
> I'll send an updated version.

Okay, thank you very much!

Thanks,
Gao Xiang

> 
> Thanks,
> Andreas