Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3333946pxv; Mon, 26 Jul 2021 01:32:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxgoNdH/4aqwzH6Q0gH5KptHaLzF1ayiwOJnm863YLa1XmhX4mG7PkBMGfMZAF3128hkdP/ X-Received: by 2002:a50:ab1c:: with SMTP id s28mr12229901edc.214.1627288363574; Mon, 26 Jul 2021 01:32:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627288363; cv=none; d=google.com; s=arc-20160816; b=kKbs5ezRT4br9UAFX0CULOxLY4WQ+5rYJ0ddjY8LYgVYhlDXlFZERqqfE72EYiUEAw Lx8LhYw1dE0dcRIEno2iL4ReffngMqMNrUYNx+tXZAADlebVuL+6iskg1A7CdtZQA6Ve 4OHYs0eIO0RSuV74uCo51ONIxAwaYyYJ++ylAx1xR7t7wENuQs0eB7cTv7VOE/5Al/sP PwqG6apTIIouZ4tDU9x/ohOhIMAqG9BB+YKmnhzMFIbXqCAlhpwTEjFYcLek+95BTohq oHQSGZHstpefeSaTHuaFIfbWM5rWodsuB+ZYqmEplOsGJm1yHHTtvmwpKv2aHQB5R4GL dEiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=og+bidfOSF+rfgfwpGAPeKkDMGx6nFCXGRzTCDjNzP4=; b=QB1ujw70QkJIA9xCAKZ+TN+SzAZ1MHx1EEt4c0WZvbPxx31cGOtia7Et2LLSV5UxZN I8YDdlJ7SRgngLcOX0+zVJooGYDNuvtu/+vzsb7TUjWgK4gyh9fSpGwNvInxfwauhbN0 LAh3YjPsFHz6lglypnNoq0yiMttd4heZareQb3lIhOp7uI1avSw2Sya7MsptlB0CgZsp kese7MVPdQE87aoHEW4VcSqus8EfxLNSweNp6BIzHWOSzHIRRJdHYF2ch+G+UHOmkV3q z9OmpJgc1U5361ySyFQXPyZ0U9Rtd+cKRT4NAsALZ13EIZRmD1EJmSjjsVyxB1A21DO2 xSBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gx24si6387082ejc.66.2021.07.26.01.32.21; Mon, 26 Jul 2021 01:32:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231993AbhGZHsd (ORCPT + 99 others); Mon, 26 Jul 2021 03:48:33 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:3483 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231820AbhGZHsc (ORCPT ); Mon, 26 Jul 2021 03:48:32 -0400 Received: from fraeml702-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4GYCX92LzZz6DHYL; Mon, 26 Jul 2021 16:19:53 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml702-chm.china.huawei.com (10.206.15.51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 26 Jul 2021 10:29:00 +0200 Received: from [10.47.94.42] (10.47.94.42) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 26 Jul 2021 09:28:59 +0100 Subject: Re: [PATCH 13/23] iommu/dma: Remove redundant "!dev" checks To: Robin Murphy , , CC: , , , , , References: <4395626d7a4ba84ecce4ff8bc6d086795cebf0a6.1626888445.git.robin.murphy@arm.com> From: John Garry Message-ID: <94c66d4b-4458-b89f-def4-54b05c17bcaa@huawei.com> Date: Mon, 26 Jul 2021 09:28:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <4395626d7a4ba84ecce4ff8bc6d086795cebf0a6.1626888445.git.robin.murphy@arm.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.94.42] X-ClientProxiedBy: lhreml748-chm.china.huawei.com (10.201.108.198) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/07/2021 19:20, Robin Murphy wrote: > iommu_dma_init_domain() is now only called from iommu_setup_dma_ops(), > which has already assumed dev to be non-NULL. > > Signed-off-by: Robin Murphy FWIW, Reviewed-by: John Garry