Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933073AbWKWIAM (ORCPT ); Thu, 23 Nov 2006 03:00:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933078AbWKWIAM (ORCPT ); Thu, 23 Nov 2006 03:00:12 -0500 Received: from tomts22.bellnexxia.net ([209.226.175.184]:61897 "EHLO tomts22-srv.bellnexxia.net") by vger.kernel.org with ESMTP id S933073AbWKWIAK (ORCPT ); Thu, 23 Nov 2006 03:00:10 -0500 Date: Thu, 23 Nov 2006 03:00:09 -0500 From: Mathieu Desnoyers To: Greg KH Cc: ltt-dev@shafik.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/5] DebugFS : file/directory creation error handling, 2.6.18 Message-ID: <20061123080009.GD1703@Krystal> References: <20061120181838.GB7328@Krystal> <20061122052730.GD20836@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <20061122052730.GD20836@kroah.com> X-Editor: vi X-Info: http://krystal.dyndns.org:8080 X-Operating-System: Linux/2.4.32-grsec (i686) X-Uptime: 02:52:57 up 92 days, 5:00, 3 users, load average: 0.82, 0.40, 0.24 User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1130 Lines: 36 Fix error handling of file and directory creation in DebugFS. The error path should release the file system because no _remove will be called for this erroneous creation. Signed-off-by: Mathieu Desnoyers --- a/fs/debugfs/inode.c +++ b/fs/debugfs/inode.c @@ -198,13 +198,15 @@ pr_debug("debugfs: creating file '%s'\n",name); - error = simple_pin_fs(&debug_fs_type, &debugfs_mount, &debugfs_mount_count); + error = simple_pin_fs(&debug_fs_type, &debugfs_mount, + &debugfs_mount_count); if (error) goto exit; error = debugfs_create_by_name(name, mode, parent, &dentry); if (error) { dentry = NULL; + simple_release_fs(&debugfs_mount, &debugfs_mount_count); goto exit; } OpenPGP public key: http://krystal.dyndns.org:8080/key/compudj.gpg Key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/