Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210726050831.1917982-1-hsinyi@chromium.org>
In-Reply-To: <20210726050831.1917982-1-hsinyi@chromium.org>
From:   Enric Balletbo Serra <eballetbo@gmail.com>
Date:   Mon, 26 Jul 2021 11:32:05 +0200
Message-ID: <CAFqH_53zJp7ejwXn3qqiVPnoTy6W3WonvvDxsZDCjmaQA57h6A@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: mt8183: kukui: Use aliases to mmc nodes
To:     Hsin-Yi Wang <hsinyi@chromium.org>
Cc:     Matthias Brugger <matthias.bgg@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Eizan Miyamoto <eizan@chromium.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Hsin-Yi,

Thank you for the patch.

Missatge de Hsin-Yi Wang <hsinyi@chromium.org> del dia dl., 26 de jul.
2021 a les 7:08:
>
> Use aliases to mmc nodes so the partition name for eMMC and SD card will
> be consistent across boots.
>

This definitely helps with my "troubles" flashing the kernel to the
correct place" so

> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>

Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

Btw, I think that a similar patch should be send for Elm, could you
take care of it?

Thanks,
  Enric

> ---
>  arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> index ae549d55a94fc..ed499e17b6570 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> @@ -13,6 +13,8 @@
>  / {
>         aliases {
>                 serial0 = &uart0;
> +                mmc0 = &mmc0;
> +                mmc1 = &mmc1;
>         };
>
>         chosen {
> --
> 2.32.0.432.gabb21c7263-goog
>