Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Shai Malin <smalin@marvell.com>
To:     Jason Wang <wangborong@cdjrlc.com>
CC:     Ariel Elior <aelior@marvell.com>,
        GR-everest-linux-l2 <GR-everest-linux-l2@marvell.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] net: qed: remove unneeded return variables
Thread-Topic: [PATCH] net: qed: remove unneeded return variables
Thread-Index: AdeCGC9IfE4nt3qIS3m05qzRm1RMrA==
Date:   Mon, 26 Jul 2021 12:21:09 +0000
Message-ID: <SJ0PR18MB38825F95FA58CF72393D0951CCE89@SJ0PR18MB3882.namprd18.prod.outlook.com>
Accept-Language: he-IL, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DKTxck5Y7iF4fpftHtRCZ4embhTX/45inOBFYlYQnSQImhSiZqbex50vOZQj?=
 =?us-ascii?Q?TVzRt27W0fJmjrFq190KWyF0DBK60ZfGiNUkk4Ris8DQStx76ascueHG6mGr?=
 =?us-ascii?Q?599YVQor8L9FKOxxNIaqFYuWcYBQ0kSgV92IDGIKvWchLJjEKE474N6HUMGI?=
 =?us-ascii?Q?8G5OFkgPlYJVpPKtqAGLeF5ukLG7Kumu9XyFvQa+5kqFxuS+jqBIRk5wcYww?=
 =?us-ascii?Q?WDEg0fAwHiAkDTio5p62jwhF59+fZ/tT9RvRgXP0lvzQuHdwzIwboGhQdjgA?=
 =?us-ascii?Q?J7NcS1KcWFRsjNuhimDyQ3iqobIfuNu0xQ0TCABOBRIKmWQFd19sN1pGrfAb?=
 =?us-ascii?Q?kN4GliCSh67fmvkIlsL+WzbDrdkzEMj1N1tAfo5O8in3pf4CIUjxfZkQ15H6?=
 =?us-ascii?Q?ZOGj4+IApcGo8ODt+Se+Wqu/Muxy201ak9P7/lLVwKbAy/NV+/e8kdKZCjNb?=
 =?us-ascii?Q?/yrzxtu+WeYx5UkuQ0uDHN74L3qpHTOOCVhUpvoKGFzmS9v2ornvLrH9gtER?=
 =?us-ascii?Q?D1BTryOIEHc0J3Bee7eyHittXxwoNhZ6ZogKc982MRppNIuKjTNV1xLXSEZP?=
 =?us-ascii?Q?QA7CjolsJe8XFGj1MyOCCRVyDd91Ld9guLczAS5sD0wRnCdt9QL/BxhXMaN+?=
 =?us-ascii?Q?kAaAmuDL6MCmPeuM1xULJUnbGNFcFCN+qzvY/VOgbL27JvydgzP/h7nYimkN?=
 =?us-ascii?Q?niYFUUVAdJmLw435dcmpHEAfiREV6YjpHgZaILTOxaEIqIXS+l5jVkx7meRq?=
 =?us-ascii?Q?E1o0B5vQRbmHlDWnU9gAjLW9wDuCslmyOHpLlmeCwbPpdUHZVswAvbziE0wH?=
 =?us-ascii?Q?hm2nx3UaTHp4Mi9QcfylPK/KGukR1Ju42bAGn92LYeBKES8OVqnCitMbzaSP?=
 =?us-ascii?Q?pFgNSqErO44y0K6q/c2nm/RzrxjFIM518PIa2n4lP0HUwuzXZjvibwuBteyX?=
 =?us-ascii?Q?frWREDuOyfE8j5/B8FAsQms8mLuHdtY72WQ2QRFMd0+xypHSAQcQNQg9SOUc?=
 =?us-ascii?Q?qsvXdmYRtA4HX60o1tq7UCn85nGTJifQJMWQG695T1Y0RxSj1LDj0F8AszwQ?=
 =?us-ascii?Q?czFL209VDrOlSonYdS/pSdfOm+9IfkNosedp7qhvZ1wX+byUceyQ4r18+4jw?=
 =?us-ascii?Q?98mEOz92Bdzgbyps1ai7CJ8TnJussHpjrTarqQUSBNuWPjTpuGi4lzPYiY5w?=
 =?us-ascii?Q?gZ39cVcWO//Zj4EjbM7iuBSUsJ4psmj3+gblD3gO3VniQSQqgvK1u1Hpyriy?=
 =?us-ascii?Q?iqPONNTwDICmjhAbqtrJQkF+DyifKkOGWbWW6KLjGjUPm9HbP+AOrrtJyPMY?=
 =?us-ascii?Q?rBcd6DQRBbYvMQ1KmeFxltwv?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR18MB3882.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad312217-632b-4e8d-d799-08d9502fd9ca
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2021 12:21:09.6842
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wEDfrXEAWJpvbXU1TuuX58UopHBz99x/YxmhadEtor6mkH4n81qOpEdPx5xURaOARK49v71mNP7SOx4CpuLmkw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB3882
X-Proofpoint-ORIG-GUID: n2BfSMyVdPUrCWkBP7ouXTYRItRkcdDM
X-Proofpoint-GUID: n2BfSMyVdPUrCWkBP7ouXTYRItRkcdDM
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790
 definitions=2021-07-26_06:2021-07-26,2021-07-26 signatures=0
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sunday, July 25, 2021 6:14 PM, Jason Wang <wangborong@cdjrlc.com> wrote:
> Some return variables are never changed until function returned.
> These variables are unneeded for their functions. Therefore, the unneeded
> return variables can be removed safely by returning their initial values.
>=20
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
>  drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
> b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
> index e81dd34a3cac..dc93ddea8906 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
> @@ -741,7 +741,6 @@ static int
>  qed_dcbx_read_local_lldp_mib(struct qed_hwfn *p_hwfn, struct qed_ptt
> *p_ptt)  {
>  	struct qed_dcbx_mib_meta_data data;
> -	int rc =3D 0;
>=20
>  	memset(&data, 0, sizeof(data));
>  	data.addr =3D p_hwfn->mcp_info->port_addr + offsetof(struct
> public_port, @@ -750,7 +749,7 @@ qed_dcbx_read_local_lldp_mib(struct
> qed_hwfn *p_hwfn, struct qed_ptt *p_ptt)
>  	data.size =3D sizeof(struct lldp_config_params_s);
>  	qed_memcpy_from(p_hwfn, p_ptt, data.lldp_local, data.addr,
> data.size);
>=20
> -	return rc;
> +	return 0;
>  }
>=20
>  static int
> @@ -810,7 +809,6 @@ static int
>  qed_dcbx_read_local_mib(struct qed_hwfn *p_hwfn, struct qed_ptt
> *p_ptt)  {
>  	struct qed_dcbx_mib_meta_data data;
> -	int rc =3D 0;
>=20
>  	memset(&data, 0, sizeof(data));
>  	data.addr =3D p_hwfn->mcp_info->port_addr + @@ -819,7 +817,7 @@
> qed_dcbx_read_local_mib(struct qed_hwfn *p_hwfn, struct qed_ptt
> *p_ptt)
>  	data.size =3D sizeof(struct dcbx_local_params);
>  	qed_memcpy_from(p_hwfn, p_ptt, data.local_admin, data.addr,
> data.size);
>=20
> -	return rc;
> +	return 0;
>  }
>=20
>  static int qed_dcbx_read_mib(struct qed_hwfn *p_hwfn,
> --
> 2.32.0

Thanks!

Acked-by: Shai Malin <smalin@marvell.com>