Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3506431pxv; Mon, 26 Jul 2021 05:48:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxF+y++KnomRQHwKdtDN+ul7o0air5QtQAJolWgSK0wKUkpdri8wi+FQYS7uMqoTKbihLQh X-Received: by 2002:a17:906:ccc3:: with SMTP id ot3mr6511553ejb.515.1627303711198; Mon, 26 Jul 2021 05:48:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627303711; cv=none; d=google.com; s=arc-20160816; b=RXR0HRvDfoFLUh16Zj8O7s0CweKoAJzc9R4cGShtTqyy7ZTL0XPbBivLLYaVryUAR4 XpFmK+1zinq8NRTl+nLFENBOhGaO6U2cQpxrWJDd4D5RgBJaN9k32alD/rZTKyFtL1nF 80j8M4wJHkRY2BMxNlfj7dPwcgNCZSGn0ctp+huSWBdg/XKoxEScUV7QvPaiy7ocvuyZ ZAoS4e8S3xsqZLF1CL4+J6lU7irWDsHe2vONYwRVe5xrJIgPuDGrhjtIjS/0yYnj+iXW 8iGJqoyanTye2jO/worpq/LcIwdZrB6RcNTSEe4xpF/HzjJJTCNjLjj+dCNcpaD65967 WbnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=4i4y9TSxoxdhcjScVfT8qGxz3Hb3iJgt4QBY4JDjjxk=; b=F2mAzyfWl+LWNQK4mAqWeubOCgBjy2IB6zmSly+QIIrX6qwCLdIANS7yDxKxQExvWt vqdIF0mhhFu04NS9i4Kb1oGuB5G1N6k0uknd2rEMBib4aZNuVffrFNeWNV/bNYeiLuxE xKTJK8hF8eZwlqbgR7i1/fcIotvU0o3nxgSm53QghKX9SmltyPVaPRgn7FsGqGzGOs0m DK6qRg/ie/D6f2RD93rG/8h0nhuni5qYHU+jUdYribVn4OqLYIzFqGV61jzgrD3LxNfw RcrY2qMdFnnktyZnbJCjHcke1esfkpm7JmhNAiMzutQKwgTdHs8mCPBujovxoWHdfao6 MUXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lu2si31713490ejb.166.2021.07.26.05.48.08; Mon, 26 Jul 2021 05:48:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234039AbhGZMGK (ORCPT + 99 others); Mon, 26 Jul 2021 08:06:10 -0400 Received: from 8bytes.org ([81.169.241.247]:47200 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234136AbhGZMFm (ORCPT ); Mon, 26 Jul 2021 08:05:42 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id 8BF072B0; Mon, 26 Jul 2021 14:46:10 +0200 (CEST) Date: Mon, 26 Jul 2021 14:46:09 +0200 From: Joerg Roedel To: Robin Murphy Cc: will@kernel.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, suravee.suthikulpanit@amd.com, baolu.lu@linux.intel.com, john.garry@huawei.com, dianders@chromium.org Subject: Re: [PATCH 16/23] iommu/arm-smmu: Prepare for multiple DMA domain types Message-ID: References: <04220b3420c2c513490450f37de109182364f235.1626888445.git.robin.murphy@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <04220b3420c2c513490450f37de109182364f235.1626888445.git.robin.murphy@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 21, 2021 at 07:20:27PM +0100, Robin Murphy wrote: > - if (type == IOMMU_DOMAIN_DMA && using_legacy_binding) > + if ((type & __IOMMU_DOMAIN_DMA_API) && using_legacy_binding) Hmm, I wonder whether it is time to introduce helpers for these checks? Something like iommu_domain_is_dma() is more readable.