Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 26 Jul 2021 15:48:42 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Vineeth Pillai <viremana@linux.microsoft.com>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: arch/x86/kvm/svm/svm_onhyperv.h:73
 svm_hv_vmcb_dirty_nested_enlightenments() warn: variable dereferenced before
 check 'vmcb' (see line 65)
Message-ID: <202107262020.UobvBBnZ-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kadam (102.222.70.252) by JNAP275CA0033.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:4d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.24 via Frontend Transport; Mon, 26 Jul 2021 12:48:57 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f16956db-84f8-47d6-103e-08d95033bee9
X-MS-TrafficTypeDiagnostic: MWHPR1001MB2367:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MWHPR1001MB236791C31F0B39D37A8E948C8EE89@MWHPR1001MB2367.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:63;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Haf0CWJocWlJc8UBbTWRX8Bd+Zw33n2iKgA3LAgbc64srchBo8hBuwnkDmVZMZD1+zOlE225EohlFb+wVkqr2+nxHziU5xF/R08YapaoCQhi90piSA2HC2XNA/RsDgPabykMOwpdTxrfA/OF3L8d5KkCEvhExC5okkWFmdo36n2BkwpMA6eAGltTAUmCm4ZWq0yIpmHBGgLVRKxgitxsFgVyFlo1dqHSTLJK+NIA8bgi9znKRKNn1Ts6n3LPs9zkRc1yYSKshFMLcmNoNqm/euwn3uSLmSqXADetVvfQyXrf+nYrbvWgu4ygxDziGS4viwdIse6i1h39AajTlZZ1QeZU3VaSooe6G+HyifCYwjYfLhgP1gjyqoqW2/laUKFthwexe48NhdoVGkX0yQ+pIvoLhGD9eAaYYNWMCqqMbgnzURR4h6sZvrpQBcVofyZ3dndFJWCEALJt1Zr9SOG/8msFJSoDpWaeDaOJFTgBmu1PIzf5v5Et00izNfFOtq1VBLB8Me1LNcKAzX2sBNNPYEngUHRXMKMjsfo8aUuvSafPek4C61esj8qThzM2Js2Dag1uYYH+AdecBYUA2qAP8M7iKTkh8FgJRYuSvkKLm4n0kOL5X0fSlq9y2lTYvfElRvTr5Kw0rIo8Vju+PitM9FEDOrzCvH0FkuEYQLAGfpnUbFiMBIjmnKFJhyLcDZJjawHsiuPJKRrpkdLefN0/h2dvkYHypEPkzZ9X0tMLMLdA4IaqpCFIkpsY3aoad4KPRPoEUgiB5motyFomurPOXi90pCYhcMM8gWVvcrE3IEHorIwXsUj0JOSjyF0yLdgMk+xSlQs159kyhrF7lEoVrlBJpH3hyFMs/Ak8MmKT8kg=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(366004)(346002)(376002)(39860400002)(396003)(966005)(2906002)(66946007)(956004)(478600001)(316002)(5660300002)(6486002)(9686003)(1076003)(83380400001)(186003)(6916009)(4326008)(6666004)(86362001)(44832011)(26005)(52116002)(66556008)(38100700002)(36756003)(38350700002)(8936002)(66476007)(8676002)(6496006)(14143004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tfQWikdg724qPRzU80C2SgNBRxl8MeexvACfL896/OJHE3SIR6eNJWhEO7g6?=
 =?us-ascii?Q?0a6YlpJkeOIiMxjHLS89Ogsn+eO91eM76rXXuaxLic2LT2+z+kMMyQGQeBRi?=
 =?us-ascii?Q?WsYgtxhx1t+ais+e+3tG68KHvth38/8td9aiDdsatn+rFcK0Xx852h4R7leC?=
 =?us-ascii?Q?H/O/hH75c63O3GLKNnQsXZlxWApR7MxGn4JGJIGsTNF5R5An5Do2cA307YhL?=
 =?us-ascii?Q?c0qRsAIqzRHVdyDWfWjlamVrVplBMub3fGji75f5Fudwwiah/tcZiijt8GM+?=
 =?us-ascii?Q?tqevP6Ov23WvzGq1i2/w5ox83jo/qBbTnhPc+WeIwRZk6eemTnSaR9QDGdyz?=
 =?us-ascii?Q?NixC9HCYuZgxj6fMPu5f3zhPdnGACBoDT5rrj3f8V+rBH2wrz+8xbPCD00pt?=
 =?us-ascii?Q?eegG3pzzekC6AsYFD6LnfvUsZj0Z5dDI+eYc67OfgXzUEvWg87mpN77+78PP?=
 =?us-ascii?Q?GwFvgmDizQgh9OLPBHwkkXBAJdg1u0WpY4tqRnTNtK7Ant0+q60dGKu+K3DB?=
 =?us-ascii?Q?7hk//kWS0zFQhf51HuJXw/RU0NmoKT0HhljoCSRm2fYurqwxFWvaVFf7VNse?=
 =?us-ascii?Q?Hagt9oWnDfRgpo/SxOm5JyVnoo6jmFKReIAJ6m6S0UnFkgQeccTtKtFLIY8q?=
 =?us-ascii?Q?dtoIqzp/Lbr5H4me8TQtH7ATsd9fEUhgt/1emvea9JWR/JDlmBfd45aHZfVQ?=
 =?us-ascii?Q?+6yXBJ0LNsrjRhvZVj1y6LWBzgQTKb/ptYUzAzD3Rpj3GzGU+GnEhmAex/ha?=
 =?us-ascii?Q?NW/wd9f6351v15L8zYL4IXEJAsmXaZovKB1QWc0eWdvjVIOnyek5BzC75qoj?=
 =?us-ascii?Q?pVRJ27QRW4ylVAtaQZCAt1FREs0IyjM/NqQGcYJNKzA5dtMXwCTF8Fj79f/o?=
 =?us-ascii?Q?Os9chMNxUoV51gW8CkGGn54koEisDZQA8HQPkpJQnjOOZm2LRKQGGkJHuNNJ?=
 =?us-ascii?Q?39rAaUhBrMkB9Ev7vejNCpQQurQDzmveT5ddAbFVlb3XLwgHd9bhxVihXcQd?=
 =?us-ascii?Q?fn+rxB+TeMigUuRRXnWe5XUtMEOecNFsx755GI3etY3latV2fYWCqXakHX3e?=
 =?us-ascii?Q?boTtt6aAi5K0m4WYHffSuG61lo+Jjv5L4trHb2wmhE6uKp/PVoQobRhuojA7?=
 =?us-ascii?Q?9a5YbcdAkLPx7xpTnUJvdo6JbjLlISNlfyaBeP8UvVfHlKUCtnbU23LEdp/b?=
 =?us-ascii?Q?PeaQ3C+9PpN7JCz6XGJRHUrhwlHgodm3tmz/xMgzdlltcbARXTW+j/9VNS9d?=
 =?us-ascii?Q?Ttm3d5sWctpEnIkGyfTw2ot5uilK6pguLtPt8Dkgx0eXjWVzMDqgPL+LWkDA?=
 =?us-ascii?Q?FEk0q821MI2XGk3P4TH5Zn2N?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f16956db-84f8-47d6-103e-08d95033bee9
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2021 12:49:03.0442
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XwfCf0eHlxg2/Vdp8Z0ky9k5pSDIBziknpyWepLh9rrN+EBVHZomCoRHcTp8aq93VzHvtlSWzCFmp8ka0iicsl5DEu+htGV5qW/9avPEAto=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2367
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10056 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 suspectscore=0
 adultscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2107260073
X-Proofpoint-GUID: jT2MaTOjlzsQGbSLVRchwMAlg5kouoDH
X-Proofpoint-ORIG-GUID: jT2MaTOjlzsQGbSLVRchwMAlg5kouoDH
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   ff1176468d368232b684f75e82563369208bc371
commit: c4327f15dfc7294b2abde0ea49b3e43eec3cca38 KVM: SVM: hyper-v: Enlightened MSR-Bitmap support
config: x86_64-randconfig-m001-20210726 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
arch/x86/kvm/svm/svm_onhyperv.h:73 svm_hv_vmcb_dirty_nested_enlightenments() warn: variable dereferenced before check 'vmcb' (see line 65)

vim +/vmcb +73 arch/x86/kvm/svm/svm_onhyperv.h

c4327f15dfc729 Vineeth Pillai 2021-06-03  60  static inline void svm_hv_vmcb_dirty_nested_enlightenments(
c4327f15dfc729 Vineeth Pillai 2021-06-03  61  		struct kvm_vcpu *vcpu)
c4327f15dfc729 Vineeth Pillai 2021-06-03  62  {
c4327f15dfc729 Vineeth Pillai 2021-06-03  63  	struct vmcb *vmcb = to_svm(vcpu)->vmcb;
c4327f15dfc729 Vineeth Pillai 2021-06-03  64  	struct hv_enlightenments *hve =
c4327f15dfc729 Vineeth Pillai 2021-06-03 @65  		(struct hv_enlightenments *)vmcb->control.reserved_sw;
                                                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^
Dereferenced

c4327f15dfc729 Vineeth Pillai 2021-06-03  66  
c4327f15dfc729 Vineeth Pillai 2021-06-03  67  	/*
c4327f15dfc729 Vineeth Pillai 2021-06-03  68  	 * vmcb can be NULL if called during early vcpu init.
c4327f15dfc729 Vineeth Pillai 2021-06-03  69  	 * And its okay not to mark vmcb dirty during vcpu init
c4327f15dfc729 Vineeth Pillai 2021-06-03  70  	 * as we mark it dirty unconditionally towards end of vcpu
c4327f15dfc729 Vineeth Pillai 2021-06-03  71  	 * init phase.
c4327f15dfc729 Vineeth Pillai 2021-06-03  72  	 */
c4327f15dfc729 Vineeth Pillai 2021-06-03 @73  	if (vmcb && vmcb_is_clean(vmcb, VMCB_HV_NESTED_ENLIGHTENMENTS) &&
                                                    ^^^^
Checked too late.

c4327f15dfc729 Vineeth Pillai 2021-06-03  74  	    hve->hv_enlightenments_control.msr_bitmap)
c4327f15dfc729 Vineeth Pillai 2021-06-03  75  		vmcb_mark_dirty(vmcb, VMCB_HV_NESTED_ENLIGHTENMENTS);
c4327f15dfc729 Vineeth Pillai 2021-06-03  76  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org