Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 26 Jul 2021 09:28:18 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Masami Hiramatsu <mhiramat@kernel.org>
Cc:     linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Tom Zanussi <zanussi@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH v2 2/2] tracing: Allow execnames to be passed as args
 for synthetic events
Message-ID: <20210726092818.7d94027d@oasis.local.home>
In-Reply-To: <20210725124502.54fa65251b5cd5b76fdf5f19@kernel.org>
References: <20210722142705.992001628@goodmis.org>
        <20210722142837.458596338@goodmis.org>
        <20210723011935.efb25bc4a23ebd567243ed0f@kernel.org>
        <20210722123234.636d5363@oasis.local.home>
        <20210723101133.3378369c618c53f2e71d3e4c@kernel.org>
        <20210722212438.5933e714@rorschach.local.home>
        <20210724193145.c63b44aa843e05ed9c0b4fdc@kernel.org>
        <20210725111830.2f424ae3978443241b6d4a2d@kernel.org>
        <20210725124502.54fa65251b5cd5b76fdf5f19@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sun, 25 Jul 2021 12:45:02 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> And with this change, hist trigger can correctly detect a string type in
> the operand in the expression and rejects it.
> 
> Thank you,
> 
> >From 5280d1efe4415a621cf69a1dc4861ab928b0ff1c Mon Sep 17 00:00:00 2001  
> From: Masami Hiramatsu <mhiramat@kernel.org>
> Date: Sun, 25 Jul 2021 12:34:00 +0900
> Subject: [PATCH] tracing: Reject string operand in the histogram expression
> 
> Since the string type can not be the target of the addition / subtraction
> operation, it must be rejected. Without this fix, the string type silently
> converted to digits.

Masami, can you send this as a normal patch. My scripts do not work
(nor do I plan on having them ever do so) with patches embedded in
threads or non-patch emails.

Thanks,

-- Steve