Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 26 Jul 2021 14:44:56 +0100
Message-ID: <87lf5tdw9z.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Anup Patel <anup.patel@wdc.com>
Cc:     Palmer Dabbelt <palmer@dabbelt.com>,
        Palmer Dabbelt <palmerdabbelt@google.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Atish Patra <atish.patra@wdc.com>,
        Alistair Francis <Alistair.Francis@wdc.com>,
        Anup Patel <anup@brainfault.org>,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, Bin Meng <bmeng.cn@gmail.com>
Subject: Re: [RFC PATCH v2 02/11] RISC-V: Use common print prefix in smp.c
In-Reply-To: <20210618123851.1344518-3-anup.patel@wdc.com>
References: <20210618123851.1344518-1-anup.patel@wdc.com>
        <20210618123851.1344518-3-anup.patel@wdc.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 18 Jun 2021 13:38:42 +0100,
Anup Patel <anup.patel@wdc.com> wrote:
> 
> We add "#define pr_fmt()" in smp.c to use "riscv:" as common
> print prefix for all pr_xyz() statements in this file.
> 
> Signed-off-by: Anup Patel <anup.patel@wdc.com>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>  arch/riscv/kernel/smp.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/riscv/kernel/smp.c b/arch/riscv/kernel/smp.c
> index 547dc508f7d1..eea0c9d11d9f 100644
> --- a/arch/riscv/kernel/smp.c
> +++ b/arch/riscv/kernel/smp.c
> @@ -8,6 +8,7 @@
>   * Copyright (C) 2017 SiFive
>   */
>  
> +#define pr_fmt(fmt) "riscv: " fmt
>  #include <linux/cpu.h>
>  #include <linux/clockchips.h>
>  #include <linux/interrupt.h>
> @@ -114,7 +115,7 @@ static void send_ipi_mask(const struct cpumask *mask, enum ipi_message_type op)
>  	if (ipi_ops && ipi_ops->ipi_inject)
>  		ipi_ops->ipi_inject(mask);
>  	else
> -		pr_warn("SMP: IPI inject method not available\n");
> +		pr_warn("IPI inject method not available\n");
>  }
>  
>  static void send_ipi_single(int cpu, enum ipi_message_type op)
> @@ -126,7 +127,7 @@ static void send_ipi_single(int cpu, enum ipi_message_type op)
>  	if (ipi_ops && ipi_ops->ipi_inject)
>  		ipi_ops->ipi_inject(cpumask_of(cpu));
>  	else
> -		pr_warn("SMP: IPI inject method not available\n");
> +		pr_warn("IPI inject method not available\n");

"SMP:" made a lot more sense. I assume that the user knows that they
are using a RISC-V machine. On the other hand, seeing a "SMP:" prefix
for a message indicates the provenance of the message.

I honestly don't see the point in this change.

	M.

-- 
Without deviation from the norm, progress is not possible.