Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3600522pxv; Mon, 26 Jul 2021 07:40:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxgfi3Sw3t5xZpp7d+vY6hXvESmzRWJkNHag0DE1Kk8VtcIi7s/cL/CmKo9sfxuq+HRufJI X-Received: by 2002:a05:6638:240c:: with SMTP id z12mr16647794jat.41.1627310415695; Mon, 26 Jul 2021 07:40:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627310415; cv=none; d=google.com; s=arc-20160816; b=BLXWoVb4cGEXZuN6dsQa6UgF/QmlAgA+xjREfHt9rMxvlqA0aMuxUPsxTUli/kJdWc APlpOURP+JN77Fj3Telj4b7l5Ckwb2edX9Bh9F0Ztt0014AJpDGqY8JdPlhxSYUzsmFj 9/aFITPo/w+TKB4KLlYQVMm5xWa1Ea3sCnXysBAxWdySzLXX2Em2zSXSjesEkymXptYu zD9GBnenzAmPTxml6gNWkcHosZwNR+YrZL+E9V1WNjEQsk/eXWcoKEFEDJRMYg2plbvB mznjIRK1UQVAmZ6Iv+d/nCWVTsgA6WIB+5dC9g/3VjvdKQ0KCKsY8zjqTuvKlMahtG/n sbaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=kjP8XL3gAAQmLIUQhlu9GWo9RK6RrkKJjMyFl/c4u5E=; b=izSiQV28jmn9aMMsnVXn5BMgdxppVi+5Y47GFLXorX6rwlTWTvvUOAaPtI/gmUrWp8 fEZT8zqMi/2MPVtKMY5J3Vw5NkQ5CgqGvyHF0Vie4XUJNRyxElViZAHyi8gXIDm8kL7/ wD35MnrUfYt9BEYtu7Xg2feE7leXHHn+kz7cLf4sF2Nm5Nl2yq7WI46f49xaE3KrRTeG EczXu0ZXiD7yYKjpv5n6duD0+4dzdbX/DyAWyEfx914kIxpCuJLBpXRBrNZnzqkYVtc2 o18BonUZDRQE7MrwQWtvzyqm/1m7a7mcXWthNIheq6DYPIStscab09FRX/rMOHyzueEh EWvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=oigzRQ4u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f2si52255jat.114.2021.07.26.07.40.04; Mon, 26 Jul 2021 07:40:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=oigzRQ4u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234679AbhGZN5Z (ORCPT + 99 others); Mon, 26 Jul 2021 09:57:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233939AbhGZN5Y (ORCPT ); Mon, 26 Jul 2021 09:57:24 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A0DEC061757; Mon, 26 Jul 2021 07:37:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=kjP8XL3gAAQmLIUQhlu9GWo9RK6RrkKJjMyFl/c4u5E=; b=oigzRQ4uCRljWEwC0f1Bbt6rtY k+rE676s5UiKLt1KJfMy+YjKS01RfM9Kd4BjiaEeFtz+HYd9WL7VEeLf9t7QErqUG+V5s3TP7OlJF HQQhZDGigigMhVSThuxVel5Rag8s9taG+on9Gzf53LaJIOC1aQi7RFq0e5msbi1uitWwhSOKsg+5p bdFVoeLuPM331GQ3ew/fq16bPd6evK5Abrx8xGwFbLa1Vqq1rXw27iu+KBTQbvmrZ7gaSZnhWWLcI gpb08EQSQiiTcjqtuRSRYm9KxwVCoxEDcLU1mdAQBRtp1QqC29tpIdNRjOGC6MGZVqKcBDnUXqbvi 6FlcVRgA==; Received: from [2001:4bb8:184:87c5:ee29:e765:f641:52d7] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1m81ib-00E2d9-6k; Mon, 26 Jul 2021 14:36:54 +0000 From: Christoph Hellwig To: Kirti Wankhede , Alex Williamson , Jason Gunthorpe Cc: Cornelia Huck , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] vfio/mdev: don't warn if ->request is not set Date: Mon, 26 Jul 2021 16:35:24 +0200 Message-Id: <20210726143524.155779-3-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210726143524.155779-1-hch@lst.de> References: <20210726143524.155779-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Only a single driver actually sets the ->request method, so don't print a scary warning if it isn't. Signed-off-by: Christoph Hellwig --- drivers/vfio/mdev/mdev_core.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c index b16606ebafa1..b314101237fe 100644 --- a/drivers/vfio/mdev/mdev_core.c +++ b/drivers/vfio/mdev/mdev_core.c @@ -138,10 +138,6 @@ int mdev_register_device(struct device *dev, const struct mdev_parent_ops *ops) if (!dev) return -EINVAL; - /* Not mandatory, but its absence could be a problem */ - if (!ops->request) - dev_info(dev, "Driver cannot be asked to release device\n"); - mutex_lock(&parent_list_lock); /* Check for duplicate */ -- 2.30.2