Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 26 Jul 2021 11:04:34 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Jason Wang <wangborong@cdjrlc.com>
Cc:     mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: use WARN_ONCE
Message-ID: <20210726110434.4b9f976d@oasis.local.home>
In-Reply-To: <20210726110237.3c25dbc7@oasis.local.home>
References: <20210726135635.143285-1-wangborong@cdjrlc.com>
        <20210726110237.3c25dbc7@oasis.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 26 Jul 2021 11:02:37 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> > @@ -1574,9 +1574,8 @@ __init static int init_events(void)
> >  
> >  		ret = register_trace_event(event);
> >  		if (!ret) {
> > -			printk(KERN_WARNING "event %d failed to register\n",
> > -			       event->type);
> > -			WARN_ON_ONCE(1);
> > +			WARN_ONCE(1, "event %d failed to register\n",
> > +				  event->type);
> >  		}
> >  	}
> >    
> 
> If you're going to change this, then nuke the conditional!
> 
> 	WARN_ONCE(!ret, "event %d failed to register\n", event->type);

Oh, and if you are making these types of changes, you need to
understand them. The string passed to WARN does not need the "\n" like
the printk() does.

	WARN_ONCE(!ret, "event %d failed to register", event->type);

-- Steve