Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3652335pxv; Mon, 26 Jul 2021 08:46:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJws/tQ7JeyUaaYXza+kAbE5ZHpY1bvCwnTLcZ/UCGspZUuXqnHe8ubr5XhmSJMUcAR1xn0s X-Received: by 2002:a92:d412:: with SMTP id q18mr9204142ilm.77.1627314397935; Mon, 26 Jul 2021 08:46:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627314397; cv=none; d=google.com; s=arc-20160816; b=08acs1eesbChmmahfxnorzghTJUSl73ejG7H8x0QWPbWHLGtb/cSrfjrGD/zhhlP1Z 6/fuwgXBo9B4LJTshFzz7FbyV/QGbkkGmhkIUcypz77bBgHvkM5uFS3TwMcivdONHkvC TCx8RrvTE6hyhHqfKeqRwclPAcz4LLCWG8i8Sn0EgcjhxhmNfvhdlTycdsAH7MxyEvRd kLAa3EZzim+8rHa5KfhNQ3jFubVlRAdjKGFfskOXRaJajszLnMbDKXlFltwhaJ9X8AGX /oq0huyxtYuBlOi4mzdYSOXgs0TPLqiJT0Kz07EB1HUOt0D5s5mbWpUsKz66PE9Rx4kc XZEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fnMv+ywYTfTvknkIE1i9q+y48D198d0dlt2AgeUxA1A=; b=i2DUzCzHtybYR318yVfzmx0wooNAIvkfDCUZk09/NS8++G681p06dg8t6o1AhqC571 ZlKG0SahUzraq+u8nMnnQZGs4IuYGiKY8Ka8je29YC76sUqMDeHYujKm8xKvsKnox+BX nUE5eWx4S3cdPjY4mHvJtnb/1bnU4JVQOvmRWuEd6ZHSYMo5P87UNBc5DIyZVsrWnN2v 6yeFQvMaRs6U/+b1KkoEwyGk/3PN+7cZZEgnt67f2PJAXMm/YXEBrxIrbYaXc+U8iDFL s7kQsSYom0c3D9knu5UeZyfZBDEVroQCAhT29aSph6RqgdvynHulM7l0oz+wi6lr+ex9 gkXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=V9Y3f73Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s8si298862ilo.76.2021.07.26.08.46.19; Mon, 26 Jul 2021 08:46:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=V9Y3f73Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235877AbhGZPEC (ORCPT + 99 others); Mon, 26 Jul 2021 11:04:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:42440 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235318AbhGZPDG (ORCPT ); Mon, 26 Jul 2021 11:03:06 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 00A8E60F58; Mon, 26 Jul 2021 15:43:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627314215; bh=8FOEbG336hTjgxKsoz7MvY/FM6S8dsAGx4ebfi8ul0k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V9Y3f73ZnVS6InZ1OFkItBrU60Pcs55gkshIV4KWaP5LFnhsYIdICtTWEagsAAuf6 +WulyOoP/pvdYJISvQYIMFf6yeaT1n6/NLNvfXw2woDRgKxVtqm7PrVjsVcx/9VBeN 7YebmEe1XTqgeZFpSImCRlLnBcbMo/VeeCFOr54E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Sasha Neftin , Dvora Fuxbrumer , Tony Nguyen , Sasha Levin Subject: [PATCH 4.9 27/60] e1000e: Fix an error handling path in e1000_probe() Date: Mon, 26 Jul 2021 17:38:41 +0200 Message-Id: <20210726153825.723620687@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210726153824.868160836@linuxfoundation.org> References: <20210726153824.868160836@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit 4589075608420bc49fcef6e98279324bf2bb91ae ] If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it must be undone by a corresponding 'pci_disable_pcie_error_reporting()' call, as already done in the remove function. Fixes: 111b9dc5c981 ("e1000e: add aer support") Signed-off-by: Christophe JAILLET Acked-by: Sasha Neftin Tested-by: Dvora Fuxbrumer Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/e1000e/netdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index 46323019aa63..5d7967c03554 100644 --- a/drivers/net/ethernet/intel/e1000e/netdev.c +++ b/drivers/net/ethernet/intel/e1000e/netdev.c @@ -7375,6 +7375,7 @@ err_flashmap: err_ioremap: free_netdev(netdev); err_alloc_etherdev: + pci_disable_pcie_error_reporting(pdev); pci_release_mem_regions(pdev); err_pci_reg: err_dma: -- 2.30.2