Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3652801pxv; Mon, 26 Jul 2021 08:47:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJylH0FX0GhPuu8IgsuDGTt31HpMWsN2HLGKSvejA7swaOw9YIRWKpHWTfWSVIoDCVskkagy X-Received: by 2002:a05:6602:446:: with SMTP id e6mr15389127iov.85.1627314423962; Mon, 26 Jul 2021 08:47:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627314423; cv=none; d=google.com; s=arc-20160816; b=wENEgc5rLyGB5//WcxrDdNRIEY0dadK8E1GaWu+XDgzVjhKaUuWWBABDG3aqzRxnu4 YRiguefURiKwVXmK1z+Ppl0LHj43iKWdp+6vyAogXuTdmKlG4I7CeXOIDcIOSHaQRaLB pn0Udijn1mAXOKI+AU113ZKw2LfIy4oaPJDv3pgjp1dP6ioPsD40hxnmpULWMGFHmuvW IclTNTG7IXTvodubtBKcjoDlyjh9DnYmZLEH9sS8XOql69PJVh1dNFT1fOm4Yn4e6wHT qBJbzcP5L4MiietObpxbhyBsMqvw45J+ZOSA6prrNMq+GfPXm8jAoZp7pQnRa0Y0IriZ TH7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=xsrzj3MwkYn5toTYvR/aUwgwm/E8qPa6bTEJ+Csxzqg=; b=agVzIEmidNtx4gXuBLLmUiKIRF4EB8oJGj2dR7EZmiAJhnmm+KxwJMhBaazPNMEuyA T13c0jxw5HzDpmtmVMAHm5vprmDKj6fPanoJuf3P5H2KsOLos/aBOdBSLLwxznUhAtcD mOrHIANKLHQ87YFuEbubZeLKQwOkkyH55OmYf4+SBMZWRKfp//kaV8Kr0A6T1/NV6BrU 4kuo6yJsWil8wMC+XjLZ3IAH32iQ3SYbUc90vQk5Y2W45M8ssD+PAsR7pHORlCoktr85 xyLVJGBMgnDTUp0Wk/2ezArwBxS/LMKZUMjcdU8xelIJHXDom5k+uS/dV9MFI84HDuX9 a8bw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ud5qyvzg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d7si276040iop.31.2021.07.26.08.46.45; Mon, 26 Jul 2021 08:47:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ud5qyvzg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235221AbhGZPFg (ORCPT + 99 others); Mon, 26 Jul 2021 11:05:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:44940 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235871AbhGZPEk (ORCPT ); Mon, 26 Jul 2021 11:04:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 667A260FD8; Mon, 26 Jul 2021 15:45:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627314308; bh=FxfbMUKll3T40U36/zRLh5jDZFzW+wMrMIIo5DOULOQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ud5qyvzgRlRlDAjQo71QIMYea5Yn2P6T/XEcQILxCg9xeKCE1QE/1HM01ujot6fRr jBf67W6J05bsN964VFPeu//k4BUpgpRdUX8jTgK2v5SQ9S9Z+LMquxLuLGQKobEBcV u94tfo3OSpkr/Wp2IYHxG3WVWcIzS+enwSMJSaRg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Tony Brelinski , Tony Nguyen , Sasha Levin Subject: [PATCH 4.9 25/60] igb: Fix an error handling path in igb_probe() Date: Mon, 26 Jul 2021 17:38:39 +0200 Message-Id: <20210726153825.661043396@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210726153824.868160836@linuxfoundation.org> References: <20210726153824.868160836@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit fea03b1cebd653cd095f2e9a58cfe1c85661c363 ] If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it must be undone by a corresponding 'pci_disable_pcie_error_reporting()' call, as already done in the remove function. Fixes: 40a914fa72ab ("igb: Add support for pci-e Advanced Error Reporting") Signed-off-by: Christophe JAILLET Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/igb/igb_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index 9b7ef62ed8fb..38865e9bf934 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -2767,6 +2767,7 @@ err_sw_init: err_ioremap: free_netdev(netdev); err_alloc_etherdev: + pci_disable_pcie_error_reporting(pdev); pci_release_mem_regions(pdev); err_pci_reg: err_dma: -- 2.30.2