Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3657517pxv; Mon, 26 Jul 2021 08:52:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzutFLLKg7jrF8z7JVI21ax9NJFk8hWnCfPLh5gWyADIcUJ3RQgXwaLrAl9MJmtmrKCdCpL X-Received: by 2002:a05:6602:2f09:: with SMTP id q9mr15369787iow.196.1627314763190; Mon, 26 Jul 2021 08:52:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627314763; cv=none; d=google.com; s=arc-20160816; b=sUthii9pKBHAPJwdZmrBMeIB2rpEuQ/oGuhmVP9Q/it/O7vXWWM54ciy3KkyRgegwx 1o1Nt3IV1NXJ9aDhkGm0CLUcW4nSKVvzEW+mERlnCh+eZ+khxrSxQCkCih2VFXVgD3Iy jenX/tKVBFeeVnB+tKwSeGRJwLZqk36SOtcdUo7rkssvQ+52oxVWZJmSaJOGOsz536p+ FJXSpSo0GFbYhnSixf0Eyx4Q7dRch0PnRrXTRB2dptnmFH4ZdOOl/w44Lsx3Pc+w2qFw qJGSYEYt5wdoArPY+w+6dr8J9Z2EFG4aZvAq6Y9wzIKwoxyS8YC+WL/kkgDFlniyNZBw atAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=OKTZtr2g86fSxx64jSopYhcJXl77Fl09bAYz2KqeXhs=; b=cYY8vGzYZl3vvluE9Q80Fs3mzO+lyllc2RMQno1dKmokv+3cLOCpwA1FQ4aQVAmaoN zfYRjOnn2WMBt6vWeRSGIWYQ0vRPLm/DazzfAOAZ9LdbFkO31E6QRdgq6uUZBhWfu2GM 98fsrc6j631/aBY+5NbIVM6vBq0lknBD39idBZHcgc9x+ZTruJafGtmKFSX8212wHGBq f07vN4GTofbJELWaNQIk9w7QjshdonyxcG2XwPTaNOunSC2DmZeCa142FqRjltJ3j7Xn TWmKhiP5hwnxwx9hJHG6kxN/DRTFRpPykztGnPaE+AXVy+KqvtV11sAKFZxrbnz/vnS/ lf5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=i8A7pEoQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b20si257542jat.16.2021.07.26.08.52.31; Mon, 26 Jul 2021 08:52:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=i8A7pEoQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236253AbhGZPJH (ORCPT + 99 others); Mon, 26 Jul 2021 11:09:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:46876 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235954AbhGZPG1 (ORCPT ); Mon, 26 Jul 2021 11:06:27 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A350860525; Mon, 26 Jul 2021 15:46:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627314416; bh=EdYBp4p1yZyfdBa4uc+Lwfm7+ml94Pgo7M77LSZ8riI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i8A7pEoQgVkRyhVb4daYkAgu7fjlc6P8iRbdA7ot0LzJ1RPYyge4KF/03d/HapPUP huDEsC5+PRm6WlBNJ7UnAaZTJCMaNf12GAwAyreN/sIqpFZGGg7Z7UziF9G0O6yCzg LzBK3JIPprTBJQ9MEt0/E9x01dvybwFUogGDQN0E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Sasha Neftin , Dvora Fuxbrumer , Tony Nguyen , Sasha Levin Subject: [PATCH 4.14 39/82] e1000e: Fix an error handling path in e1000_probe() Date: Mon, 26 Jul 2021 17:38:39 +0200 Message-Id: <20210726153829.439836107@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210726153828.144714469@linuxfoundation.org> References: <20210726153828.144714469@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit 4589075608420bc49fcef6e98279324bf2bb91ae ] If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it must be undone by a corresponding 'pci_disable_pcie_error_reporting()' call, as already done in the remove function. Fixes: 111b9dc5c981 ("e1000e: add aer support") Signed-off-by: Christophe JAILLET Acked-by: Sasha Neftin Tested-by: Dvora Fuxbrumer Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/e1000e/netdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index f50d0da8fefe..116914de603e 100644 --- a/drivers/net/ethernet/intel/e1000e/netdev.c +++ b/drivers/net/ethernet/intel/e1000e/netdev.c @@ -7392,6 +7392,7 @@ err_flashmap: err_ioremap: free_netdev(netdev); err_alloc_etherdev: + pci_disable_pcie_error_reporting(pdev); pci_release_mem_regions(pdev); err_pci_reg: err_dma: -- 2.30.2