Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3657853pxv; Mon, 26 Jul 2021 08:53:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/nUP2SoDAXSN9jPNWw9XY/bQyJV5BtJ0vgKxk+WPzWQLSJMT0XyVO1buMrEqq3IePjWn6 X-Received: by 2002:a05:6402:686:: with SMTP id f6mr22092215edy.127.1627314783210; Mon, 26 Jul 2021 08:53:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627314783; cv=none; d=google.com; s=arc-20160816; b=J4BnXFvdACtwxo0oZQ7ONRk6MNXHBa551XnimTE9par0j5stGJmDngt5J+SAKQORQ1 5vSihVqJYf6dFlkJGJq0SKSWNlOfkcTRTtkJFCeAzuLQSclyUvS0MQUPxrKdCNtl0k1o vw0nSEaFV3fip27VsY+pkmbZ+cb5IQVSJ+88Rhd478qhpCL5imC3Xnd9a2ksvF+AUfef 2Lt5lo5F1DLWsV0NzGTxL+sGSfFQROrduR+IUdY4+5k17lYtsjNyaLAHk9LLBmlyKBc2 8mhLZp1zvhqMv1LkInNMoKvgjwfz+yVVNXptaeAuDz2wcHNASxulHqewtMcCsKoQ/bGn f/PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=GuGeallZsMoiyc6eiCif0gQfMhrkxyziPtMdNlemgCM=; b=zv3M8n3LcdhXzugIgwFiUzsUkMrfc5+oIBaLhWXQU2wFVZGNHV9920pg5qyK9cRw52 FpomO5nLkrZeR9JQtC2LCh4MTimCYHbX7/8R7lgnKghGzl/ZmvUkF5zDTcmONRfwgznP 1mxprD+Aw4ov55DlJ+azj6G7KXm/kqQ/xb8fWQEaAacNBTV8OYZ9z05E49gL71Q6XV6i 6neUGd/KtScpYVV9GOU/TR0Hfjk98JZe/cBeAXnWEOyoWWvHdVbN1hqGYp7mhnO4LI0U FkFAjN637E2PjHDzBIW0dN1cOddgbOhwwWBrLKpYK2ie3YdeG22NamtIVzwVwHpR8hI0 E8iQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jh8f77SL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w8si226846ejs.604.2021.07.26.08.52.39; Mon, 26 Jul 2021 08:53:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jh8f77SL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236122AbhGZPJF (ORCPT + 99 others); Mon, 26 Jul 2021 11:09:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:47386 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236200AbhGZPGZ (ORCPT ); Mon, 26 Jul 2021 11:06:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CFBCC60F38; Mon, 26 Jul 2021 15:46:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627314413; bh=qF3RSgAgV5eOLeri6FDdf+GlPmU++C/9+gKNZJL6N8g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jh8f77SLU6FU1hj6ujMdKVw2qkfxdsWasE8jlO/T5+FTt05slcQ3QGc9zo1dbkmzo RXvtlq/GQ4EuzCfa2faGOMu8cDa++y9L7p9xoUNeb+i0wyrKG4IP6xBikYYAbT1qY8 1vARSuV/dh7lmILXuGCjtXBYnbbpxfwydhEFtR3g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Tony Nguyen , Sasha Levin Subject: [PATCH 4.14 38/82] fm10k: Fix an error handling path in fm10k_probe() Date: Mon, 26 Jul 2021 17:38:38 +0200 Message-Id: <20210726153829.409682392@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210726153828.144714469@linuxfoundation.org> References: <20210726153828.144714469@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit e85e14d68f517ef12a5fb8123fff65526b35b6cd ] If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it must be undone by a corresponding 'pci_disable_pcie_error_reporting()' call, as already done in the remove function. Fixes: 19ae1b3fb99c ("fm10k: Add support for PCI power management and error handling") Signed-off-by: Christophe JAILLET Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c index 63784576ae8b..6b71fc19ab38 100644 --- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c +++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c @@ -2095,6 +2095,7 @@ err_sw_init: err_ioremap: free_netdev(netdev); err_alloc_netdev: + pci_disable_pcie_error_reporting(pdev); pci_release_mem_regions(pdev); err_pci_reg: err_dma: -- 2.30.2