Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933608AbWKWLHQ (ORCPT ); Thu, 23 Nov 2006 06:07:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933606AbWKWLHP (ORCPT ); Thu, 23 Nov 2006 06:07:15 -0500 Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:12001 "EHLO lxorguk.ukuu.org.uk") by vger.kernel.org with ESMTP id S933601AbWKWLHN (ORCPT ); Thu, 23 Nov 2006 06:07:13 -0500 Date: Thu, 23 Nov 2006 11:13:07 +0000 From: Alan To: Andrew Morton Cc: "Conke Hu" , Subject: Re: [PATCH] Add IDE mode support for SB600 SATA Message-ID: <20061123111307.3b249ce9@localhost.localdomain> In-Reply-To: <20061122182610.4d9f3d98.akpm@osdl.org> References: <20061122182610.4d9f3d98.akpm@osdl.org> X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1009 Lines: 26 On Wed, 22 Nov 2006 18:26:10 -0800 Andrew Morton wrote: > I doubt if it's appropriate to do all this via ifdefs. Users don't compile > their kernels - others compile them for the users. We need the one kernel > binary to support both modes. Possible? I'm not sure we do. What the Jmicron drivers do is - If SATA (libata) is enabled (module or built in) then turn on AHCI - If it is not enabled then support the chip fully in SFF mode via drivers/ide As the AHCI mode is fundamentally better (both with respect to standards and to performance) this makes sense. I think the SB600 should do the same - if support is in the kernel/modules - then turn on AHCI mode. If not then don't. No user options needed, no complex config questions. Alan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/