Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3667529pxv; Mon, 26 Jul 2021 09:03:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTZqbxQEtLDSNS44El1FQ2eYSuE0t5JxMOIjCHrOcHACtlPTYfAzPCebulc8bZy/dcTPXK X-Received: by 2002:a05:6402:289b:: with SMTP id eg27mr599457edb.90.1627315392719; Mon, 26 Jul 2021 09:03:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627315392; cv=none; d=google.com; s=arc-20160816; b=HBv/nSXcMMQnim02DokmVrzzOnOiyAHr8DTM/Ce4pDgl189opoSkCAzcMRdbk5vqX6 heucgVZ2CztvYm3jqEL7z7r4l+jOmhrSI/ZUyouvrovpAXy2EFdhKd/npDSExP1pQlfZ qWt7MAKtAMr53yLFbVzRrh8ep8x/7KJX0SMes6jr16zeRl+tX5N+p6T1ukyaXf3u7BCk s0Lzs86Gk4lk2SYBauWRKQ0DIQbbThKcqwoQhJwA0KP2n1hr9o6Xaq8B01XXsqoHEqsa cSARG89lo55pnsr9bnM+Tof32ps5BBw3iqdfroabPAUJsNfzJy05NljKtDk7btRQufKt hpgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=K1UGr1ri7HzB4yiWqd7cdjYnLT6C5JCBiijQKM+IE4Y=; b=pw4PtwLVFnDVdnLyE61dyTNCkqzsNZBtol/aNIGeRDiMK9PK8bsfhqyV4brNJ5PR3e rN6dUZ+CFsldmMc6NMfcBRfGVLgW76jmQSOB9a19/62F5EdmQvb2i6l8TE+fygi9nJa3 /gkJniDEKT0VRDmoWzZiq+ZhcKSMquFLwB3wC/6qHUjCnt6rGCVMsQM3tT+I8GNeH4Gc 1ZUMpOZqP3p/t4Mm0f/SOaTbhfpd+RQDoq9iOcXQtv4Ikar+AUflJYVzdmwo742onloB KaNiVVggd4y3oLzCRA4L+FeBMlEsz49pi42deU5fTbxIALYRcmNMSlt2iEx74M0ETooJ FPdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=s+z5ZWQM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b13si312696ede.583.2021.07.26.09.02.48; Mon, 26 Jul 2021 09:03:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=s+z5ZWQM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236665AbhGZPUw (ORCPT + 99 others); Mon, 26 Jul 2021 11:20:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:51434 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236283AbhGZPK4 (ORCPT ); Mon, 26 Jul 2021 11:10:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D468760F6B; Mon, 26 Jul 2021 15:51:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627314685; bh=S642GOUSQDHP+0gYjSGRBSz+QeyFaMu7P0/mIkeShFI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=s+z5ZWQMwHFj2KDkNEuv8uZWUhz9SxjCBwGOsGoN3Ea/sQYkQuuVWMrP4Z7vYuxJ8 I2fhQFpJvjyHXyPreBs4bsH5dElFfGWQbvqby6wZs6P3pLPCNGTshBvx+pVv/POTDe LRXLKhubHIKCaUqxmmCMYftnOG5A63rWcktQQPLo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Tony Brelinski , Tony Nguyen , Sasha Levin Subject: [PATCH 4.19 055/120] igb: Fix an error handling path in igb_probe() Date: Mon, 26 Jul 2021 17:38:27 +0200 Message-Id: <20210726153834.147412984@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210726153832.339431936@linuxfoundation.org> References: <20210726153832.339431936@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit fea03b1cebd653cd095f2e9a58cfe1c85661c363 ] If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it must be undone by a corresponding 'pci_disable_pcie_error_reporting()' call, as already done in the remove function. Fixes: 40a914fa72ab ("igb: Add support for pci-e Advanced Error Reporting") Signed-off-by: Christophe JAILLET Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/igb/igb_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index cee5baa6d646..8558d2e4ec18 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -3495,6 +3495,7 @@ err_sw_init: err_ioremap: free_netdev(netdev); err_alloc_etherdev: + pci_disable_pcie_error_reporting(pdev); pci_release_mem_regions(pdev); err_pci_reg: err_dma: -- 2.30.2