Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3667843pxv; Mon, 26 Jul 2021 09:03:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6MYeD8XwgFNPF9luQ3xUmQje22oKBYMNChX0lzDdxf7EjE53AITu2WXick0xn1sxBCBOE X-Received: by 2002:a05:6e02:198f:: with SMTP id g15mr14357770ilf.120.1627315411756; Mon, 26 Jul 2021 09:03:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627315411; cv=none; d=google.com; s=arc-20160816; b=OBiTnHKEnCifkyliCHOPnGeQvCsN08y0lNwtgE7nfE/S5TBn6i+snCCUPUajRUN+oq aVo+wRQtWQQpkUKF8i4PadFC2NAwcVe0uEThTEI2WA315wLbJ9JrHZMB8Z4dzS4a7EqZ zh4S4WPZ7FO3kB6VXovv4SM3HYVsLlXIJG3RRxTGGAHnwGKshrpRsm3h59ZF6l47PTA+ tGDwram8AhwYu5tftdjRf+735VUL9NIQccxcTs3YpVnyKPev4+gHvT0XBpyWKVgS0vV9 EhMF0ScleCzOxhcHO8fRB51YvkcXinys52MPgAJkqAWrYsq2g3cTwpbEFiiYXaYgonKF vpDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=RwlpnV+Htah9aSyQcrkahxQGfaI2Hn7IlzFnzYqZ/X8=; b=T3eD3YsPaPVR6rIeA2myJ+a7JFK8GAH1CYpVCOYEwSjOFzFobjIMa4z2p+vDae6+9t 2c7i0ZuBSS50ZSpbPqUQ37Bk7h5uPecS5bHVO9wH4Q7caIQtYInhOpGLZcxViT/H5tMR WmfGNMJHfQwmDfWv7lcALxmL6ZmGUIP4oRalb3Nvbd2+ATehEMrKVi8x+Q1moAT5s+O/ C/DslSBtLc1/Py2P/TP+5c3i6kNxVcmaRBR53NCU6ZkHXY1SvyclMhN8pGnYIsljgsH+ sOcziYGwJ52jNeTqn19QDP6naYWLs3bc5UlQuGHBM+zEscEnMpH9eXbGCbQ1NlOMrVtF OBcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kAYfeI+k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ay7si282437jab.36.2021.07.26.09.03.18; Mon, 26 Jul 2021 09:03:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kAYfeI+k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236582AbhGZPVr (ORCPT + 99 others); Mon, 26 Jul 2021 11:21:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:51686 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236360AbhGZPLF (ORCPT ); Mon, 26 Jul 2021 11:11:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 59F776056C; Mon, 26 Jul 2021 15:51:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627314693; bh=va88ssUqXsASXfCuORxhTvQJYOdmng6FTcfoFTz0ALY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kAYfeI+k1kBHnNXRnEvCol6jTJUAoU1ZY9vv5q5JbRSl+bHXAa7Cx+cAuXuzWPBnn jdj2v7tdujUfQdc1lHqtQj3v6NZFHvxP0PvMLBA3xr5LpzpiC4/IXc8PgWG9syfbv5 4iAB+uVA4dgQk0U1Jj3EoU/QmPgdJsRN77Ta7JSA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Sasha Neftin , Dvora Fuxbrumer , Tony Nguyen , Sasha Levin Subject: [PATCH 4.19 057/120] e1000e: Fix an error handling path in e1000_probe() Date: Mon, 26 Jul 2021 17:38:29 +0200 Message-Id: <20210726153834.210350335@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210726153832.339431936@linuxfoundation.org> References: <20210726153832.339431936@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit 4589075608420bc49fcef6e98279324bf2bb91ae ] If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it must be undone by a corresponding 'pci_disable_pcie_error_reporting()' call, as already done in the remove function. Fixes: 111b9dc5c981 ("e1000e: add aer support") Signed-off-by: Christophe JAILLET Acked-by: Sasha Neftin Tested-by: Dvora Fuxbrumer Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/e1000e/netdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index 6bbe7afdf30c..398f5951d11c 100644 --- a/drivers/net/ethernet/intel/e1000e/netdev.c +++ b/drivers/net/ethernet/intel/e1000e/netdev.c @@ -7369,6 +7369,7 @@ err_flashmap: err_ioremap: free_netdev(netdev); err_alloc_etherdev: + pci_disable_pcie_error_reporting(pdev); pci_release_mem_regions(pdev); err_pci_reg: err_dma: -- 2.30.2