Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3675450pxv; Mon, 26 Jul 2021 09:10:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx3KOjpX0tIvtAkl7/bJqSFGnMacWEYmh+hCSRForOquU3+tBB8LFptHUjNmHwo3GhFh2DS X-Received: by 2002:a17:906:c20d:: with SMTP id d13mr17134746ejz.259.1627315859727; Mon, 26 Jul 2021 09:10:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627315859; cv=none; d=google.com; s=arc-20160816; b=edbizMwdEFbjAObYEUKONxcpMO4sIMi3VtVTQq8vuFSQi5NzmupyKK3Sx53JNsUVyY CtfjoBS5e2HaNDRrtXVmtB4uFwyzHYIgI0VwRAPWkHcUaOvQeGxqg93jPDuLf6yNyydz rvravO6nZyTd51RNd7l83EtwC4j0uEhQdPrBkO5FnMZdwKT+UhjQaG3V6BVnvs4PjlV+ sW921nyR4286L+WIjWEZaHoVLLpvb4ljNQ4lHPiAiDfqrBqnX9+GX6Ma+3+5e//XPcS/ drpWvnu3FmlmcCM88Sr6OaBWIHIjbH5rPOnuA57QjVlx8YNP4NJj1m/U+kRewlk2ruCW M2cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=qofi8nVKzqtGKHBdDd5eaWuOCObMRoIwsOXD+s/cNfI=; b=eKAGneKTT5RWxZ2bVmPa4F5DQ/Q4jjExx8+VXQFAMMIVIgjC4b9louXaPQAdbyzl48 ZbQEe32wDf5xtdAy+Ipo4QUYPVZTY01HmZWwQd1WI8ljupO53ADNBTK9570D2ra/9Ksp q4CU+Az/UGLil4xHTub9w0x2/nCdAy51YJ/5bzCJfKekH1QTTLEnEtRJpe4OFRws8t+a ztd0p+OH2Gw/LaKHNzQ7VNf4WSOI+clkHk0mesFrrkeaPtNGPL4zomL5h8gsys4BPiYl qBtMqFCyOvY3pUh006LGnvAzzBvRlVs1bnCFZZQe1wS1pWoBkKSihuH6nBYfU/2Bo/xy TcfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=AM5TJxxI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y15si266013ejq.648.2021.07.26.09.10.36; Mon, 26 Jul 2021 09:10:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=AM5TJxxI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231965AbhGZP21 (ORCPT + 99 others); Mon, 26 Jul 2021 11:28:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:53092 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237447AbhGZPPr (ORCPT ); Mon, 26 Jul 2021 11:15:47 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 824B761055; Mon, 26 Jul 2021 15:55:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627314935; bh=+ZFnFNbTDxZttgrBK2QxYKJ6Q27AZetSXwT1gq8MNTw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AM5TJxxI6saBhsSbLjUEEd5Yt1YcH0CnZVfQ1LyYqPg0a6yzcLf5/QvlLIMRno9Qq sXPfNAUHPrCDJ7dNInXuIm3C1fuZiCSVvnfc1vrud93TOsNiLCadzi1ylVvekL1mPO t9ivAzyxHubsigJDmrsn0gvKWPRTmaXkEO9kg+IY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Dvora Fuxbrumer , Sasha Neftin , Tony Nguyen , Sasha Levin Subject: [PATCH 5.4 006/108] igc: Fix an error handling path in igc_probe() Date: Mon, 26 Jul 2021 17:38:07 +0200 Message-Id: <20210726153831.899462929@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210726153831.696295003@linuxfoundation.org> References: <20210726153831.696295003@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit c6bc9e5ce5d37cb3e6b552f41b92a193db1806ab ] If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it must be undone by a corresponding 'pci_disable_pcie_error_reporting()' call, as already done in the remove function. Fixes: c9a11c23ceb6 ("igc: Add netdev") Signed-off-by: Christophe JAILLET Tested-by: Dvora Fuxbrumer Acked-by: Sasha Neftin Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/igc/igc_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c index 606c1abafa7d..084cf4a4114a 100644 --- a/drivers/net/ethernet/intel/igc/igc_main.c +++ b/drivers/net/ethernet/intel/igc/igc_main.c @@ -4312,6 +4312,7 @@ err_sw_init: err_ioremap: free_netdev(netdev); err_alloc_etherdev: + pci_disable_pcie_error_reporting(pdev); pci_release_mem_regions(pdev); err_pci_reg: err_dma: -- 2.30.2