Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3675501pxv; Mon, 26 Jul 2021 09:11:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwoxg7LrNQUsaGAcCGZAtPQ323Yi2tUKH/Mdf+0fmSU93VZUvesVqF94ZkZx6QAmB5WgxAh X-Received: by 2002:a17:906:3616:: with SMTP id q22mr17263092ejb.276.1627315862852; Mon, 26 Jul 2021 09:11:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627315862; cv=none; d=google.com; s=arc-20160816; b=JDPL/skB18CXAzZ0K2pzu+pUJZ3jpx7qHiNWfP8yxn3xLmrgTWnmFRUf0VRusipjYC Ik0RIvDA1g7VwKn9z+h/z6SgbcAMOPDsXnwgyZ6B6pyBj806EBMvrxHJumwNLqUwG+oD NMv1ftyRonjE+nAGtd4BMxBJ81fQJVbP5BvHg6oPV/MfsMCrD1t3UykvL1h2kpHB4mCv RJl9LIcgRRV32igFeB7YyuppqedqzOqAUvUpohTtEhZgNLKOAt1XrFRBM6Fnba8p/Ug6 Q5WnOvbw/VKZx7k2ED51fAkNX71djpvYUNLMyiB1n1QgyQddOuSB9kQx5YqVVKu0M0rR 1WTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ie+chp5kiYF4o7FEneWOHRM+MizC/y7WGnRqxHVylyo=; b=vk8EY7zIHdVhgPjmJL/gVzkYs/kOUe+M+0RsImGEatoLDjll839YqJRsl56gjHWnOv zagt6C2GTP4U3D5uKDcj4LGKnNHbViSv4Ao48A42oeO2fUe0KYfCwl1i/YUqeX3M98jx rLm+u9kyYOrpv/pQUlddlPGtTlGJA3y7XEMh6sarpao2QM8Q8Qkqk0679qZ7xF/bOJG6 46OfPQFJ21fA8hAwc7wiRXjtsZUSpEzXbFTGy0GiDzybUVaujx0wPL7ZvCJxgxhHwUPA X579ArClVf4wouA4NevV87G/cJgbC0sCE9MfBwsq4/QKxdnfwxHelFztXs37RGrImC2c 602g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ytBZ9xG6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o7si334439edv.68.2021.07.26.09.10.39; Mon, 26 Jul 2021 09:11:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ytBZ9xG6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237392AbhGZPZw (ORCPT + 99 others); Mon, 26 Jul 2021 11:25:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:54248 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237466AbhGZPPs (ORCPT ); Mon, 26 Jul 2021 11:15:48 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7E38461077; Mon, 26 Jul 2021 15:55:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627314943; bh=6y2giFEi69soitKtND13kd62X5CanCJNiRrvK2huYx0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ytBZ9xG6wz4ix5xR0dXLRDgd5JoMTnBJSGwX3Gv8rV8nwNMHJA6rI60ZIrU4WRgkU BhSKosW0u0McSkGmY/ImaAKjqSzsAQqIr7RV9mTaxMXPp2/n46s6r6HYqHD4ptMuww 3PaDIezRc4jo1Vpks2+iHwxQub7yqsTPVolmCX68= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Sasha Neftin , Dvora Fuxbrumer , Tony Nguyen , Sasha Levin Subject: [PATCH 5.4 009/108] e1000e: Fix an error handling path in e1000_probe() Date: Mon, 26 Jul 2021 17:38:10 +0200 Message-Id: <20210726153832.002863885@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210726153831.696295003@linuxfoundation.org> References: <20210726153831.696295003@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit 4589075608420bc49fcef6e98279324bf2bb91ae ] If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it must be undone by a corresponding 'pci_disable_pcie_error_reporting()' call, as already done in the remove function. Fixes: 111b9dc5c981 ("e1000e: add aer support") Signed-off-by: Christophe JAILLET Acked-by: Sasha Neftin Tested-by: Dvora Fuxbrumer Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/e1000e/netdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index a06d514215ed..cbd83bb5c1ac 100644 --- a/drivers/net/ethernet/intel/e1000e/netdev.c +++ b/drivers/net/ethernet/intel/e1000e/netdev.c @@ -7401,6 +7401,7 @@ err_flashmap: err_ioremap: free_netdev(netdev); err_alloc_etherdev: + pci_disable_pcie_error_reporting(pdev); pci_release_mem_regions(pdev); err_pci_reg: err_dma: -- 2.30.2