Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210723220248.6554-1-s-anna@ti.com>
In-Reply-To: <20210723220248.6554-1-s-anna@ti.com>
From:   Mathieu Poirier <mathieu.poirier@linaro.org>
Date:   Mon, 26 Jul 2021 10:28:56 -0600
Message-ID: <CANLsYkw=+xJs3V8y89mSnUYo=8cHL_-U8UTC3gt6oO5zmS4jXA@mail.gmail.com>
Subject: Re: [PATCH v2 0/5] K3 R5F & DSP IPC-only mode support
To:     Suman Anna <s-anna@ti.com>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Lokesh Vutla <lokeshvutla@ti.com>,
        Praneeth Bajjuri <praneeth@ti.com>,
        Hari Nagalla <hnagalla@ti.com>,
        linux-remoteproc <linux-remoteproc@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Suman,

I have added your patchset to my review list.  Unfortunately due to an
impressive backlog and upcoming vacation won't be able provide
feedback for a few weeks.

Thanks,
Mathieu

On Fri, 23 Jul 2021 at 16:03, Suman Anna <s-anna@ti.com> wrote:
>
> Hi All,
>
> The following is a revised version of the series that adds the IPC-only
> mode support for the TI K3 R5F and DSP (C66x and C71x) remoteprocs
> covering AM65x, J721E, J7200 and AM64x SoCs. Patches are on top of
> 5.14-rc1 (the other dependent patches from v1 made it into 5.14-rc1).
>
> Please see the v1 cover-letter [1] for the design details of the
> 'IPC-only' mode functionality.
>
> The following are the main changes from v1, please see the individual
> patches for the exact deltas:
>  - The first patch in v1 "remoteproc: Introduce rproc_detach_device()
>    wrapper" is dropped
>  - Removed the addition of the rproc state flag 'detach_on_shutdown'
>    and the 'ipc-only' state flag in each of the remoteproc drivers
>  - IPC-only mode and remoteproc mode are supported by registering only
>    the appropriate rproc ops.
>
> The following is a summary of patches in v2:
>  - Patch 1 enhances the remoteproc core to restrict stop on early-booted
>    remoteprocs.
>  - Patches 2 and 4 refactor the mailbox request code out of start
>    in the K3 R5F and DSP remoteproc drivers for reuse in the new attach
>    callbacks.
>  - Patch 3 adds the IPC-only mode support for R5F.
>  - Patch 5 adds the IPC-only mode support for both K3 C66x and C71x
>    DSPs.
>
> I have re-verified the different combinations on J721E, J7200 and AM65x
> SoCs. AM64x currently lacks early-boot support, but the logic is ready
> for Single-CPU and Split modes that are specific to AM64x SoCs.
>
> regards
> Suman
>
> [1] https://patchwork.kernel.org/project/linux-remoteproc/cover/20210522000309.26134-1-s-anna@ti.com/
>
> Suman Anna (5):
>   remoteproc: Add support for detach-only during shutdown
>   remoteproc: k3-r5: Refactor mbox request code in start
>   remoteproc: k3-r5: Add support for IPC-only mode for all R5Fs
>   remoteproc: k3-dsp: Refactor mbox request code in start
>   remoteproc: k3-dsp: Add support for IPC-only mode for all K3 DSPs
>
>  drivers/remoteproc/remoteproc_cdev.c      |   7 +
>  drivers/remoteproc/remoteproc_core.c      |   5 +-
>  drivers/remoteproc/remoteproc_sysfs.c     |   6 +
>  drivers/remoteproc/ti_k3_dsp_remoteproc.c | 197 ++++++++++++----
>  drivers/remoteproc/ti_k3_r5_remoteproc.c  | 265 +++++++++++++++++++---
>  5 files changed, 407 insertions(+), 73 deletions(-)
>
> --
> 2.32.0
>