Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3711653pxv; Mon, 26 Jul 2021 10:00:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw6bW2ZhtbHp2lndHmNhMpkdiDcd8h1VrjFrkKIRNS7Pjpt+FMJwPNdAJwi1cGLAOU9eNzy X-Received: by 2002:a17:906:76cf:: with SMTP id q15mr17911178ejn.69.1627318849790; Mon, 26 Jul 2021 10:00:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627318849; cv=none; d=google.com; s=arc-20160816; b=ShZrvKaVXHGoQtKy6ewyv1gzn1i7omKj7LnBkkXg3PVyGiJM9+aRoVljC8GM+TDo6x vVa35PqtPBx5dg8N2aPHRInAhSm2oFx1WnVnVxHOWyjYeBFedaVfHAd/CsagD4CU+24T PWQx5Qpuez6tXZd2vD3Uw7DS6rGkpPoDc0iXZr3TeaZAvch+vqVUf475uDHr6voyy8b/ xLN8RujxaeyYd8zd6ugyGyhfkv2EjhY1klwc3I9Yi2lXMWzhEKoUunX57SOf7N8gS2oi iYv3a6Fq1wIIVoHbvjmhOqfV6vjsbaYiLyR0coFbuiFrD+8HbLEPJS5R02j5kselhTUA 9nUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=toGqw33omxlOycjYtcmfsiXZhiWqDCZvbkenqHWTdQU=; b=elGOxYGnsjdZeD43+Tt2yruxmwo8MOgne3qu74U7WcjzpL0o3pOB+GsWYMPhPqAv5N mqilKRN9BycSD+L+dYXMXFCb1PC2Vk2jPuiAl1MiWFHu+u2Hz+2xiPQN/btlhubcPfQw 27xXGqRHU8KADFJp2IwBwel49Vook1F5Hb8KKcBlkxmSVV2t3ns4oUIyl5RqupGmFNcR C1+swdK3mpkk1CMpT0j1lhAAI3+PMgGV1uumq+39ljAmDeQRka96URfaekjuUc+4f1Nw 8m/wVOF21V/99z+A33ztOCzMo/PV3VzXkz3+4EITVaNMOaDM6jDu8ueA1MNFaCaPzdyV Sqsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=lBzVbzi6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e12si370135ejk.703.2021.07.26.10.00.24; Mon, 26 Jul 2021 10:00:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=lBzVbzi6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233349AbhGZPgC (ORCPT + 99 others); Mon, 26 Jul 2021 11:36:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:34472 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237070AbhGZPUp (ORCPT ); Mon, 26 Jul 2021 11:20:45 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C16D660E09; Mon, 26 Jul 2021 16:01:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627315274; bh=ZXdgyVojRwM3kvgsPDy2GLVZdHB7bsthrgVCke4JF44=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lBzVbzi6t7b/DCGSk9m7Q86lyVeboDwq6VH3p9YVCt9FEsRcKHnx41yEWuq3zmd2Q WB72R/Dovd/P9xeBf4ICKz11s+wDnD+CC8PKh0zJwnhb2Hfu73ZCUrZ/RI12HivGzW jYIImNzYPuuIc9h46TEkYzNYfwoS6+p2gmS89BCY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Dvora Fuxbrumer , Sasha Neftin , Tony Nguyen , Sasha Levin Subject: [PATCH 5.10 005/167] igc: Fix an error handling path in igc_probe() Date: Mon, 26 Jul 2021 17:37:18 +0200 Message-Id: <20210726153839.549857334@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210726153839.371771838@linuxfoundation.org> References: <20210726153839.371771838@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit c6bc9e5ce5d37cb3e6b552f41b92a193db1806ab ] If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it must be undone by a corresponding 'pci_disable_pcie_error_reporting()' call, as already done in the remove function. Fixes: c9a11c23ceb6 ("igc: Add netdev") Signed-off-by: Christophe JAILLET Tested-by: Dvora Fuxbrumer Acked-by: Sasha Neftin Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/igc/igc_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c index 4b58dd97a7c0..b9fe2785f573 100644 --- a/drivers/net/ethernet/intel/igc/igc_main.c +++ b/drivers/net/ethernet/intel/igc/igc_main.c @@ -5223,6 +5223,7 @@ err_sw_init: err_ioremap: free_netdev(netdev); err_alloc_etherdev: + pci_disable_pcie_error_reporting(pdev); pci_release_mem_regions(pdev); err_pci_reg: err_dma: -- 2.30.2