Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3713770pxv; Mon, 26 Jul 2021 10:03:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwIQe+53l1+CPirZiwCS22Cp8ZBXNmaeRUT7r+DpND7m63k30psMhXnOpgQTX97ObLP0eF4 X-Received: by 2002:a05:6000:1c4:: with SMTP id t4mr20584046wrx.181.1627318997347; Mon, 26 Jul 2021 10:03:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627318997; cv=none; d=google.com; s=arc-20160816; b=QynOFfZbkmP1IGjOY/RiTOcsI4xePzZUDP+OuQdCdAUNiz8Opok+t4XSYO2vmwbCtp tXgcbwJPNrPa/7ZuQcSKhK426vLdIrDjmu3Da02xl/OAlii+acFnXCkAD+CLlTWToiEG l4m3UFPwtaO8B9x6WcnZrkXS4cfGdQEdLVj882OF4KMMUoLzV9OzQahKO7hkHvX0dV0z 5UvbUONQPaSJJcTuJ0fz8n/iSI6mbnXD0XgrVe2Arwrt1PMVN1GlxCx4a9mCFSYMT4Yl ZWr+35XRVT8AO9GYLIwQHfIsHBMtOtRCpq9GH71G2ELjP0HQzgh5Udha8crozTtzYsZv SaMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=cT98i/GXAKQ7a0XGVe4rHhLepPWlWQYyGzZO144Vg+M=; b=KdKWduex5jJNYE9N1GyQi9XoJuIF75Zg65LUNSWMQwGrzcMm47VTBx5/535krWSlcz OD6nX47qDzFSjjbBvJ2vnrfSST+BrlFoAPJbwAk8nm1B6jui+7ZzhDNk50wvgVPUDyim uJ2w5REHoFhRDQZlWnDJPAW4cEvFjIm6YksOVwzKTt3I/nceb79RIpYzukj522FG1AL/ HMpimzHvcrCHFpMTi7Jh9FpMe1telHiPnCvOGEmi5WJ2V/9OYF/53RlyxrbJC8XrLD5P Dg91Rie1dF7aalp96SQnNMRwSf97XOBzmxHSsWusDj0b2rHNlQxsgaetxBElYQr7Blfl aomA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Sn9vtzwQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e12si371229ejk.703.2021.07.26.10.02.51; Mon, 26 Jul 2021 10:03:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Sn9vtzwQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235004AbhGZPhr (ORCPT + 99 others); Mon, 26 Jul 2021 11:37:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:35992 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237209AbhGZPVn (ORCPT ); Mon, 26 Jul 2021 11:21:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EF2C660E09; Mon, 26 Jul 2021 16:02:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627315331; bh=q0VMxnM0zP+6GtCK0Os6yDk2JT9hLndLBpZYmsFvwXw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Sn9vtzwQyrooch5UAsg3pEf+g54nwcLXgrwl0R3aiw3GjiZ//6lti7mIAZ3PfTjv8 bn2vKh4ki1XHH6KXqOsVnnpR2cca1skTj6Nk8uHC9/lxZKDlPfo0QLn4tII1czueC4 KB1GH4gzo0gYXiSiA2ru3ED6MwtN52j7f+7PCaso= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Maxim Schwalm , Mark Brown , Sasha Levin Subject: [PATCH 5.10 054/167] ASoC: rt5631: Fix regcache sync errors on resume Date: Mon, 26 Jul 2021 17:38:07 +0200 Message-Id: <20210726153841.231051282@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210726153839.371771838@linuxfoundation.org> References: <20210726153839.371771838@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Maxim Schwalm [ Upstream commit c71f78a662611fe2c67f3155da19b0eff0f29762 ] The ALC5631 does not like multi-write accesses, avoid them. This fixes: rt5631 4-001a: Unable to sync registers 0x3a-0x3c. -121 errors on resume from suspend (and all registers after the registers in the error not being synced). Inspired by commit 2d30e9494f1e ("ASoC: rt5651: Fix regcache sync errors on resume") from Hans de Geode, which fixed the same errors on ALC5651. Signed-off-by: Maxim Schwalm Link: https://lore.kernel.org/r/20210712005011.28536-1-digetx@gmail.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/rt5631.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/rt5631.c b/sound/soc/codecs/rt5631.c index 653da3eaf355..86d58d0df057 100644 --- a/sound/soc/codecs/rt5631.c +++ b/sound/soc/codecs/rt5631.c @@ -1695,6 +1695,8 @@ static const struct regmap_config rt5631_regmap_config = { .reg_defaults = rt5631_reg, .num_reg_defaults = ARRAY_SIZE(rt5631_reg), .cache_type = REGCACHE_RBTREE, + .use_single_read = true, + .use_single_write = true, }; static int rt5631_i2c_probe(struct i2c_client *i2c, -- 2.30.2