Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3820479pxv; Mon, 26 Jul 2021 13:03:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwvW3wyyfWorz8vmyv0KTsji1G08wDdC8LMSfU1DV4/RdDFDcvN9nVUsSeEJ+pQyKIaOTTH X-Received: by 2002:a05:6602:342a:: with SMTP id n42mr15653111ioz.126.1627329808273; Mon, 26 Jul 2021 13:03:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627329808; cv=none; d=google.com; s=arc-20160816; b=QVBi+/PtwDvzKpwpmXVGugQaFsLjr+Z9fvP8SsClz9Oroz7FVjDp2DNbqtAXXba4Gp tPKNJGM9Wz2xvoxFfEcu2pj4WDIqsroPMZQfzjr6+l198WZiGBOVafy0mwVh/Qw3lBll 2TUxFjMCIYOrHlKwUrgKFviG4RQvOG7fgeitITlIdY0TQbOmQOmwpAb7rSjpvZTz+uTI 3gQJryKN8NO68mM42j98bHAJPG6+0ZcJ3ym7WmcVRd+6np1+jpFXYlLfsAeGVGFrzr56 WNdbFJO/8NWZhl6pF0Th22GiDg3oMFz18UuF8mdbT+zRONqDPOltWgpPPn6rX0NZBiyW afXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=Km/W0ilseYqx7Wq7BG+3uuk5kst53dT6SMsqc9VbbD4=; b=F0Lr+7jcxcm8G2s/DjFw9e4YlUnRZpVLuI2s9NLWM/r9IBLeDVu2/4Ed9I72bf1dtK lk1doasjOrXiZ4pI4I7aeLlVWsS27SUEyWcbqvWZLi1ngI7XqxZescXO0gzXQPsPOGz+ OBm+yuiNJo9muwgIotxorY0oGY37NUX2s/mHM+pY3yUIsyeBw29TsNGi5vE65GoTklt5 sz3NlkUw5x7iaZJdwBxkQAK9mqVcS/YKJ6yBPExHXYhuQOw8usPL+8JD8O4Whws6akDQ lq5BNuwfJI744IBZCR66vA0+oD8rmZFguCUIxpOkDjrr70B7if3JsoGtnZNZ5XhqbGT+ NjKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y11si1105407ilu.1.2021.07.26.13.03.16; Mon, 26 Jul 2021 13:03:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231598AbhGZTWB (ORCPT + 99 others); Mon, 26 Jul 2021 15:22:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229646AbhGZTWA (ORCPT ); Mon, 26 Jul 2021 15:22:00 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70451C061760 for ; Mon, 26 Jul 2021 13:02:27 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m86ns-0001co-NK; Mon, 26 Jul 2021 22:02:20 +0200 Received: from pengutronix.de (unknown [IPv6:2a03:f580:87bc:d400:bb61:39f9:30bb:99fb]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 8838E658759; Mon, 26 Jul 2021 20:02:16 +0000 (UTC) Date: Mon, 26 Jul 2021 22:02:15 +0200 From: Marc Kleine-Budde To: Pavel Skripkin Cc: wg@grandegger.com, davem@davemloft.net, socketcan@hartkopp.net, mailhol.vincent@wanadoo.fr, b.krumboeck@gmail.com, haas@ems-wuensche.com, Stefan.Maetje@esd.eu, matthias.fuchs@esd.eu, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] can: fix same memory leaks in can drivers Message-ID: <20210726200215.wnfwj27v2x2vyyup@pengutronix.de> References: <20210726202916.5945e3d9@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="63zbmxht67o6x4ka" Content-Disposition: inline In-Reply-To: <20210726202916.5945e3d9@gmail.com> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --63zbmxht67o6x4ka Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 26.07.2021 20:29:16, Pavel Skripkin wrote: > On Mon, 26 Jul 2021 18:29:38 +0300 > Pavel Skripkin wrote: >=20 > > Hi, Marc and can drivers maintainers/reviewers! > >=20 >=20 > I reread this I found out, that I missed logic here. >=20 > I mean: >=20 > > A long time ago syzbot reported memory leak in mcba_usb can > > driver[1]. It was using strange pattern for allocating coherent > > buffers, which was leading to memory leaks. >=20 > I fixed this wrong pattern in mcba_usb driver and Thanks for your patches! Please resend them with an updated description and the fixed patch 3. Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --63zbmxht67o6x4ka Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmD/FMQACgkQqclaivrt 76nrjQf/TTofghGBF24758Ocv4jTf+JAbhnZVQumdEB0CIG1gpEQdvfcHN0DOc+v e3Ex/uwhAZur2owZghqVFvM8LAbHEJOfZCcXSXMYWW5AdxeH5D2ML+RYlIpL5MP6 PcXETRwW5LBGMCp8zAVsn17HDRusciQ1llAY8yDzvaCaO5+7slIcKz8A+aOpItso zbLWgs1gtdkDUoJ3rIMhq+PLen2fQnDeSGVHa8TgdVs0eNR2TWCu0dOlyVPIk45V JST5J/gT6ME1AgjEO69bSoAx1DxDkYDdi6GC/BeomPk9nZS9+/VNOOlnxlQkZpaf A0tLby0E9O3bmB2zLYgZ9CYmk9t6Xw== =mdMZ -----END PGP SIGNATURE----- --63zbmxht67o6x4ka--