Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <cover.1627273794.git.viresh.kumar@linaro.org> <fced2f2b9dcf3f32f16866d7d104f46171316396.1627273794.git.viresh.kumar@linaro.org>
 <CAL_Jsq+XXhe2g0Rmda1v_Ws4-E_-UE6X5HUsSk-GcAETqQZiCQ@mail.gmail.com>
 <CAK8P3a3bCk+iA+YziQrQFg6xH_d9cyySdTN_1j94D9CA8a_Sjw@mail.gmail.com> <CAL_JsqLk8q6N2Sf43em57OXKkrQ7SW01GBnAEV1zzPMYQF7agA@mail.gmail.com>
In-Reply-To: <CAL_JsqLk8q6N2Sf43em57OXKkrQ7SW01GBnAEV1zzPMYQF7agA@mail.gmail.com>
From:   Arnd Bergmann <arnd@kernel.org>
Date:   Mon, 26 Jul 2021 23:20:13 +0200
Message-ID: <CAK8P3a3bnOYNC-wqzQr+iv9EWGUX7gQA1tC2pPDKqav_m5r4fQ@mail.gmail.com>
Subject: Re: [PATCH V3 1/5] dt-bindings: virtio: Add binding for virtio devices
To:     Rob Herring <robh+dt@kernel.org>
Cc:     Viresh Kumar <viresh.kumar@linaro.org>,
        Jason Wang <jasowang@redhat.com>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Bill Mills <bill.mills@linaro.org>,
        =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>,
        "Enrico Weigelt, metux IT consult" <info@metux.net>,
        Jie Deng <jie.deng@intel.com>,
        DTML <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" 
        <virtualization@lists.linux-foundation.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jul 26, 2021 at 10:37 PM Rob Herring <robh+dt@kernel.org> wrote:
>
> On Mon, Jul 26, 2021 at 9:54 AM Arnd Bergmann <arnd@kernel.org> wrote:
> >
> > On Mon, Jul 26, 2021 at 4:57 PM Rob Herring <robh+dt@kernel.org> wrote:
> > > On Sun, Jul 25, 2021 at 10:52 PM Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > > > +    description: |
> > > > +      Exactly one node describing the virtio device. The name of the node isn't
> > > > +      significant but its phandle can be used to by a user of the virtio device.
> > > > +
> > > > +  compatible:
> > > > +    pattern: "^virtio,[0-9a-f]+$"
> > >
> > > DID is only 4 chars? If so, "^virtio,[0-9a-f]{1,4}$"
> >
> > Any opinion on whether this should have any namespace prefix (or infix, I guess)
> > after "virtio,"?
> >
> > I previously suggested making it "virtio,device[0-9a-f]{1,4}$", which would
> > make it clearer that the following digits are the device ID rather
> > than something
> > else we might define in the future. Viresh picked this version because it's
> > somewhat more consistent with other subsystems.
>
> I'm fine either way, though I do find just a number a bit strange. So
> I'd lean toward adding 'device' or even just a 'd'.

I don't think just 'd' would be a good idea since it is indistinguishable from
a hexadecimal character. 'dev' would work though.

> BTW, what happens if/when the device protocol is rev'ed? A new DID or
> is there a separate revision that's discoverable?

This should normally be done using feature bits that are negotiated
between the two sides, and if only one side can do it, they use the
old revision.

There could be a new device ID but I don't think that has happened so far.

       Arnd