Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 26 Jul 2021 19:03:17 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Halil Pasic <pasic@linux.ibm.com>
Cc:     Tony Krowiak <akrowiak@linux.ibm.com>, linux-s390@vger.kernel.org,
        linux-kernel@vger.kernel.org, borntraeger@de.ibm.com,
        cohuck@redhat.com, pasic@linux.vnet.ibm.com, jjherne@linux.ibm.com,
        alex.williamson@redhat.com, kwankhede@nvidia.com, david@redhat.com
Subject: Re: [PATCH 2/2] s390/vfio-ap: replace open coded locks for
 VFIO_GROUP_NOTIFY_SET_KVM notification
Message-ID: <20210726220317.GA1721383@nvidia.com>
References: <20210719193503.793910-1-akrowiak@linux.ibm.com>
 <20210719193503.793910-3-akrowiak@linux.ibm.com>
 <20210721164550.5402fe1c.pasic@linux.ibm.com>
 <c3b80f79-6795-61ce-2dd1-f4cc7110e417@linux.ibm.com>
 <20210723162625.59cead27.pasic@linux.ibm.com>
 <5380652f-e68f-bbd0-10c0-c7d541065843@linux.ibm.com>
 <20210726223628.4d7759bf.pasic@linux.ibm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210726223628.4d7759bf.pasic@linux.ibm.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from mlx.ziepe.ca (142.162.113.129) by MN2PR15CA0062.namprd15.prod.outlook.com (2603:10b6:208:237::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.24 via Frontend Transport; Mon, 26 Jul 2021 22:03:18 +0000
Received: from jgg by mlx with local (Exim 4.94)        (envelope-from <jgg@nvidia.com>)        id 1m88gv-008pgE-B0; Mon, 26 Jul 2021 19:03:17 -0300
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7c34db67-a77c-4d6c-2026-08d950812d28
X-MS-TrafficTypeDiagnostic: BL1PR12MB5047:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BL1PR12MB50472C6AFB3C119505A0D07BC2E89@BL1PR12MB5047.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 7y+hYUdvgGBc4XvSu5Y1E0x7QYoFCzA9LU1LqkX5GPdkyKw8eq6bi7vCESBRjcRJjrm8Fu9aYu+cJKtEbq56rGqlDght09iR9urodVFvlLSXWDTrAUWRCEh4MR3k256BRtMfZczAmTeSa3PaDZGz7PKo0ZHZNHP33XzRWvGAdBEp/M7lXO6x/9RGbtJtXwfh52borcTk1aRE6vudlFPwKxb55QxJy1q5D4x8Qm3ltjhsPVnEflxZxP3JHDd8SSyO1pgPKp6tlS3FxnjQrGegw9hoGHF+bgGqGwTbGL00MSbhPy59bCsQGTpLTfQ8KW5tYzuwPxE0lFuBrLfqjkmMLb3oxciQoDi32GcWhhFZw6cqu2LPqROvJTFhxg89w6BjPbLKj+3YDStYNDMcof9Fz8HPih1dlA3iffiKtHVAG0iwHJLmSdrijtveal3VTNLuO0cqfMmyN1PeWdBI31qY5/qkFZKAyAMmL2jS8SxJUdQDU0mRF8lWf1y/o+lux1bCG1p5q/zFvY5AtqaxTlX9XK2ifdMyomAe0+9BUNhRdLHnL652cVbZLq6xl0LTH/1+I9uClRsrcGwHodjXjPOnTP/RyXu4ga4QS4BlJCoRzhaG8DL60M7u4g2xf0Mqg65GS7YLWvIfDLRFksjAmTHo8w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB5506.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(396003)(136003)(366004)(39860400002)(4744005)(4326008)(2616005)(7416002)(478600001)(8676002)(8936002)(5660300002)(86362001)(316002)(9746002)(1076003)(426003)(38100700002)(83380400001)(66476007)(66556008)(9786002)(66946007)(2906002)(26005)(6916009)(33656002)(186003)(36756003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?P8yD8bbFhqNIwmUE/db9j+yqye2Ht07RHV8icixVYhpWy7wnPyp4tb3dIUO7?=
 =?us-ascii?Q?xREbSaif5GXq7wzpauRmZ0q7/uYgstu41LKJ/NtCg73wLwq55Hpz99PAuKAr?=
 =?us-ascii?Q?hMaz/2wMUH/pYShyE8BH/yg4ZeLjM1l+cwm5lwT8+wrFxeKzQYRK4aXrkYnb?=
 =?us-ascii?Q?ZZoWBCPvWljev5Vvkt7YXoM5ltz2QKYrIU83XAcQaClGJ0nJO75PkEkMc4EV?=
 =?us-ascii?Q?nlgWZGFBQCHgYs9VYhTtb6GLnd4ZY1baW5Heooa0fVpxVK1rSDDSAqeYTfoh?=
 =?us-ascii?Q?NrgiV++8CtHuxcMq7RBg4wJT1ELqxWs6yD3T1KwgYQgqgrxIbtwwZsInCH+h?=
 =?us-ascii?Q?pTcuDZlx7uxP1Ta3KV7XLrfFMvrBR76+DXWvMydzLjxwse5jYQM0+dHq3fLI?=
 =?us-ascii?Q?Soyr5jBjxDC7AewIjsFeU0HS3SNje+buYHGHysFiisGTNGHN4RQ/5pwodzyX?=
 =?us-ascii?Q?ogF/Ql3Cyq8Zw/TrWrirtlwPr1kQE5UJuLdMLLUfptgpz0QLQHrzBEO4qE+f?=
 =?us-ascii?Q?/1fdl83WdurgyHl5egJvx7PSOSNhDklTjyqc5gWKQN+ZU5CdBZ7otSqNwF9C?=
 =?us-ascii?Q?qKMxad/zXUy/s/ZTB02S/he83JREYjTp7+o1wUzEhmErsqbz6Ut1sy6JTDxb?=
 =?us-ascii?Q?wObIeaXLvnAhnaBRw1gHpTuhE5tGBrYiz4C4C036hhO6Y3fIbwWnB3QgfKz5?=
 =?us-ascii?Q?ZrfpCTNiXWlNDJJEvj4U2m6yKDoKIUtK9tfisRUSeo/V1DxiyY56b4AmDfM3?=
 =?us-ascii?Q?1uG/+1v7w/BR3oDdhaAm7faUPKecZG/eKLk2LbYI00LASrPSCbsn/1GmDl1R?=
 =?us-ascii?Q?FdWwIZMS5SGDM1r1tCl/44skAQI6a8LqkRycuGzwFFl0/is6lyStyTUj5QXu?=
 =?us-ascii?Q?WhKuN4ragnpkO4S6FuWgplzN0nE37weDSBe03IlZXORGzO33xqV1nM1w7EBC?=
 =?us-ascii?Q?HmfCExrLCbtAvBVsfdnGq9SlIYsb200Gtlr6ZABr83ereGW6QRW55QYcAHQT?=
 =?us-ascii?Q?v6srIZKnwcWIit/wdYiaRNuSKNAKqiFj4sHHNJDf1FDSaSVD3QleaWCo7zGZ?=
 =?us-ascii?Q?ZhYokqqvliAUXwlnnnXj1RDBnhq5eGow03/wbdEXLSOrrhhqU4LnDsoNhNns?=
 =?us-ascii?Q?BB/b4SBJ6Tl+sFOfJoEvO4+FmBFxLKqP93RmJfWTJ4SAZpzRw4rkfDV1wkC/?=
 =?us-ascii?Q?Bt75UfSaf007jhLKYHYY3FEMwEkejxjh7kVGmUPwDNyl3I4Uc5CGD82NDtqb?=
 =?us-ascii?Q?aJroSYAfVqHE9WAXU7YM/raO5H/KoihNC0s+I4YlpOWCyWrlYrKJ6JBpBiAl?=
 =?us-ascii?Q?gu/UmLpc23NZAtSIqkXX2PjF?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c34db67-a77c-4d6c-2026-08d950812d28
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2021 22:03:19.1519
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JRNbGH3oDa1anxGHtv9tSYWlITlMdPv7xMQfy8LNJGNKvY+x1rOr8ejJAWPIPHbR
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5047
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 26, 2021 at 10:36:28PM +0200, Halil Pasic wrote:

> You may end up with open and close running interleaved. What I'
> trying to say is, to my best knowledge, normally there is no
> you have to close it before you open it again rule for files.

This is an existing bug in this driver, I've fixed in the reflck series.

open_device/close_device will not run concurrently, or out of order,
afer it is fixed.

Jason