Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 41/46] KVM: VMX: Smush x2APIC MSR bitmap adjustments
 into single function
To:     Sean Christopherson <seanjc@google.com>
Cc:     Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Reiji Watanabe <reijiw@google.com>
References: <20210713163324.627647-1-seanjc@google.com>
 <20210713163324.627647-42-seanjc@google.com>
 <7ddb5bfb-f274-9867-3efb-0b6ba5224aa2@redhat.com>
 <YP81dzqaD//iNr5L@google.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <f50126e3-f28e-b8e5-d09d-27c2fe25e141@redhat.com>
Date:   Tue, 27 Jul 2021 00:22:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <YP81dzqaD//iNr5L@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 27/07/21 00:21, Sean Christopherson wrote:
> On Mon, Jul 26, 2021, Paolo Bonzini wrote:
>> On 13/07/21 18:33, Sean Christopherson wrote:
>>> +	if (!(mode ^ vmx->x2apic_msr_bitmap_mode))
>>> +		return;
>> Just !=, I guess?
> Ha, yeah.  Forgot to do a bit of critical thinking after refactoring.
> 

Well, == even since I assume you don't want the ! in front. :)

Paolo