Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3904436pxv; Mon, 26 Jul 2021 15:24:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyr4mKMzXQ+IqamzSF8H9JvPJBgI6i/BGl16j3KARs6a1q3GH5PcgwbGtjXGSROAuewAEuF X-Received: by 2002:a92:c048:: with SMTP id o8mr14702214ilf.8.1627338298772; Mon, 26 Jul 2021 15:24:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627338298; cv=none; d=google.com; s=arc-20160816; b=dk96fv6qkWd8mUjNZxEYJpSTpRYeWE5ifdJYfxqeVOZCy7liIKHjmBEF1Sd9hZb6vV iJS9e1gzbaAb28rxnoTuTk2iYiFcGaTKW5IT+4eogR5CU55ddZnxM2DX1JbSDkapFI9/ ihN823MC+nISFzF+3DpGCuV3gUm+jgniXav+oI6epDacQohsE4lLHT6AGhlv+bDxryyQ 2kIOToMfRnliCAjzVDZ5GdWCJZQBEo3JQ5H9giXyRAlo6y5jiw1b7cGXoHL1cO8WsNSr sTD+Z9TsTnaBk0ZWFAumlNhcsADWDzNaQ5I1mtEA+R8fTcrG8NMgdqGTKRfdIeR2ihhb zKGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=3ODcicexHURy+S/oaAgcJ5/PC6scXaOeWpaZLuQrIGg=; b=XPID/YPXp/vjQJXT+GBviwXY3FTKpJK1O3fb8TFoJUIJ2pahYrvIPV0853LZfSoold c0XAO0BtjAx6tooRAWboGz/jS5zxduLAYsbE4CrSggFCgyhvSSvg9+to3lDqU3huJMoV 00DfdzeEEw4dZnFSyzYUhozDxhrKph4YdXNrOlOThWhLhtd9Wrx4c830IlF2RgvSvm8p QU+Glrpx0AtPKD9jTQz4NOSXiO2Y1pdEXczceLR4OSR8Lt2c63TbtTYxNbx98rS3DoHM NtNnjrwZ6nDJbq4oHPArqIJY7AVBwCmFbH+rwIJNwntzmjzf5I8t4d9B7F/xnh4wt0ql hPSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=IAzkdNqP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x17si1309226jat.44.2021.07.26.15.24.46; Mon, 26 Jul 2021 15:24:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=IAzkdNqP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233643AbhGZVlW (ORCPT + 99 others); Mon, 26 Jul 2021 17:41:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231502AbhGZVlU (ORCPT ); Mon, 26 Jul 2021 17:41:20 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17306C061757 for ; Mon, 26 Jul 2021 15:21:48 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id d1so6153241pll.1 for ; Mon, 26 Jul 2021 15:21:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3ODcicexHURy+S/oaAgcJ5/PC6scXaOeWpaZLuQrIGg=; b=IAzkdNqPCe3UCa/Ivef3h6QOhsZcQ4xoUEUHk8FeitquYy68VmMEBlXDZhPoyNW2wC WKPCGzyk2t55n2cRxI7CvdMQCOrxKVTnx2le8z0LIAYPSdKQiqbyMjNijMulDmTM3+Hy aVhddjr1X9gKKoBMcPjGBdkbxYVs3s9ZIlRt2jI5yew+ENV1wzHYblng9navUwxi3w0s MnMXl6vr0Ja+qPp7HxIW7e99dDDWl2FYv8lHi4OK0KwPl8+9ZJAE4o1XMw1B+dG7a0W+ bpAK73jUPDg8BqYnadcxMCmztL/T8dMw6BvIkzlDxUQigUtolFwEZHvzzwZqPMdEcrlR hhWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3ODcicexHURy+S/oaAgcJ5/PC6scXaOeWpaZLuQrIGg=; b=XBZtOz4JNgoJare7pZ0IF/uQQVdsKi9Nz/uhCfqXkw7BkWemRuxi/YzKejStWdho4h OcDR++isUEaB7i59jm0Awd/8h8t4GGY/USivZsNz88CSCfxetFQfc1e/tcF5T88coBYf gWZlxL8ViUFlEGLWVli/JSPtd9sCYihJY91nHgXU6cTgIZdj8P0gAOk8HfkCt7sHnlR6 JbsV0cstiGTOAR+ucMW8yoCaU3RE0ndUmTfzOL+wOl+XIXFQ9vKeXdSpXIdrs+zXeCms KyzZXCQvLBqPlyCKGxXollMGlf99/UulT1Zl5PJv0ZwubFsY9/3+vBJwYBmMbw243Pp5 wt7Q== X-Gm-Message-State: AOAM5319k94h/JVYyMDxxEieLmQc7XUfQfJjo+VEe65OruKWPJGnRUZq 8IpMfhlpWpZPNbkiG1+eRKVh0RuF0CjpAQ== X-Received: by 2002:a63:2355:: with SMTP id u21mr2182989pgm.94.1627338107450; Mon, 26 Jul 2021 15:21:47 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id g20sm1051906pfj.69.2021.07.26.15.21.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jul 2021 15:21:46 -0700 (PDT) Date: Mon, 26 Jul 2021 22:21:43 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Reiji Watanabe Subject: Re: [PATCH v2 41/46] KVM: VMX: Smush x2APIC MSR bitmap adjustments into single function Message-ID: References: <20210713163324.627647-1-seanjc@google.com> <20210713163324.627647-42-seanjc@google.com> <7ddb5bfb-f274-9867-3efb-0b6ba5224aa2@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7ddb5bfb-f274-9867-3efb-0b6ba5224aa2@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 26, 2021, Paolo Bonzini wrote: > On 13/07/21 18:33, Sean Christopherson wrote: > > + if (!(mode ^ vmx->x2apic_msr_bitmap_mode)) > > + return; > > Just !=, I guess? Ha, yeah. Forgot to do a bit of critical thinking after refactoring.