Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3922982pxv; Mon, 26 Jul 2021 16:02:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6JfO2SJ6hweo5+Yt/pKQKZRSY/6lVJF8q6BfmtcNyOn9Ke6k9fxi5mcgZdYrt+kaaIFQo X-Received: by 2002:a17:906:ecb3:: with SMTP id qh19mr6566568ejb.317.1627340532426; Mon, 26 Jul 2021 16:02:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627340532; cv=none; d=google.com; s=arc-20160816; b=NnB8Zk7M/jFcG5EaICze5XOq+s4J+gjmr9U0FoiYloCxOaA06VHgcYcSGSdbQYLgGH S9/Hx3+d085jJkRXElsTGZU4MLByYlpesX/HMySax3dHftabfb/eZ2V8sBA39npUCbZM ucINmoBMhO88gdFatgUa+7+Ysd+Op7JC4USpo+jvMJ3pLTujziH95i3IcxppMulbSMgl N+BaFfhLvPFuekxnspo5AHDwkaFYHY67hzyvfE+a9yCsrPvCMxCkG8fsnNOJcwpOX4rY gERm90QNoVPTr72WR/ssP6P3FI3FzjJsAiD8dd60Af78EonOaI33mTYzJMfb0Q5gElXB XtMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=IgP1YWplDp3/09cvQQ0d2eAW1JPxMRhx9Jd4cef5V3E=; b=KkEkorvopuzzLvrhFtqj+vWLGZxJN3mwB+gAC5KTs1Z261ixdq9fNFHY4qU1vLQHjc qpj8ytKXh3R1IBK1ZW7UgzgPKDOBxGK4fSrkJUn07tP8uM6HgUCbna7Kg1J2NejWB9Ws J+RYE2EZd4T795qZ7foIXC7YvUpcpO1b5bOK27BRg/zMspMThd4qYtBI0AGiB8fFV4UK oVnMt2XDWv3Zty/Ds9wsLpCc+Sf/E9JPAMfCzynEiJq2eqH+ODl4a3V05b70zM2aEEbV 1bQZyGjqfaMtCnQCKY7J0faL5jr5nzx4TVY/bpXUFXmr8S4f/zvP6ALOtnzoORwxlsTg uLlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=eQAl1RXP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o16si1128654edr.587.2021.07.26.16.01.49; Mon, 26 Jul 2021 16:02:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=eQAl1RXP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233735AbhGZWTg (ORCPT + 99 others); Mon, 26 Jul 2021 18:19:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231502AbhGZWTc (ORCPT ); Mon, 26 Jul 2021 18:19:32 -0400 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF180C061757; Mon, 26 Jul 2021 15:59:59 -0700 (PDT) Received: by mail-pl1-x633.google.com with SMTP id i10so10422413pla.3; Mon, 26 Jul 2021 15:59:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IgP1YWplDp3/09cvQQ0d2eAW1JPxMRhx9Jd4cef5V3E=; b=eQAl1RXPI6I/QPb5dmHK3sSJfrW/33/Xd+Kq+ZHhRC+jWg/KgNZOApZ/JQhK/b4tcM f1qBS4uW84HHhnxyahQnwsnOk6TeV1HVmF0yO6oZ898KgpEahR5N+sdrg+X1+VfFCl0K qwC+oGx/hc4Ck8IVbvOMLHUMwUeIXgYaFT+Oj+zLZblC7w0Y6qY1rgcMgZq4uzSLRKTW +awoE5DdCCWXlu137dLx92EfC9UDM3iU0vEUXbRGBxKjwCmO1pt/lsISLS2SSKvf5sYx 0I3neM8nIcFOXM3f1BOqwuSINJnC+K0ue18tjWWsOWYzDdX7vRJXkfsSFZ4ZrwcVQgCb 1iwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=IgP1YWplDp3/09cvQQ0d2eAW1JPxMRhx9Jd4cef5V3E=; b=Qgh963A+bS1UjCsI6OktP/9yPMPEQTDLyiqjkU3hmHeqLiBzX/iEaLluk5N8vAaHDl 9ZVlKqpOz5NHC/wu7ojSVHq1YCweO2weqWbLU/taavDeYIixl/yFAJhmYb/8MSv6ZEeJ 7sZOiq19tGDQiCxZ1fqhdsobV2sHbncILU3YT1kk/w70RQRneHFKWN4vACd1mrmMxpun TSR32q0iF5x68z6ctuAvsSkpwkZV/EpvgJ2671MeDRPwxLz90bC9e1I1L7nwU112LoG2 4a5IzzAkaFf/RfRgcMq73WWZSPr15SCnwEWT8U2JdYTXwHrtjjUz36jiBBfhQrvmcSR2 AisQ== X-Gm-Message-State: AOAM532WB6vNHxrDaXTK5QwKndkwxyGcU3Nw04lrnYs6EmkO3DFfnpms uVFkU6cFC888IRLbr1pO590= X-Received: by 2002:a63:1755:: with SMTP id 21mr20445764pgx.435.1627340399214; Mon, 26 Jul 2021 15:59:59 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::5:428]) by smtp.gmail.com with ESMTPSA id a22sm1046354pfv.113.2021.07.26.15.59.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jul 2021 15:59:58 -0700 (PDT) Sender: Tejun Heo Date: Mon, 26 Jul 2021 12:59:54 -1000 From: Tejun Heo To: Waiman Long Cc: Zefan Li , Johannes Weiner , Jonathan Corbet , Shuah Khan , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, Andrew Morton , Roman Gushchin , Phil Auld , Peter Zijlstra , Juri Lelli , Frederic Weisbecker , Marcelo Tosatti , Michal =?iso-8859-1?Q?Koutn=FD?= Subject: Re: [PATCH v3 2/9] cgroup/cpuset: Fix a partition bug with hotplug Message-ID: References: <20210720141834.10624-1-longman@redhat.com> <20210720141834.10624-3-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210720141834.10624-3-longman@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 20, 2021 at 10:18:27AM -0400, Waiman Long wrote: > In cpuset_hotplug_workfn(), the detection of whether the cpu list > has been changed is done by comparing the effective cpus of the top > cpuset with the cpu_active_mask. However, in the rare case that just > all the CPUs in the subparts_cpus are offlined, the detection fails > and the partition states are not updated correctly. Fix it by forcing > the cpus_updated flag to true in this particular case. > > Fixes: 4b842da276a8 ("cpuset: Make CPU hotplug work with partition") > Signed-off-by: Waiman Long Applied to cgroup/for-5.15 w/ a minor update to the comment (I dropped "just" before "all". It read weird to me.) Thanks. -- tejun