Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933172AbWKWTjJ (ORCPT ); Thu, 23 Nov 2006 14:39:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757456AbWKWTjI (ORCPT ); Thu, 23 Nov 2006 14:39:08 -0500 Received: from palinux.external.hp.com ([192.25.206.14]:24770 "EHLO mail.parisc-linux.org") by vger.kernel.org with ESMTP id S1757453AbWKWTjH (ORCPT ); Thu, 23 Nov 2006 14:39:07 -0500 Date: Thu, 23 Nov 2006 12:39:05 -0700 From: Matthew Wilcox To: Ingo Oeser Cc: Hidetoshi Seto , Linux Kernel list , linux-pci@atrey.karlin.mff.cuni.cz, Greg KH , Grant Grundler , Andrew Morton , e1000-devel@lists.sourceforge.net, linux-scsi@vger.kernel.org, Kenji Kaneshige Subject: Re: [PATCH 3/5] PCI : Add selected_regions funcs Message-ID: <20061123193905.GD6083@parisc-linux.org> References: <456404FE.1040708@jp.fujitsu.com> <200611232033.35280.ioe-lkml@rameria.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200611232033.35280.ioe-lkml@rameria.de> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 641 Lines: 12 On Thu, Nov 23, 2006 at 08:33:32PM +0100, Ingo Oeser wrote: > bitfields (and bitmask) should be unsigned and use machine word size, > which is usually "long". So please pass them in "unsigned long" instead of "int". Why? We know how many BARs PCI devices have (6. Plus ROM. Plus 4 bridge resources, making 11). We could even use a u16. An int is fine, there's no need to re-spin this patch. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/