Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20210717043159.12566-1-rdunlap@infradead.org>
References: <20210717043159.12566-1-rdunlap@infradead.org>
Subject: Re: [PATCH] clk: hisilicon: hi3559a: select RESET_HISI
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Randy Dunlap <rdunlap@infradead.org>,
        kernel test robot <lkp@intel.com>,
        Dongjiu Geng <gengdongjiu@huawei.com>, stable@vger.kernel.org,
        linux-clk@vger.kernel.org,
        Michael Turquette <mturquette@baylibre.com>
To:     Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Date:   Mon, 26 Jul 2021 17:23:45 -0700
Message-ID: <162734542596.2368309.11929983891973867074@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Precedence: bulk

Quoting Randy Dunlap (2021-07-16 21:31:59)
> The clk-hi3559a driver uses functions from reset.c so it should
> select RESET_HISI to avoid build errors.
>=20
> Fixes these build errors:
> aarch64-linux-ld: drivers/clk/hisilicon/clk-hi3559a.o: in function `hi355=
9av100_crg_remove':
> clk-hi3559a.c:(.text+0x158): undefined reference to `hisi_reset_exit'
> aarch64-linux-ld: drivers/clk/hisilicon/clk-hi3559a.o: in function `hi355=
9av100_crg_probe':
> clk-hi3559a.c:(.text+0x1f4): undefined reference to `hisi_reset_init'
> aarch64-linux-ld: clk-hi3559a.c:(.text+0x238): undefined reference to `hi=
si_reset_exit'
>=20
> Fixes: 6c81966107dc ("clk: hisilicon: Add clock driver for hi3559A SoC")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Dongjiu Geng <gengdongjiu@huawei.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: stable@vger.kernel.org
> Cc: linux-clk@vger.kernel.org
> Cc: Michael Turquette <mturquette@baylibre.com>
> ---

Applied to clk-fixes