Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v15] i2c: virtio: add a virtio i2c frontend driver
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Linux I2C <linux-i2c@vger.kernel.org>,
        "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" 
        <virtualization@lists.linux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Wolfram Sang <wsa@kernel.org>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Jason Wang <jasowang@redhat.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        yu1.wang@intel.com, conghui.chen@intel.com,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Stefan Hajnoczi <stefanha@redhat.com>,
        gregkh <gregkh@linuxfoundation.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>,
        jiedeng@alumni.sjtu.edu.cn
References: <bcf2fb9bbe965862213f27e05f87ffc91283c0c5.1627018061.git.jie.deng@intel.com>
 <CAK8P3a1=TpKLGMzvoLafjxtmoBbDL+sBMb8ZiEmTjW91Yr-cYw@mail.gmail.com>
From:   Jie Deng <jie.deng@intel.com>
Message-ID: <a65f32f6-6068-951c-c080-9ae27915b288@intel.com>
Date:   Tue, 27 Jul 2021 10:15:16 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <CAK8P3a1=TpKLGMzvoLafjxtmoBbDL+sBMb8ZiEmTjW91Yr-cYw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk


On 2021/7/23 17:03, Arnd Bergmann wrote:
> On Fri, Jul 23, 2021 at 7:44 AM Jie Deng <jie.deng@intel.com> wrote:
>
>> +
>> +       ret = virtio_i2c_setup_vqs(vi);
>> +       if (ret)
>> +               return ret;
>> +
>> +       vi->adap.owner = THIS_MODULE;
>> +       snprintf(vi->adap.name, sizeof(vi->adap.name),
>> +                "i2c_virtio at virtio bus %d", vdev->index);
>> +       vi->adap.algo = &virtio_algorithm;
>> +       vi->adap.quirks = &virtio_i2c_quirks;
>> +       vi->adap.dev.parent = &vdev->dev;
>> +       i2c_set_adapdata(&vi->adap, vi);
>> +
>> +       /*
>> +        * Setup ACPI node for controlled devices which will be probed through
>> +        * ACPI.
>> +        */
>> +       ACPI_COMPANION_SET(&vi->adap.dev, ACPI_COMPANION(pdev));
> Since there is now a generic way for virtio drivers to link up with OF
> device nodes, maybe this should be handled the same way in the
> virtio core rather than the driver?


I'm currently based on the I2C tree. Has that patch been already merged ？

Anyway, I think we can send an additional patch to remove this line once 
that

"generic way" patch is merged.

Regards,

Jie