Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <45ccb9e8c610678e72f461b1e9d61de0a4c9bc79.camel@perches.com>
Subject: Re: [PATCH v2] platform/x86/intel: Move Intel PMT drivers to new
 subfolder
From:   Joe Perches <joe@perches.com>
To:     "David E. Box" <david.e.box@linux.intel.com>, hdegoede@redhat.com,
        mgross@linux.intel.com, andriy.shevchenko@linux.intel.com
Cc:     linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org
Date:   Mon, 26 Jul 2021 20:36:30 -0700
In-Reply-To: <20210727022550.3083745-1-david.e.box@linux.intel.com>
References: <20210727022550.3083745-1-david.e.box@linux.intel.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.0-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Mon, 2021-07-26 at 19:25 -0700, David E. Box wrote:
> Move all Intel Platform Monitoring Technology drivers to
> drivers/platform/x86/intel/pmt.
[]
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -9494,7 +9494,7 @@ INTEL PMT DRIVER
> ?M:	"David E. Box" <david.e.box@linux.intel.com>
> ?S:	Maintained
> ?F:	drivers/mfd/intel_pmt.c
> -F:	drivers/platform/x86/intel_pmt_*
> +F:	drivers/platform/x86/intel/pmt/*

Unless you are suggesting you are not maintainer of any files
in any subdirectories below this directory, you should not use
a *

F:	drivers/platform/x86/intel/pmt/

> diff --git a/drivers/platform/x86/intel/Makefile b/drivers/platform/x86/intel/Makefile
[]
> @@ -7,3 +7,4 @@
> ?obj-$(CONFIG_INTEL_CHT_INT33FE)		+= int33fe/
> ?obj-$(CONFIG_INTEL_SKL_INT3472)		+= int3472/
> ?obj-$(CONFIG_INTEL_PMC_CORE)		+= pmc/
> +obj-y					+= pmt/

This seems odd.  Perhaps:

obj-$(CONFIG_PMT_CLASS)				+= pmt/

?