Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4163307pxv; Mon, 26 Jul 2021 23:45:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyYB34OgSB3X0cZRGo9NNrZd4DBxhdiVl/+1NAzEWFRwJ234YRsRwMf3epIwFLQxOhHZWer X-Received: by 2002:a05:6638:3a1:: with SMTP id z1mr19643873jap.77.1627368313000; Mon, 26 Jul 2021 23:45:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627368312; cv=none; d=google.com; s=arc-20160816; b=L+gzWvxWzDB4TfmSAKtu28reCL7n10aFF68AEo+juPQf4QE/ey9WhW94C928OyVmlv PsWxuGumoeM1V6q/Dk4NObHL6iaevK+Z+TyomMIXZs8eeEsuz44UPyKj9jQi4qiwGYnD sT58gaL+Zq8jJiQfejzfaCeuyMaYPZVsNLWR5bRLRSACUkyfX6KS58sWnsf+jJ5jLWH5 Ft3JYI5RtatCfvmjqSPUqMCuTkN+f5oXhSCS26GR9dVygsNxyFjziKLmvS0/bOZaaDBT OS0yrzfsO4fgnxfWH5mAXaH+G2WIdZg42YM5x3HJE+q3l1dtQ5H1A6RwcdQrB3fseqhq 3EiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=j+pywvtuE38h5JDuCDJqMFK7F5E9oxASJkvWdei5S+I=; b=OMEOS0cEzX4OANNHZZ0R0gjEJ6tXvt04Mf0EuwAlaqh83/C2RQX08qJR4/LkdXEJcF yclAvAenv7irT+GZlDvT11gGqD/FCVhfE5gcWeuCPQ8L3Lb7zDO/Wk9sVq8bSjY7wVLC 7PUvEv2PLXDsojiwSaNDm88BFCCQetDIke0v5+cEWo3MxZ3SSTnDauXGVVjBbsbpcRLQ D1py2kv0PZysxtw2wqtykR6krBycN7/I6ZK1oUDeWGWpQ0enNK/ObRr0CIxXZl1tuZ1z beLd0ZRZ+qS3Viz//UlQ4/0VGLABwfVm23GveLIteuqc7ZrkOZCnlrd1qkFrr4Gtl2En Svrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=jQwlmkzj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y9si2615416ilv.11.2021.07.26.23.45.01; Mon, 26 Jul 2021 23:45:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=jQwlmkzj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235437AbhG0GoD (ORCPT + 99 others); Tue, 27 Jul 2021 02:44:03 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:29080 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S235296AbhG0GoB (ORCPT ); Tue, 27 Jul 2021 02:44:01 -0400 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16R6XRRX012996; Tue, 27 Jul 2021 02:43:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=j+pywvtuE38h5JDuCDJqMFK7F5E9oxASJkvWdei5S+I=; b=jQwlmkzjh9P7FoyCFk5pJzJA3B7FCRoMvxfOV/KqmrIa1YZsDVu90kq70OQIE2GBknNm BbcZIO9vq02gP1sBhZrUDKzEQKQBEOMEu+EfEHcPoQtpDAcHwvl5UlBF3GoQgu7QJzx0 cGyt6LSbnfQnqa0FiBshtfQcwydukG8cObTkSaaopXyK36/d5F5vTmXfx/h0M9b4seHS zEUC0LLtVlHwQAWwBDOrjdhPqoWkAfFbzyLhtrMFshwBvIdN10JI9aZ0x59YWuvmb1sm Jzko08j2sJDcPBa+exH5d4qHrwTsZmHCQJ1USCMbBkGXXNmoEHNrYklG230pbwGOFun8 NQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3a2cpngvt1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jul 2021 02:43:56 -0400 Received: from m0098414.ppops.net (m0098414.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 16R6XiMJ014118; Tue, 27 Jul 2021 02:43:56 -0400 Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0b-001b2d01.pphosted.com with ESMTP id 3a2cpngvrb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jul 2021 02:43:56 -0400 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 16R6h6YG016081; Tue, 27 Jul 2021 06:43:51 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma06ams.nl.ibm.com with ESMTP id 3a235kg7h7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jul 2021 06:43:51 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 16R6hn5024642044 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Jul 2021 06:43:49 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4B491AE055; Tue, 27 Jul 2021 06:43:49 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C0253AE056; Tue, 27 Jul 2021 06:43:48 +0000 (GMT) Received: from linux.ibm.com (unknown [9.148.11.207]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 27 Jul 2021 06:43:48 +0000 (GMT) Date: Tue, 27 Jul 2021 09:43:47 +0300 From: Mike Rapoport To: Matt Turner Cc: Michael Cree , linux-mm@kvack.org, linux-alpha , LKML Subject: Re: Regression bisected to fa3354e4ea39 (mm: free_area_init: use maximal zone PFNs rather than zone sizes) Message-ID: References: <20210726192311.uffqnanxw3ac5wwi@ivybridge> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-GUID: r64KsE5Q3X3_8WyUGMpIlRaF24japlqF X-Proofpoint-ORIG-GUID: iD1VWMMgnZlP83hSMHBO19CiPP3YcZUW X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-07-27_04:2021-07-27,2021-07-27 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxlogscore=999 priorityscore=1501 bulkscore=0 adultscore=0 suspectscore=0 impostorscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 mlxscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2107270038 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 26, 2021 at 02:23:20PM -0700, Matt Turner wrote: > On Mon, Jul 26, 2021 at 1:06 PM Mike Rapoport wrote: > > > > Hi Matt, > > > > On Mon, Jul 26, 2021 at 12:27:50PM -0700, Matt Turner wrote: > > > Reply-To: > > > > > > Hi Mike! > > > > > > Since commit fa3354e4ea39 (mm: free_area_init: use maximal zone PFNs rather > > > than zone sizes), I get the following BUG on Alpha (an AlphaServer ES47 Marvel) > > > and loading userspace leads to a segfault: > > > > > > (I didn't notice this for a long time because of other unrelated regressions, > > > the pandemic, changing jobs, ...) > > > > I suspect there will be more surprises down the road :) > > > > > BUG: Bad page state in process swapper pfn:2ffc53 > > > page:fffffc000ecf14c0 refcount:0 mapcount:1 mapping:0000000000000000 index:0x0 > > > flags: 0x0() > > > raw: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > raw: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > page dumped because: nonzero mapcount Modules linked in: > > > CPU: 0 PID: 0 Comm: swapper Not tainted 5.7.0-03841-gfa3354e4ea39-dirty #26 > > > fffffc0001b5bd68 fffffc0001b5be80 fffffc00011cd148 fffffc000ecf14c0 > > > fffffc00019803df fffffc0001b5be80 fffffc00011ce340 fffffc000ecf14c0 > > > 0000000000000000 fffffc0001b5be80 fffffc0001b482c0 fffffc00027d6618 > > > fffffc00027da7d0 00000000002ff97a 0000000000000000 fffffc0001b5be80 > > > fffffc00011d1abc fffffc000ecf14c0 fffffc0002d00000 fffffc0001b5be80 > > > fffffc0001b2350c 0000000000300000 fffffc0001b48298 fffffc0001b482c0 > > > Trace: > > > [] bad_page+0x168/0x1b0 > > > [] free_pcp_prepare+0x1e0/0x290 > > > [] free_unref_page+0x2c/0xa0 > > > [] cmp_ex_sort+0x0/0x30 > > > [] cmp_ex_sort+0x0/0x30 > > > [] _stext+0x1c/0x20 > > > > > > I haven't tried reproducing this on other machines or QEMU, but I'd be glad to > > > if that helps. > > > > If it's reproducible on QEMU I can debug it locally. > > > > > Any ideas? > > > > It seems like memory map is not properly initialized. Can you enable > > CONFIG_DEBUG_MEMORY_INIT and add mminit_debug=4 to the command line. The > > interesting part of the log would be before "Memory: xK/yK available ..." > > line. > > > > Hopefully it'll give some clues. > > Sure thing. Please find attached. > aboot: loading uncompressed vmlinuz-5.7.0-03841-gfa3354e4ea39-dirty... > aboot: loading compressed vmlinuz-5.7.0-03841-gfa3354e4ea39-dirty... > aboot: PHDR 0 vaddr 0xfffffc0001010000 offset 0xc0 size 0x17c5ae0 > aboot: bss at 0xfffffc00027d5ae0, size 0xe4ea0 > aboot: zero-filling 937632 bytes at 0xfffffc00027d5ae0 > aboot: loading initrd (5965252 bytes/5825 blocks) at 0xfffffc05ff2cc000 > aboot: starting kernel vmlinuz-5.7.0-03841-gfa3354e4ea39-dirty with arguments ro panic=5 domdadm root=/dev/md1 console=srm mminit_debug=4 > Linux version 5.7.0-03841-gfa3354e4ea39-dirty (mattst88@ivybridge) (gcc version 11.1.0 (Gentoo 11.1.0-r2 p3), GNU ld (Gentoo 2.36.1 p3) 2.36.1) #26 SMP Sun Jul 25 18:20:06 PDT 2021 > printk: bootconsole [srm0] enabled > Booting on Marvel variation Marvel/EV7 using machine vector MARVEL/EV7 from SRM > Major Options: SMP EV67 VERBOSE_MCHECK DEBUG_SPINLOCK MAGIC_SYSRQ > Command line: ro panic=5 domdadm root=/dev/md1 console=srm mminit_debug=4 > memcluster 0, usage 1, start 0, end 1984 > memcluster 1, usage 0, start 1984, end 1048576 > memcluster 2, usage 1, start 2097152, end 2097224 > memcluster 3, usage 0, start 2097224, end 3145728 > Initial ramdisk at: 0x(____ptrval____) (5965252 bytes) > Found an IO7 at PID 0 > Initializing IO7 at PID 0 > FIXME: disabling master aborts > FIXME: disabling master aborts > FIXME: disabling master aborts > FIXME: disabling master aborts > SMP: 2 CPUs probed -- cpu_present_mask = 3 > Zone ranges: > DMA [mem 0x0000000000f80000-0x00000fffffffdfff] > Normal empty > Movable zone start for each node > Early memory node ranges > node 0: [mem 0x0000000000f80000-0x00000001ffffffff] > node 0: [mem 0x0000000400090000-0x00000005ffffffff] I think that the issue is that memory marked as used in memcluster is never added to memblock and it skews node/zone sizing calculations. Can you try this patch: diff --git a/arch/alpha/kernel/setup.c b/arch/alpha/kernel/setup.c index 7d56c217b235..b4fbbba30aa2 100644 --- a/arch/alpha/kernel/setup.c +++ b/arch/alpha/kernel/setup.c @@ -319,18 +319,19 @@ setup_memory(void *kernel_end) i, cluster->usage, cluster->start_pfn, cluster->start_pfn + cluster->numpages); - /* Bit 0 is console/PALcode reserved. Bit 1 is - non-volatile memory -- we might want to mark - this for later. */ - if (cluster->usage & 3) - continue; - end = cluster->start_pfn + cluster->numpages; if (end > max_low_pfn) max_low_pfn = end; memblock_add(PFN_PHYS(cluster->start_pfn), cluster->numpages << PAGE_SHIFT); + + /* Bit 0 is console/PALcode reserved. Bit 1 is + non-volatile memory -- we might want to mark + this for later. */ + if (cluster->usage & 3) + memblock_reserve(PFN_PHYS(cluster->start_pfn), + cluster->numpages << PAGE_SHIFT); } /* > Initmem setup node 0 [mem 0x0000000000f80000-0x00000005ffffffff] > percpu: Embedded 8 pages/cpu s27648 r8192 d29696 u65536 > Built 1 zonelists, mobility grouping on. Total pages: 2070535 > Kernel command line: ro panic=5 domdadm root=/dev/md1 console=srm mminit_debug=4 > Dentry cache hash table entries: 2097152 (order: 11, 16777216 bytes, linear) > Inode-cache hash table entries: 1048576 (order: 10, 8388608 bytes, linear) > Sorting __ex_table... > mem auto-init: stack:off, heap alloc:off, heap free:off > BUG: Bad page state in process swapper pfn:2ffc3f > page:fffffc000ecf0fc0 refcount:0 mapcount:1 mapping:0000000000000000 index:0x0 > flags: 0x0() > raw: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > raw: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > page dumped because: nonzero mapcount > Modules linked in: > CPU: 0 PID: 0 Comm: swapper Not tainted 5.7.0-03841-gfa3354e4ea39-dirty #26 > fffffc0001b5bd68 fffffc0001b5be80 fffffc00011cd148 fffffc000ecf0fc0 > fffffc00019803df fffffc0001b5be80 fffffc00011ce340 fffffc000ecf0fc0 > 0000000000000000 fffffc0001b5be80 fffffc0001b482c0 fffffc00027d6618 > fffffc00027da7d0 00000000002ff966 0000000000000000 fffffc0001b5be80 > fffffc00011d1abc fffffc000ecf0fc0 fffffc0002d00000 fffffc0001b5be80 > fffffc0001b2350c 0000000000300000 fffffc0001b48298 fffffc0001b482c0 > Trace: > [] bad_page+0x168/0x1b0 > [] free_pcp_prepare+0x1e0/0x290 > [] free_unref_page+0x2c/0xa0 > [] cmp_ex_sort+0x0/0x30 > [] cmp_ex_sort+0x0/0x30 > [] _stext+0x1c/0x20 ... > Memory: 16496504K/16760768K available (8698K kernel code, 12790K rwdata, 2544K rodata, 304K init, 915K bss, 256576K reserved, 0K cma-reserved) -- Sincerely yours, Mike.