Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 27 Jul 2021 19:50:39 +1000 (AEST)
From:   Finn Thain <fthain@linux-m68k.org>
To:     =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, kernel@pengutronix.de,
        linux-m68k@lists.linux-m68k.org
Subject: Re: [PATCH 1/5] nubus: Simplify check in remove callback
In-Reply-To: <20210727080840.3550927-2-u.kleine-koenig@pengutronix.de>
Message-ID: <d74ccd1-116d-9450-5ee4-8d5074998872@linux-m68k.org>
References: <20210727080840.3550927-1-u.kleine-koenig@pengutronix.de> <20210727080840.3550927-2-u.kleine-koenig@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="-1463811774-245338131-1627379007=:27"
Content-ID: <7a42c831-acd5-2e2f-28c2-99efc32374e2@nippy.intranet>
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

---1463811774-245338131-1627379007=:27
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Content-ID: <eb76bb50-e32-3e93-cf95-e39ea524d11f@nippy.intranet>

On Tue, 27 Jul 2021, Uwe Kleine-K=C3=B6nig wrote:

> The driver core only calls a remove callback when the device was
> successfully bound (aka probed) before. So dev->driver is never NULL.
>=20

Are you sure dev->driver is non-NULL for the lifetime of the device?
A quick glance at device_reprobe() makes me wonder about that.

> Apart from that, the compiler might already assume dev->driver being
> non-NULL after to_nubus_driver(dev->driver) was called.
>=20

I don't understand how a compiler can make that assumption. But then, I=20
don't know why compilers do a lot of the things they do...

> Signed-off-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/nubus/bus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/nubus/bus.c b/drivers/nubus/bus.c
> index d9d04f27f89b..17fad660032c 100644
> --- a/drivers/nubus/bus.c
> +++ b/drivers/nubus/bus.c
> @@ -33,7 +33,7 @@ static void nubus_device_remove(struct device *dev)
>  {
>  =09struct nubus_driver *ndrv =3D to_nubus_driver(dev->driver);
> =20
> -=09if (dev->driver && ndrv->remove)
> +=09if (ndrv->remove)
>  =09=09ndrv->remove(to_nubus_board(dev));
>  }
> =20
>=20
---1463811774-245338131-1627379007=:27--