Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4260393pxv; Tue, 27 Jul 2021 02:57:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxnDX3+rZ7ks2uJUA7RjcnOqfLsRB4MQPWlNhxY0QA4/bu93QJRc+i0qCvyOfCquX89m3V3 X-Received: by 2002:a5e:c912:: with SMTP id z18mr18521187iol.9.1627379860129; Tue, 27 Jul 2021 02:57:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627379860; cv=none; d=google.com; s=arc-20160816; b=uW421FMNiQnPuVmAmuciRfJ9yD1YK6EPl1Vyrha7H/JsXxNfSZJdxlAEZv6hZ+0Kmv VlT6t4w3etgTs4QiIZtfAkYHg3ODb2tuykdpdSOOZgqkPIwNeodtDJWKKTcfomqTOFMs SRIQoRNQD5nE+8a7+3tCoXH2i5JCyz4YbEdIGyOQbLQnGjIArPKKY1MRHAbEicQWA5Nn +FonBnoQ9O5eiO0hSbgRvWCKSDY3S7S27gTQvOQIq7NnoDE81BHOUUrqtEehp/60UY6Q 5MAG+uNKn9NwuJqyLZvUIbbWu972ltr48V48+degMBJMiDQFXFFsTZ0VKN2JguMSaRWj UHEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=sNEnWkddZYUM6eK09pUppKXoCVksrajDlYRbG+6v7kE=; b=GC6861BFaEv+Cba1tLPRCEAzBcI7jhn4YEMQ12bVAVxbL0+4e/109Ta4M3k722qLAS UvkXRVRBwRkZTlvbsR181rCd+jZLhqcYtp5SDlJsKwxLKbFlTGPwLODFTMkgk1OOhnTq Vw6nwfKJzqNcKTj8ZcPaJWbBAwFtjEV8SObDLACnyCPN6TAUvboiu9oUWQNxGG7YfGyi B608kJQhkWD1D7huPqfRYQVYOV4zlblMMXPwE3yu7gbxLYOEn0t9QXPdLhooF3NlNoBk EKweWdGYLXFFNVhUbmUyK5Oa1aG7KWHQgWDeaaWfUUgvvE0CAz/XFvlbJS7vWYpWnHj7 5kOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b25si1214181ioh.46.2021.07.27.02.57.28; Tue, 27 Jul 2021 02:57:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236151AbhG0J4d (ORCPT + 99 others); Tue, 27 Jul 2021 05:56:33 -0400 Received: from muru.com ([72.249.23.125]:55736 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235950AbhG0J4c (ORCPT ); Tue, 27 Jul 2021 05:56:32 -0400 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 8803B80F0; Tue, 27 Jul 2021 09:56:46 +0000 (UTC) Date: Tue, 27 Jul 2021 12:56:27 +0300 From: Tony Lindgren To: Zhen Lei Cc: Haojian Zhuang , Linus Walleij , linux-arm-kernel , linux-omap , linux-gpio , linux-kernel Subject: Re: [PATCH v2 2/2] pinctrl: single: Move test PCS_HAS_PINCONF in pcs_parse_bits_in_pinctrl_entry() to the beginning Message-ID: References: <20210722033930.4034-1-thunder.leizhen@huawei.com> <20210722033930.4034-3-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210722033930.4034-3-thunder.leizhen@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Zhen Lei [210722 03:40]: > The value of pcs->flags is not overwritten in function > pcs_parse_bits_in_pinctrl_entry() and its subfunctions, so moving this > check to the beginning of the function eliminates unnecessary rollback > operations. Looks OK to me: Reviewed-by: Tony Lindgren