Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   =?utf-8?Q?Krzysztof_Ha=C5=82asa?= <khalasa@piap.pl>
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc:     devicetree@vger.kernel.org,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Rob Herring <robh+dt@kernel.org>, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org, Sakari Ailus <sakari.ailus@iki.fi>
Subject: Re: [RFC v3] dt-binding: media: document ON Semi AR0521 sensor
 bindings
References: <m37dhkdrat.fsf@t19.piap.pl>
        <YP9ccgd7WNpHuLgG@pendragon.ideasonboard.com>
Sender: khalasa@piap.pl
Date:   Tue, 27 Jul 2021 12:36:20 +0200
In-Reply-To: <YP9ccgd7WNpHuLgG@pendragon.ideasonboard.com> (Laurent Pinchart's
        message of "Tue, 27 Jul 2021 04:08:02 +0300")
Message-ID: <m3o8aoavrv.fsf@t19.piap.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Laurent,

Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes:

>> +        properties:
>> +          data-lanes:
>> +            anyOf:
>> +              - items:
>> +                  - const: 1
>> +              - items:
>> +                  - const: 1
>> +                  - const: 2
>> +              - items:
>> +                  - const: 1
>> +                  - const: 2
>> +                  - const: 3
>> +                  - const: 4
>
> As the sensor also supports an HiSPi output, I would add the bus-type
> property:
>
>           data-lanes:
> 	    const: 4

Is there any example of this? I'm not sure how should it it look like.
Something like the following?

        properties:
         data-lanes:
            anyOf:
              - items:
                  - const: 1
              - items:
                  - const: 1
                  - const: 2
              - items:
                  - const: 1
                  - const: 2
                  - const: 3
                  - const: 4
          bus-type:
            data-lanes:
              const: 4

And... HiSPi would need additional code in the driver. And preferably
some testing. I think I'd prefer to have DT and the driver staying in
some sort of sync. Also, I'm uncertain about the syntax and the meaning
of such, apparently redundant, construct. Nor about its relation to
HiSPi. An example would be welcome.
--=20
Krzysztof "Chris" Ha=C5=82asa

Sie=C4=87 Badawcza =C5=81ukasiewicz
Przemys=C5=82owy Instytut Automatyki i Pomiar=C3=B3w PIAP
Al. Jerozolimskie 202, 02-486 Warszawa