Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4313446pxv; Tue, 27 Jul 2021 04:28:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzxKQapNfchzAOzO0MnZXNnCwD+WoE0LF98K1ZYJDAHudHNxDGnyGVEFHiJBeqphet0Ogoj X-Received: by 2002:a05:6e02:12e3:: with SMTP id l3mr12146014iln.6.1627385282155; Tue, 27 Jul 2021 04:28:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627385282; cv=none; d=google.com; s=arc-20160816; b=YiuY9Ioxw+0ED+0wO0FEFgl+M44cKAHkKeiFY66ulUsYmCNBuJwFWNYhBtF3A9Cg5B PuFEXTw9Dj8BCqPkCWBxF/M7xPcbUGQJvl5NiGh0TCAnxVmL8AvgJE3smfvV44iuN74C unScspVFI5EB0cgfhqS0lX0WhjpKiNp/OKawT2GZ+oe6MJQBlFxd1UzmGlWxmhZZJpPt 6bvISnSTCFWZc8FERGMjeN0vWptIjeStaW2VNtGcD8wCPAXC6NI50VR/m41GZCQN/lXJ psGvyyeebNGHe/5UEzjeqtRlUwSdUI0HHdx9cbE+eXJhYKPmw/NJ8Y5YA4utzpLhA5e8 qePA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:organization:openpgp:from :references:cc:to:subject:dkim-signature; bh=M1Y1Bi+/XzR8aD3czNXZAgEd3QFIxYcO7CoIJoDYBM0=; b=VXJ7p2WXME8sezVXfMP5+87fqdcXsFIjGa8LL/mJe9Q+uau/pAIxGJqkiMw4RuKvQv 2CIu/socApsxyBDazFhBL84d3Q7h+hNMynxDMk4gytg/Y1LXtV2v9vC3TyLzeGyuO2tU B0y5Zi8G8OM0R/WOapqEsuF1L6S+rDPZx60Tv4cDi1ZpIBsTD1M2ly6CK16yYN/BlwV9 gXjIzLd8sLiQl9ZVkn2Gc0IhEMdZZthqf5X0F0/u1JWnuNq3jmBfFE+xPaJh6l9/qOvu VtCuJeyJQZT3vQmLBeMp5kbS2GkuOvF9GWXUO9MvsPBzcqWPhpcpJR4MM+PMvvpnxEre 5lSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@elsoft.ch header.s=sel2011a header.b=eESr91Ma; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=elsoft.ch Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y13si3312253ioq.14.2021.07.27.04.27.50; Tue, 27 Jul 2021 04:28:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@elsoft.ch header.s=sel2011a header.b=eESr91Ma; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=elsoft.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236462AbhG0L0E (ORCPT + 99 others); Tue, 27 Jul 2021 07:26:04 -0400 Received: from mail.hostpark.net ([212.243.197.30]:36594 "EHLO mail.hostpark.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236320AbhG0L0D (ORCPT ); Tue, 27 Jul 2021 07:26:03 -0400 X-Greylist: delayed 559 seconds by postgrey-1.27 at vger.kernel.org; Tue, 27 Jul 2021 07:26:02 EDT Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id C000A163CB; Tue, 27 Jul 2021 13:16:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=elsoft.ch; h= content-transfer-encoding:content-type:content-type:in-reply-to :mime-version:user-agent:date:date:message-id:organization:from :from:references:subject:subject:received:received; s=sel2011a; t=1627384600; bh=nnN5lZfFj9MppOjkb9i1D7D+MJTulP6KsKyauxX4sGo=; b= eESr91MaPfXJrnskyOyzLqbm1XhuG04+D86JOWAVA9IL+sGz+lm0QWKyU4w/uMqN UtKagNjJkDUuFIxWMwQ4LjBgm83pypHT4iXjnISq80yy/DmbNIiNBbLiJjvo2pto ATTm0dxI5+bH/WdJaLzFKkDefW0DncAPjodyFFWUTSk= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id b9k2yq6cDK1n; Tue, 27 Jul 2021 13:16:40 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTPA id 3348E164A0; Tue, 27 Jul 2021 13:16:40 +0200 (CEST) Subject: Re: [PATCH 10/14] peci: Add peci-cpu driver To: Iwona Winiarska , linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org Cc: linux-aspeed@lists.ozlabs.org, linux-doc@vger.kernel.org, Jae Hyun Yoo , Mauro Carvalho Chehab , Jonathan Corbet , x86@kernel.org, Pierre-Louis Bossart , Ingo Molnar , Guenter Roeck , devicetree@vger.kernel.org, Jean Delvare , Rob Herring , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, Tony Luck , Andrew Jeffery , Greg Kroah-Hartman , Yazen Ghannam References: <20210712220447.957418-1-iwona.winiarska@intel.com> <20210712220447.957418-11-iwona.winiarska@intel.com> From: =?UTF-8?Q?David_M=c3=bcller_=28ELSOFT_AG=29?= Openpgp: preference=signencrypt Organization: ELSOFT AG Message-ID: <26dbd0d3-c326-96a5-2ec7-4fc3387865e9@elsoft.ch> Date: Tue, 27 Jul 2021 13:16:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.5 MIME-Version: 1.0 In-Reply-To: <20210712220447.957418-11-iwona.winiarska@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Iwona Winiarska wrote: > +static const struct peci_device_id peci_cpu_device_ids[] = { > + { /* Haswell Xeon */ > + .family = 6, > + .model = INTEL_FAM6_HASWELL_X, > + .data = "hsx", > + }, > + { /* Broadwell Xeon */ > + .family = 6, > + .model = INTEL_FAM6_BROADWELL_X, > + .data = "bdx", > + }, > + { /* Broadwell Xeon D */ > + .family = 6, > + .model = INTEL_FAM6_BROADWELL_D, > + .data = "skxd", I think this should read "bdxd" as "skxd" does not exist in the cputemp/dimmtemp drivers.