Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4326385pxv; Tue, 27 Jul 2021 04:50:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzg/xZq+IUrP7CP6EYdpOZLexkMYk1tnWlNQ20MjajWGmjIG9E73AVNPSfSNKhvFf+r89qN X-Received: by 2002:a17:906:919:: with SMTP id i25mr20681565ejd.171.1627386630161; Tue, 27 Jul 2021 04:50:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627386630; cv=none; d=google.com; s=arc-20160816; b=OGjp3VU1RORmANteUKZS7MCaWTR651EOD5PX3ATndDXty1ovMSHTvikQe9W4i25A5n MXhZ25n6kx4mqR8oWyd2b2EHatLUy3briuxU3ZVExzkvQIHzcoGb/36WJBFNkOXytM0u 9RWJ0NJqRmNmq6Y/kup7zFBMs1MCKjIoS+h2C21PW44Yql8w+ttaeGAzxOTPmX7SyINB OlkhQNvL9xa6lU8rnvfolt7c4yviP6qWkwwWuIRAYqfGURRcJxHlbh8nHQnE87XfOggU iwxuSh02yVM9xHngO7hIFP3TN/0kNndh++8A/vzREM63bMhFQC0aL/V51sZan3KYVvPf fwAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=amNN9ICmSy0CIVY3BfkjSZ+Y52dJCXLET8MjYMJxcRY=; b=sm53X1xzhMp0LEY1UrSHwZLEzy2xtjqiogjRU5I24tqZfurHJhezvKDQXyqAx32Iro v4nHZrtHzE4RLw0z4bhnGYQggZuokWAFnVuTzT4aEyn+UNhRmyKfR67tCEcDT+CdjwP3 lcsqxT6jo7a6i0tIcDKOBgocDjVY/oAAxyimUwKxeEx8f1gzJ5IVBjT/DZeMh+GIyXus eCOar2Od1ZFH28FgUOULUAxgOnsXuCKxlCGz1cRFueoWhwkA00AKCNmD4b+fhWBrRVhS kqWSYJZQFiUuia9jAI/d19RsMORmGtddw/stkRMcY7qTNVgu84LjWEQSCS7gDn+SHsg+ xiBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=IxH8llkw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n30si2505778edb.121.2021.07.27.04.50.07; Tue, 27 Jul 2021 04:50:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=IxH8llkw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236419AbhG0LsQ (ORCPT + 99 others); Tue, 27 Jul 2021 07:48:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231822AbhG0LsP (ORCPT ); Tue, 27 Jul 2021 07:48:15 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C078C061757 for ; Tue, 27 Jul 2021 04:48:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=amNN9ICmSy0CIVY3BfkjSZ+Y52dJCXLET8MjYMJxcRY=; b=IxH8llkwulKXXSh6OvycrTVgSK QZCBD45U22q3e4ZQBfB5GqMco8wIRURRoyN0H5TXp/+2ndJUUOpqwGHxTYM8mW6jcg3hee0KgRyHZ 59GXle0LFmt24/kM5MZriLCjau7tDrcHfb4HfC+9BdLUR27DCvd9C7Dy2rR8s3A5Ygp89RoxsYB15 gdGCuBLp1Gx/qKh61/rgDanAPZzb7sSSrakS+OaR9cvj9t4vlM4z06AbrKu+DDJDji8olnPwtPiYO 3M91tb2xFPoay8x5JxcM9vSFDaH6VLXxRPp9EUbK1QnB50S/4qdJKTt4dDYrIhAsp4gUfE87LRjgJ jy/vA5Cg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8LXf-00EyC9-6Q; Tue, 27 Jul 2021 11:46:50 +0000 Date: Tue, 27 Jul 2021 12:46:35 +0100 From: Matthew Wilcox To: Wang Qing Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: folio: use copy_highpage() instead of folio_migrate_copy() when copy once Message-ID: References: <1627356775-28742-1-git-send-email-wangqing@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1627356775-28742-1-git-send-email-wangqing@vivo.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 27, 2021 at 11:32:54AM +0800, Wang Qing wrote: > folio_migrate_copy() will call cond_resched(), even if it only needs to be > copied once, restore the previous implementation before there is a better > solution: use copy_highpage() when copy once. no. i already fixed this on july 22. https://lore.kernel.org/linux-mm/YPmB60EwQPpEvdb%2F@casper.infradead.org/